linux-sg2042/sound/core
Clemens Ladisch b406e6103b ALSA: pcm: fix delta calculation at boundary wraparound
In the cleanup of the hw_ptr update functions in 2.6.33, the calculation
of the delta value was changed to use the modulo operator to protect
against a negative difference due to the pointer wrapping around at the
boundary.

However, the ptr variables are unsigned, so a negative difference would
result in the two complement's value which has no relation to the actual
difference relative to the boundary; the result is typically some value
near LONG_MAX-boundary.  Furthermore, even if the modulo operation would
be done with signed types, the result of a negative dividend could be
negative.

The invalid delta value is then caught by the following checks, but this
means that the pointer update is ignored.

To fix this, use a range check as in the other pointer calculations.

Signed-off-by: Clemens Ladisch <clemens@ladisch.de>
Cc: <stable@kernel.org>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
2010-05-25 20:23:48 +02:00
..
oss
seq
Kconfig
Makefile
control.c
control_compat.c
device.c
hrtimer.c
hwdep.c
hwdep_compat.c
info.c
info_oss.c
init.c
isadma.c
jack.c
memalloc.c
memory.c
misc.c
pcm.c
pcm_compat.c
pcm_lib.c ALSA: pcm: fix delta calculation at boundary wraparound 2010-05-25 20:23:48 +02:00
pcm_memory.c
pcm_misc.c
pcm_native.c
pcm_timer.c
rawmidi.c
rawmidi_compat.c
rtctimer.c
sgbuf.c
sound.c
sound_oss.c
timer.c
timer_compat.c
vmaster.c