linux-sg2042/fs/overlayfs
Amir Goldstein 972d0093c2 ovl: force r/o mount when index dir creation fails
When work dir creation fails, a warning is emitted and overlay is
mounted r/o. Trying to remount r/w will fail with no work dir.

When index dir creation fails, the same warning is emitted and overlay
is mounted r/o, but trying to remount r/w will succeed. This may cause
unintentional corruption of filesystem consistency.

Adjust the behavior of index dir creation failure to that of work dir
creation failure and do not allow to remount r/w. User needs to state
an explicitly intention to work without an index by mounting with
option 'index=off' to allow r/w mount with no index dir.

When mounting with option 'index=on' and no 'upperdir', index is
implicitly disabled, so do not warn about no file handle support.

The issue was introduced with inodes index feature in v4.13, but this
patch will not apply cleanly before ovl_fill_super() re-factoring in
v4.15.

Fixes: 02bcd15774 ("ovl: introduce the inodes index dir feature")
Cc: <stable@vger.kernel.org> #v4.13
Signed-off-by: Amir Goldstein <amir73il@gmail.com>
Signed-off-by: Miklos Szeredi <mszeredi@redhat.com>
2018-01-24 10:19:14 +01:00
..
Kconfig ovl: don't follow redirects if redirect_dir=off 2017-12-11 11:28:10 +01:00
Makefile ovl: split super.c 2016-12-16 11:02:56 +01:00
copy_up.c ovl: fix inconsistent d_ino for legacy merge dir 2018-01-24 10:18:19 +01:00
dir.c ovl: take lower dir inode mutex outside upper sb_writers lock 2018-01-19 17:43:23 +01:00
inode.c ovl: hash directory inodes for fsnotify 2018-01-19 13:54:33 +01:00
namei.c ovl: fix inconsistent d_ino for legacy merge dir 2018-01-24 10:18:19 +01:00
overlayfs.h ovl: fix inconsistent d_ino for legacy merge dir 2018-01-24 10:18:19 +01:00
ovl_entry.h ovl: don't follow redirects if redirect_dir=off 2017-12-11 11:28:10 +01:00
readdir.c ovl: take mnt_want_write() for removing impure xattr 2018-01-19 17:43:24 +01:00
super.c ovl: force r/o mount when index dir creation fails 2018-01-24 10:19:14 +01:00
util.c ovl: hash directory inodes for fsnotify 2018-01-19 13:54:33 +01:00