Magnus Karlsson 8bee683384 xsk: Fix memory leak for failed bind ... Fix a possible memory leak when a bind of an AF_XDP socket fails. When the fill and completion rings are created, they are tied to the socket. But when the buffer pool is later created at bind time, the ownership of these two rings are transferred to the buffer pool as they might be shared between sockets (and the buffer pool cannot be created until we know what we are binding to). So, before the buffer pool is created, these two rings are cleaned up with the socket, and after they have been transferred they are cleaned up together with the buffer pool. The problem is that ownership was transferred before it was absolutely certain that the buffer pool could be created and initialized correctly and when one of these errors occurred, the fill and completion rings did neither belong to the socket nor the pool and where therefore leaked. Solve this by moving the ownership transfer to the point where the buffer pool has been completely set up and there is no way it can fail. Fixes: 7361f9c3d7 ("xsk: Move fill and completion rings to buffer pool") Reported-by: syzbot+cfa88ddd0655afa88763@syzkaller.appspotmail.com Signed-off-by: Magnus Karlsson <magnus.karlsson@intel.com> Signed-off-by: Daniel Borkmann <daniel@iogearbox.net> Acked-by: Björn Töpel <bjorn.topel@intel.com> Link: https://lore.kernel.org/bpf/20201214085127.3960-1-magnus.karlsson@gmail.com		2020-12-17 22:48:55 +01:00
..
6lowpan	…
9p	net: 9p: Fix kerneldoc warnings of missing parameters etc	2020-11-02 12:25:52 -08:00
802	…
8021q	net: vlan: Fixed signedness in vlan_group_prealloc_vid()	2020-09-28 00:51:39 -07:00
appletalk	net: appletalk: fix kerneldoc warnings	2020-10-30 11:48:17 -07:00
atm	atm: nicstar: Replace in_interrupt() usage	2020-11-18 16:43:55 -08:00
ax25	Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net	2020-07-25 17:49:04 -07:00
batman-adv	batman-adv: Drop unused soft-interface.h include in fragmentation.c	2020-12-04 08:41:16 +01:00
bluetooth	Bluetooth: Increment management interface revision	2020-12-07 17:02:00 +02:00
bpf	bpf: fix raw_tp test run in preempt kernel	2020-09-30 08:34:08 -07:00
bpfilter	Revert "bpfilter: Fix build error with CONFIG_BPFILTER_UMH"	2020-10-15 12:33:24 -07:00
bridge	net: bridge: Fix a warning when del bridge sysfs	2020-12-14 18:27:49 -08:00
caif	caif: Remove duplicate macro SRVL_CTRL_PKT_SIZE	2020-09-05 15:57:05 -07:00
can	Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net	2020-12-11 22:29:38 -08:00
ceph	libceph: clear con->out_msg on Policy::stateful_server faults	2020-10-12 15:29:27 +02:00
core	Networking updates for 5.11	2020-12-15 13:22:29 -08:00
dcb	net: dcb: Fix kerneldoc warnings	2020-10-30 11:59:54 -07:00
dccp	Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net	2020-11-27 18:25:27 -08:00
decnet	treewide: rename nla_strlcpy to nla_strscpy.	2020-11-16 08:08:54 -08:00
dns_resolver	…
dsa	net: dsa: print the MTU value that could not be set	2020-12-08 11:24:07 -08:00
ethernet	net: datagram: fix some kernel-doc markups	2020-11-17 14:15:03 -08:00
ethtool	Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net	2020-12-11 22:29:38 -08:00
hsr	genetlink: move to smaller ops wherever possible	2020-10-02 19:11:11 -07:00
ieee802154	treewide: rename nla_strlcpy to nla_strscpy.	2020-11-16 08:08:54 -08:00
ife	…
ipv4	Networking updates for 5.11	2020-12-15 13:22:29 -08:00
ipv6	Networking updates for 5.11	2020-12-15 13:22:29 -08:00
iucv	net/af_iucv: use DECLARE_SOCKADDR to cast from sockaddr	2020-12-08 15:56:53 -08:00
kcm	net: pass a sockptr_t into ->setsockopt	2020-07-24 15:41:54 -07:00
key	Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net	2020-08-02 01:02:12 -07:00
l2tp	genetlink: move to smaller ops wherever possible	2020-10-02 19:11:11 -07:00
l3mdev	net: l3mdev: Fix kerneldoc warning	2020-10-30 11:43:42 -07:00
lapb	net/lapb: fix t1 timer handling for LAPB_STATE_0	2020-11-27 17:22:51 -08:00
llc	net: llc: Fix kerneldoc warnings	2020-10-30 11:34:09 -07:00
mac80211	A new set of wireless changes:	2020-12-12 10:07:56 -08:00
mac802154	net: mac802154: convert tasklets to use new tasklet_setup() API	2020-11-07 10:40:56 -08:00
mpls	mpls: drop skb's dst in mpls_forward()	2020-11-03 12:55:53 -08:00
mptcp	Networking updates for 5.11	2020-12-15 13:22:29 -08:00
ncsi	net/ncsi: Fix netlink registration	2020-11-12 17:00:13 -08:00
netfilter	Merge git://git.kernel.org/pub/scm/linux/kernel/git/pablo/nf-next	2020-12-14 15:43:21 -08:00
netlabel	Merge https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net	2020-11-19 19:08:46 -08:00
netlink	netlink: export policy in extended ACK	2020-10-09 20:22:32 -07:00
netrom	treewide: Use fallthrough pseudo-keyword	2020-08-23 17:36:59 -05:00
nfc	net: sched: fix spelling mistake in Kconfig "trys" -> "tries"	2020-12-08 16:01:56 -08:00
nsh	…
openvswitch	net: openvswitch: fix TTL decrement exception action execution	2020-12-14 17:18:25 -08:00
packet	net: fix proc_fs init handling in af_packet and tls	2020-12-14 19:39:30 -08:00
phonet	treewide: Use fallthrough pseudo-keyword	2020-08-23 17:36:59 -05:00
psample	genetlink: move to smaller ops wherever possible	2020-10-02 19:11:11 -07:00
qrtr	wireless-drivers-next patches for v5.11	2020-12-04 10:56:37 -08:00
rds	RDMA: Add rdma_connect_locked()	2020-10-28 09:14:49 -03:00
rfkill	rfkill: add a reason to the HW rfkill state	2020-12-11 12:47:17 +01:00
rose	rose: Fix Null pointer dereference in rose_send_frame()	2020-11-20 10:04:58 -08:00
rxrpc	net: rxrpc: convert comma to semicolon	2020-12-09 16:23:07 -08:00
sched	Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net	2020-12-11 22:29:38 -08:00
sctp	sctp: Fix some typo	2020-11-23 17:44:11 -08:00
smc	net/smc: Add support for obtaining SMCR device list	2020-12-01 17:56:13 -08:00
strparser	…
sunrpc	net: datagram: fix some kernel-doc markups	2020-11-17 14:15:03 -08:00
switchdev	net: switchdev: Fixed kerneldoc warning	2020-09-23 17:46:31 -07:00
tipc	Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net	2020-12-11 22:29:38 -08:00
tls	net: fix proc_fs init handling in af_packet and tls	2020-12-14 19:39:30 -08:00
unix	networking changes for the 5.10 merge window	2020-10-15 18:42:13 -07:00
vmw_vsock	af_vsock: Assign the vsock transport considering the vsock address flags	2020-12-14 19:33:39 -08:00
wireless	A new set of wireless changes:	2020-12-12 10:07:56 -08:00
x25	net: x25: Remove unimplemented X.25-over-LLC code stubs	2020-12-12 17:15:33 -08:00
xdp	xsk: Fix memory leak for failed bind	2020-12-17 22:48:55 +01:00
xfrm	Merge branch 'master' of git://git.kernel.org/pub/scm/linux/kernel/git/klassert/ipsec-next	2020-12-12 12:28:42 -08:00
Kconfig	wimax: move out to staging	2020-10-29 19:27:45 +01:00
Makefile	wimax: move out to staging	2020-10-29 19:27:45 +01:00
compat.c	iov_iter: transparently handle compat iovecs in import_iovec	2020-10-03 00:02:13 -04:00
devres.c	net: devres: rename the release callback of devm_register_netdev()	2020-06-30 15:57:34 -07:00
socket.c	net: Remove the err argument from sock_from_file	2020-12-04 22:32:40 +01:00
sysctl_net.c	…