Masahiro Yamada 12a5b00a53 sparc,x86: vdso: remove meaningless undefining CONFIG_OPTIMIZE_INLINING ... The code, #undef CONFIG_OPTIMIZE_INLINING, is not working as expected because <linux/compiler_types.h> is parsed before vclock_gettime.c since 28128c61e0 ("kconfig.h: Include compiler types to avoid missed struct attributes"). Since then, <linux/compiler_types.h> is included really early by using the '-include' option. So, you cannot negate the decision of <linux/compiler_types.h> in this way. You can confirm it by checking the pre-processed code, like this: $ make arch/x86/entry/vdso/vdso32/vclock_gettime.i There is no difference with/without CONFIG_CC_OPTIMIZE_FOR_SIZE. It is about two years since 28128c61e0. Nobody has reported a problem (or, nobody has even noticed the fact that this code is not working). It is ugly and unreliable to attempt to undefine a CONFIG option from C files, and anyway the inlining heuristic is up to the compiler. Just remove the broken code. Signed-off-by: Masahiro Yamada <masahiroy@kernel.org> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Reviewed-by: Nathan Chancellor <natechancellor@gmail.com> Acked-by: Miguel Ojeda <miguel.ojeda.sandonis@gmail.com> Cc: Arnd Bergmann <arnd@arndb.de> Cc: Ingo Molnar <mingo@redhat.com> Cc: Thomas Gleixner <tglx@linutronix.de> Cc: Masahiro Yamada <masahiroy@kernel.org> Cc: Borislav Petkov <bp@alien8.de> Cc: "H. Peter Anvin" <hpa@zytor.com> Cc: David Miller <davem@davemloft.net> Link: http://lkml.kernel.org/r/20200220110807.32534-1-masahiroy@kernel.org Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>		2020-04-07 10:43:42 -07:00
..
vdso32	sparc,x86: vdso: remove meaningless undefining CONFIG_OPTIMIZE_INLINING	2020-04-07 10:43:42 -07:00
.gitignore	.gitignore: add SPDX License Identifier	2020-03-25 11:50:48 +01:00
Makefile	kbuild: rename hostprogs-y/always to hostprogs/always-y	2020-02-04 01:53:07 +09:00
checkundef.sh	sparc: Validate VDSO for undefined symbols.	2018-10-22 16:09:27 -07:00
vclock_gettime.c	y2038: vdso: change timespec to __kernel_old_timespec	2019-11-15 14:38:28 +01:00
vdso-layout.lds.S	sparc: Fix VDSO build with older binutils.	2018-10-25 10:36:19 -07:00
vdso-note.S	vDSO for sparc	2017-11-15 14:21:03 +09:00
vdso.lds.S	sparc: Fix VDSO build with older binutils.	2018-10-25 10:36:19 -07:00
vdso2c.c	sparc: Improve VDSO instruction patching.	2018-10-22 15:22:14 -07:00
vdso2c.h	sparc: Fix VDSO build with older binutils.	2018-10-25 10:36:19 -07:00
vma.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 214	2019-05-30 11:29:54 -07:00