Gabriel Krisman Bertazi 5686dee34d dm multipath: use updated MPATHF_QUEUE_IO on mapping for bio-based mpath ... When adding devices that don't have a scsi_dh on a BIO based multipath, I was able to consistently hit the warning below and lock-up the system. The problem is that __map_bio reads the flag before it potentially being modified by choose_pgpath, and ends up using the older value. The WARN_ON below is not trivially linked to the issue. It goes like this: The activate_path delayed_work is not initialized for non-scsi_dh devices, but we always set MPATHF_QUEUE_IO, asking for initialization. That is fine, since MPATHF_QUEUE_IO would be cleared in choose_pgpath. Nevertheless, only for BIO-based mpath, we cache the flag before calling choose_pgpath, and use the older version when deciding if we should initialize the path. Therefore, we end up trying to initialize the paths, and calling the non-initialized activate_path work. [ 82.437100] ------------[ cut here ]------------ [ 82.437659] WARNING: CPU: 3 PID: 602 at kernel/workqueue.c:1624 __queue_delayed_work+0x71/0x90 [ 82.438436] Modules linked in: [ 82.438911] CPU: 3 PID: 602 Comm: systemd-udevd Not tainted 5.6.0-rc6+ #339 [ 82.439680] RIP: 0010:__queue_delayed_work+0x71/0x90 [ 82.440287] Code: c1 48 89 4a 50 81 ff 00 02 00 00 75 2a 4c 89 cf e9 94 d6 07 00 e9 7f e9 ff ff 0f 0b eb c7 0f 0b 48 81 7a 58 40 74 a8 94 74 a7 <0f> 0b 48 83 7a 48 00 74 a5 0f 0b eb a1 89 fe 4c 89 cf e9 c8 c4 07 [ 82.441719] RSP: 0018:ffffb738803977c0 EFLAGS: 00010007 [ 82.442121] RAX: ffffa086389f9740 RBX: 0000000000000002 RCX: 0000000000000000 [ 82.442718] RDX: ffffa086350dd930 RSI: ffffa0863d76f600 RDI: 0000000000000200 [ 82.443484] RBP: 0000000000000200 R08: 0000000000000000 R09: ffffa086350dd970 [ 82.444128] R10: 0000000000000000 R11: 0000000000000000 R12: ffffa086350dd930 [ 82.444773] R13: ffffa0863d76f600 R14: 0000000000000000 R15: ffffa08636738008 [ 82.445427] FS: 00007f6abfe9dd40(0000) GS:ffffa0863dd80000(0000) knlGS:00000 [ 82.446040] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 [ 82.446478] CR2: 0000557d288db4e8 CR3: 0000000078b36000 CR4: 00000000000006e0 [ 82.447104] DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000 [ 82.447561] DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400 [ 82.448012] Call Trace: [ 82.448164] queue_delayed_work_on+0x6d/0x80 [ 82.448472] __pg_init_all_paths+0x7b/0xf0 [ 82.448714] pg_init_all_paths+0x26/0x40 [ 82.448980] __multipath_map_bio.isra.0+0x84/0x210 [ 82.449267] __map_bio+0x3c/0x1f0 [ 82.449468] __split_and_process_non_flush+0x14a/0x1b0 [ 82.449775] __split_and_process_bio+0xde/0x340 [ 82.450045] ? dm_get_live_table+0x5/0xb0 [ 82.450278] dm_process_bio+0x98/0x290 [ 82.450518] dm_make_request+0x54/0x120 [ 82.450778] generic_make_request+0xd2/0x3e0 [ 82.451038] ? submit_bio+0x3c/0x150 [ 82.451278] submit_bio+0x3c/0x150 [ 82.451492] mpage_readpages+0x129/0x160 [ 82.451756] ? bdev_evict_inode+0x1d0/0x1d0 [ 82.452033] read_pages+0x72/0x170 [ 82.452260] __do_page_cache_readahead+0x1ba/0x1d0 [ 82.452624] force_page_cache_readahead+0x96/0x110 [ 82.452903] generic_file_read_iter+0x84f/0xae0 [ 82.453192] ? __seccomp_filter+0x7c/0x670 [ 82.453547] new_sync_read+0x10e/0x190 [ 82.453883] vfs_read+0x9d/0x150 [ 82.454172] ksys_read+0x65/0xe0 [ 82.454466] do_syscall_64+0x4e/0x210 [ 82.454828] entry_SYSCALL_64_after_hwframe+0x49/0xbe [...] [ 82.462501] ---[ end trace bb39975e9cf45daa ]--- Cc: stable@vger.kernel.org Signed-off-by: Gabriel Krisman Bertazi <krisman@collabora.com> Signed-off-by: Mike Snitzer <snitzer@redhat.com>		2020-04-28 19:51:46 -04:00
..
accessibility	…
acpi	ACPI fixes for 5.6-rc4	2020-02-28 09:02:18 -08:00
amba	…
android	binder: prevent UAF for binderfs devices II	2020-03-03 19:58:37 +01:00
ata	libata-5.6-2020-02-05	2020-02-06 06:11:50 +00:00
atm	atm: nicstar: fix if-statement empty body warning	2020-02-29 21:28:30 -08:00
auxdisplay	auxdisplay: charlcd: replace zero-length array with flexible-array member	2020-03-06 22:18:07 +01:00
base	driver code: clarify and fix platform device DMA mask allocation	2020-03-11 09:30:27 -07:00
bcma	Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next	2020-01-28 16:02:33 -08:00
block	virtio: fixes	2020-03-09 16:02:32 -07:00
bluetooth	Bluetooth: btrtl: Use kvmalloc for FW allocations	2020-01-24 19:57:53 +01:00
bus	Few fixes for omaps for v5.6-rc cycle	2020-02-29 11:47:44 -08:00
cdrom	scsi: compat_ioctl: cdrom: Replace .ioctl with .compat_ioctl in four appropriate places	2020-02-24 15:06:07 -05:00
char	ipmi_si: Avoid spurious errors for optional IRQs	2020-03-11 21:15:19 -05:00
clk	clk: qcom: dispcc: Remove support of disp_cc_mdss_rscc_ahb_clk	2020-02-12 15:03:08 -08:00
clocksource	ARM: SoC: late updates	2020-02-08 14:17:27 -08:00
connector	…
counter	…
cpufreq	cpufreq: Fix policy initialization for internal governor drivers	2020-02-27 08:57:48 +01:00
cpuidle	ARM: SoC-related driver updates	2020-02-08 14:04:19 -08:00
crypto	Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next	2020-01-28 16:02:33 -08:00
dax	dax: Get rid of fs_dax_get_by_host() helper	2020-01-16 09:52:27 -08:00
dca	…
devfreq	Revert "PM / devfreq: Modify the device name as devfreq(X) for sysfs"	2020-02-24 11:14:29 +09:00
dio	…
dma	dmaengine: imx-sdma: Fix the event id check to include RX event for UART6	2020-02-25 14:15:26 +05:30
dma-buf	dma-buf: free dmabuf->name in dma_buf_release()	2020-02-27 18:01:58 +05:30
edac	EDAC/synopsys: Do not print an error with back-to-back snprintf() calls	2020-02-27 16:44:25 +01:00
eisa	…
extcon	…
firewire	…
firmware	Two EFI fixes:	2020-03-15 12:42:03 -07:00
fpga	fpga: xilinx-pr-decoupler: Remove clk_get error message for probe defer	2020-01-10 12:51:56 -08:00
fsi	fsi: aspeed: add unspecified HAS_IOMEM dependency	2020-02-10 13:45:49 -08:00
gnss	…
gpio	gpio: sifive: fix static checker warning	2020-02-10 13:54:17 +01:00
gpu	Merge tag 'topic/mst-bw-check-fixes-for-airlied-2020-03-12-2' of git://anongit.freedesktop.org/drm/drm-misc into drm-fixes	2020-03-13 10:38:25 +10:00
greybus	…
hid	HID: hyperv: NULL check before some freeing functions is not needed.	2020-03-05 14:17:11 +00:00
hsi	…
hv	- Most of the commits here are work to enable host-initiated hibernation	2020-02-03 14:42:03 +00:00
hwmon	hwmon: (adt7462) Fix an error return in ADT7462_REG_VOLT()	2020-03-03 12:42:55 -08:00
hwspinlock	hwspinlock: sirf: Use devm_hwspin_lock_register() to register hwlock controller	2020-01-21 16:16:36 -08:00
hwtracing	coresight: etm4x: Fix unused function warning	2020-01-14 15:38:28 +01:00
i2c	i2c: acpi: put device when verifying client fails	2020-03-13 15:15:30 +01:00
i3c	i3c: master: dw: reattach device on first available location of address table	2020-01-13 10:00:05 +01:00
ide	scsi: compat_ioctl: cdrom: Replace .ioctl with .compat_ioctl in four appropriate places	2020-02-24 15:06:07 -05:00
idle	intel_idle: Introduce 'states_off' module parameter	2020-02-03 11:57:18 +01:00
iio	chrome platform changes for 5.6	2020-02-04 07:17:41 +00:00
infiniband	Second RDMA 5.6 pull request	2020-03-07 19:52:55 -06:00
input	Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/dtor/input	2020-02-15 16:49:25 -08:00
interconnect	interconnect: Handle memory allocation errors	2020-03-03 08:02:57 +01:00
iommu	iommu/vt-d: Populate debugfs if IOMMUs are detected	2020-03-14 20:02:43 +01:00
ipack	…
irqchip	irqchip fixes for 5.6, take #2	2020-03-15 10:53:11 +01:00
isdn	proc: convert everything to "struct proc_ops"	2020-02-04 03:05:26 +00:00
leds	leds: lm3532: add pointer to documentation and fix typo	2020-01-22 21:08:24 +01:00
lightnvm	…
macintosh	macintosh: windfarm: fix MODINFO regression	2020-03-10 12:30:59 +01:00
mailbox	…
mcb	…
md	dm multipath: use updated MPATHF_QUEUE_IO on mapping for bio-based mpath	2020-04-28 19:51:46 -04:00
media	media: mc-entity.c: use & to check pad flags, not ==	2020-02-24 15:10:04 +01:00
memory	mvebu drivers for 5.6 (part 1)	2020-01-16 10:45:44 -08:00
memstick	…
message	Merge ra.kernel.org:/pub/scm/linux/kernel/git/netdev/net	2020-01-19 22:10:04 +01:00
mfd	chrome platform changes for 5.6	2020-02-04 07:17:41 +00:00
misc	misc: eeprom: at24: fix regulator underflow	2020-03-12 09:02:34 +01:00
mmc	mmc: core: Respect MMC_CAP_NEED_RSP_BUSY for eMMC sleep command	2020-03-12 13:36:55 +01:00
mtd	treewide: remove redundant IS_ERR() before error code check	2020-02-04 03:05:27 +00:00
mux	…
net	net: systemport: fix index check to avoid an array out of bounds access	2020-03-12 15:50:18 -07:00
nfc	nfc: pn544: Fix occasional HW initialization failure	2020-02-19 11:09:27 -08:00
ntb	…
nubus	…
nvdimm	mm: Cleanup __put_devmap_managed_page() vs ->page_free()	2020-01-31 10:30:37 -08:00
nvme	nvme-pci: Hold cq_poll_lock while completing CQEs	2020-02-28 01:32:14 +09:00
nvmem	Merge branch 'i2c/for-5.6' of git://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux	2020-02-07 12:54:13 -08:00
of	drivers/of/of_mdio.c:fix of_mdiobus_register()	2020-03-03 19:01:51 -08:00
opp	ioremap changes for 5.6	2020-01-27 13:03:00 -08:00
oprofile	tracing: Make struct ring_buffer less ambiguous	2020-01-13 13:19:38 -05:00
parisc	proc: convert everything to "struct proc_ops"	2020-02-04 03:05:26 +00:00
parport	…
pci	PCI: brcmstb: Fix build on 32bit ARM platforms with older compilers	2020-02-27 08:06:20 -06:00
pcmcia	…
perf	drivers/perf: arm_pmu_acpi: Fix incorrect checking of gicc pointer	2020-03-02 12:07:35 +00:00
phy	phy: for 5.6-rc	2020-03-04 13:28:52 +01:00
pinctrl	pinctrl: qcom: Assign irq_eoi conditionally	2020-03-09 16:31:34 +01:00
platform	platform/chrome: wilco_ec: Include asm/unaligned instead of linux/ path	2020-02-11 09:10:36 +01:00
pnp	proc: convert everything to "struct proc_ops"	2020-02-04 03:05:26 +00:00
power	ARM: SoC platform updates	2020-02-08 13:55:25 -08:00
powercap	Merge back power capping changes for v5.6.	2020-01-13 10:32:19 +01:00
pps	…
ps3	…
ptp	Merge ra.kernel.org:/pub/scm/linux/kernel/git/netdev/net	2020-01-19 22:10:04 +01:00
pwm	pwm: Remove set but not set variable 'pwm'	2020-01-20 15:40:49 +01:00
rapidio	…
ras	…
regulator	regulator: Fixes for v5.6	2020-03-06 14:48:30 -06:00
remoteproc	remoteproc: qcom: q6v5-mss: Improve readability of reset_assert	2020-01-24 09:34:07 -08:00
reset	reset: intel: add unspecified HAS_IOMEM dependency	2020-02-10 11:11:55 +01:00
rpmsg	rpmsg: add rpmsg support for mt8183 SCP.	2020-01-20 10:29:56 -08:00
rtc	chrome platform changes for 5.6	2020-02-04 07:17:41 +00:00
s390	block-5.6-2020-03-13	2020-03-13 12:45:23 -07:00
sbus	…
scsi	scsi: ipr: Fix softlockup when rescanning devices in petitboot	2020-03-10 22:34:24 -04:00
sfi	…
sh	…
siox	siox: Use the correct style for SPDX License Identifier	2020-01-14 21:46:53 +01:00
slimbus	slimbus: qcom: add missed clk_disable_unprepare in remove	2020-01-14 21:46:48 +01:00
soc	i.MX fixes for 5.6:	2020-02-24 09:57:05 -08:00
soundwire	soundwire: cadence: fix kernel-doc parameter descriptions	2020-01-16 17:34:38 +05:30
spi	spi: Fixes for v5.6	2020-03-06 14:50:16 -06:00
spmi	spmi: pmic-arb: Set lockdep class for hierarchical irq domains	2020-02-10 13:16:04 +01:00
ssb	…
staging	TTY/Serial fixes for 5.6-rc5	2020-03-08 10:35:04 -05:00
target	scsi: Revert "target: iscsi: Wait for all commands to finish before freeing a session"	2020-02-14 17:13:54 -05:00
tc	The main MIPS changes for 5.6:	2020-01-31 11:28:31 -08:00
tee	arm64: dts: agilex: fix gmac compatible	2020-03-03 16:40:56 -08:00
thermal	- Fix a SEVERE docs build failure for cpu idle cooling device (Randy Dunlap)	2020-01-31 14:39:21 -08:00
thunderbolt	thunderbolt: Prevent crash if non-active NVMem file is read	2020-02-13 04:59:30 -08:00
tty	tty: serial: fsl_lpuart: free IDs allocated by IDA	2020-03-06 14:10:44 +01:00
uio	uio: uio_pdrv_genirq: Do not log an error when deferring probe routine.	2020-01-14 15:27:51 +01:00
usb	usb: dwc3: gadget: Update chain bit correctly when using sg list	2020-03-04 10:58:16 +01:00
vfio	VFIO updates for v5.6-rc1	2020-02-03 22:22:05 +00:00
vhost	vhost: Check docket sk_family instead of call getname	2020-02-22 21:41:42 -08:00
video	ARM: SoC fixes	2020-03-08 17:36:22 -07:00
virt	…
virtio	virtio_balloon: Adjust label in virtballoon_probe	2020-03-08 05:35:24 -04:00
visorbus	visorbus: fix uninitialized variable access	2020-01-14 15:30:35 +01:00
vlynq	…
vme	Char/Misc driver changes for 5.6-rc1	2020-01-29 10:35:54 -08:00
w1	Char/Misc driver changes for 5.6-rc1	2020-01-29 10:35:54 -08:00
watchdog	watchdog: iTCO_wdt: Make ICH_RES_IO_SMI optional	2020-03-10 10:20:37 +01:00
xen	xen/xenbus: fix locking	2020-03-05 09:42:23 -06:00
zorro	Kbuild updates for v5.6 (2nd)	2020-02-09 16:05:50 -08:00
Kconfig	…
Makefile	…