linux-sg2042/drivers/pinctrl/sirf
Linus Walleij 4e6fd26dcf pinctrl: sirf/atlas7: stop poking around in GPIO internals
This code is poking around in the gpio_chip:s internal structures
to achieve some kind of pin to GPIO mappings.

- It is wrong to poke around in these structs and the pinctrl
  maintainer was stupid to let it pass unnoticed, mea culpa.

- The right interface to use is gpiochip_add_pin_range()

- The code appears unused: the pin control part of the driver
  is not adding any ranges, so we're iterating over an empty
  list. Maybe it is poking around in some other pin controllers
  GPIO ranges, and that's just totally wrong, again use
  gpiochip_add_pin_range() and specify the right pin
  controller.

Cc: Barry Song <baohua@kernel.org>
Cc: Guoying Zhang <Guoying.Zhang@csr.com>
Cc: Wei Chen <Wei.Chen@csr.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
2016-02-16 00:19:54 +01:00
..
Makefile pinctrl: sirf: add sirf atlas7 pinctrl and gpio support 2015-05-19 16:01:30 +02:00
pinctrl-atlas6.c pinctrl: atlas6: Add I2S external clock input pingroup 2014-08-29 08:42:13 +02:00
pinctrl-atlas7.c pinctrl: sirf/atlas7: stop poking around in GPIO internals 2016-02-16 00:19:54 +01:00
pinctrl-prima2.c pinctrl: prima2: add I2S 2ch, 6ch, nodin, mclk groups 2014-09-04 19:07:19 +02:00
pinctrl-sirf.c GPIO bulk updates for the v4.5 kernel cycle: 2016-01-17 12:32:01 -08:00
pinctrl-sirf.h pinctrl: sirf: drop marco support 2015-01-14 14:21:54 +01:00