David Dueck 1ab36387ea pinctrl: at91: fix null pointer dereference ... Not all gpio banks are necessarily enabled, in the current code this can lead to null pointer dereferences. [ 51.130000] Unable to handle kernel NULL pointer dereference at virtual address 00000058 [ 51.130000] pgd = dee04000 [ 51.130000] [00000058] *pgd=3f66d831, *pte=00000000, *ppte=00000000 [ 51.140000] Internal error: Oops: 17 [#1] ARM [ 51.140000] Modules linked in: [ 51.140000] CPU: 0 PID: 1664 Comm: cat Not tainted 4.1.1+ #6 [ 51.140000] Hardware name: Atmel SAMA5 [ 51.140000] task: df6dd880 ti: dec60000 task.ti: dec60000 [ 51.140000] PC is at at91_pinconf_get+0xb4/0x200 [ 51.140000] LR is at at91_pinconf_get+0xb4/0x200 [ 51.140000] pc : [<c01e71a0>] lr : [<c01e71a0>] psr: 600f0013 sp : dec61e48 ip : 600f0013 fp : df522538 [ 51.140000] r10: df52250c r9 : 00000058 r8 : 00000068 [ 51.140000] r7 : 00000000 r6 : df53c910 r5 : 00000000 r4 : dec61e7c [ 51.140000] r3 : 00000000 r2 : c06746d4 r1 : 00000000 r0 : 00000003 [ 51.140000] Flags: nZCv IRQs on FIQs on Mode SVC_32 ISA ARM Segment user [ 51.140000] Control: 10c53c7d Table: 3ee04059 DAC: 00000015 [ 51.140000] Process cat (pid: 1664, stack limit = 0xdec60208) [ 51.140000] Stack: (0xdec61e48 to 0xdec62000) [ 51.140000] 1e40: 00000358 00000000 df522500 ded15f80 c05a9d08 ded15f80 [ 51.140000] 1e60: 0000048c 00000061 df522500 ded15f80 c05a9d08 c01e7304 ded15f80 00000000 [ 51.140000] 1e80: c01e6008 00000060 0000048c c01e6034 c01e5f6c ded15f80 dec61ec0 00000000 [ 51.140000] 1ea0: 00020000 ded6f280 dec61f80 00000001 00000001 c00ae0b8 b6e80000 ded15fb0 [ 51.140000] 1ec0: 00000000 00000000 df4bc974 00000055 00000800 ded6f280 b6e80000 ded6f280 [ 51.140000] 1ee0: ded6f280 00020000 b6e80000 00000000 00020000 c0090dec c0671e1c dec61fb0 [ 51.140000] 1f00: b6f8b510 00000001 00004201 c000924c 00000000 00000003 00000003 00000000 [ 51.140000] 1f20: df4bc940 00022000 00000022 c066e188 b6e7f000 c00836f4 000b6e7f ded6f280 [ 51.140000] 1f40: ded6f280 b6e80000 dec61f80 ded6f280 00020000 c0091508 00000000 00000003 [ 51.140000] 1f60: 00022000 00000000 00000000 ded6f280 ded6f280 00020000 b6e80000 c0091d9c [ 51.140000] 1f80: 00000000 00000000 ffffffff 00020000 00020000 b6e80000 00000003 c000f124 [ 51.140000] 1fa0: dec60000 c000efa0 00020000 00020000 00000003 b6e80000 00020000 000271c4 [ 51.140000] 1fc0: 00020000 00020000 b6e80000 00000003 7fffe000 00000000 00000000 00020000 [ 51.140000] 1fe0: 00000000 bef50b64 00013835 b6f29c76 400f0030 00000003 00000000 00000000 [ 51.140000] [<c01e71a0>] (at91_pinconf_get) from [<c01e7304>] (at91_pinconf_dbg_show+0x18/0x2c0) [ 51.140000] [<c01e7304>] (at91_pinconf_dbg_show) from [<c01e6034>] (pinconf_pins_show+0xc8/0xf8) [ 51.140000] [<c01e6034>] (pinconf_pins_show) from [<c00ae0b8>] (seq_read+0x1a0/0x464) [ 51.140000] [<c00ae0b8>] (seq_read) from [<c0090dec>] (__vfs_read+0x20/0xd0) [ 51.140000] [<c0090dec>] (__vfs_read) from [<c0091508>] (vfs_read+0x7c/0x108) [ 51.140000] [<c0091508>] (vfs_read) from [<c0091d9c>] (SyS_read+0x40/0x94) [ 51.140000] [<c0091d9c>] (SyS_read) from [<c000efa0>] (ret_fast_syscall+0x0/0x3c) [ 51.140000] Code: eb010ec2 e30a0d08 e34c005a eb0ae5a7 (e5993000) [ 51.150000] ---[ end trace fb3c370da3ea4794 ]--- Fixes: a0b957f306 ("pinctrl: at91: allow to have disabled gpio bank") Cc: stable@vger.kernel.org # 3.18 Signed-off-by: David Dueck <davidcdueck@googlemail.com> Acked-by: Ludovic Desroches <ludovic.desroches@atmel.com> Acked-by: Alexandre Belloni <alexandre.belloni@free-electrons.com> Acked-by: Nicolas Ferre <nicolas.ferre@atmel.com> Cc: Boris Brezillon <boris.brezillon@free-electrons.com> Cc: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com> Cc: linux-arm-kernel@lists.infradead.org Cc: linux-kernel@vger.kernel.org Signed-off-by: Linus Walleij <linus.walleij@linaro.org>		2015-08-30 21:58:53 +02:00
..
accessibility	…
acpi	Merge branch 'libnvdimm-fixes' of git://git.kernel.org/pub/scm/linux/kernel/git/djbw/nvdimm	2015-07-11 20:44:31 -07:00
amba	…
android	…
ata	ata: ahci_platform: Add ACPI _CLS matching	2015-07-07 01:55:21 +02:00
atm	…
auxdisplay	…
base	Fix firmware loader uevent buffer NULL pointer dereference	2015-07-09 11:20:01 -07:00
bcma	…
block	Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs	2015-07-04 19:36:06 -07:00
bluetooth	Bluetooth: ath3k: Add support of 04ca:300d AR3012 device	2015-06-18 21:00:06 +03:00
bus	ARM: SoC: driver updates for v4.2	2015-06-26 11:54:29 -07:00
cdrom	…
char	Merge tag 'drm-intel-next-fixes-2015-07-02' of git://anongit.freedesktop.org/drm-intel	2015-07-02 14:36:40 -07:00
clk	clk: rockchip: add pclk_pd_pmu to the list of rk3288 critical clocks	2015-08-13 16:09:42 +02:00
clocksource	clocksource/imx: Define clocksource for mx27	2015-07-07 10:44:45 +02:00
connector	…
cpufreq	MIPS, CPUFREQ: Fix spelling of Institute.	2015-07-07 20:59:42 +02:00
cpuidle	Replace module_platform_driver with builtin_platform driver in non modules.	2015-07-02 10:42:13 -07:00
crypto	crypto: marvell/cesa - another fix up for of_get_named_gen_pool() rename	2015-07-03 11:37:02 -07:00
dca	…
devfreq	…
dio	…
dma	Merge branch 'akpm' (patches from Andrew)	2015-07-01 17:47:51 -07:00
dma-buf	…
edac	A build fix for octeon_edac from Aaro Koskinen.	2015-07-03 12:10:12 -07:00
eisa	…
extcon	…
firewire	…
firmware	Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/ebiederm/user-namespace	2015-07-03 15:20:57 -07:00
fmc	…
gpio	Merge branch 'irq-urgent-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip	2015-07-01 15:19:35 -07:00
gpu	Revert "drm/i915: Use crtc_state->active in primary check_plane func"	2015-07-12 15:00:20 -07:00
hid	Merge branches 'for-4.2/i2c-hid', 'for-4.2/lenovo', 'for-4.2/plantronics', 'for-4.2/rmi', 'for-4.2/sensor-hub', 'for-4.2/sjoy', 'for-4.2/sony' and 'for-4.2/wacom' into for-linus	2015-06-22 16:23:43 +02:00
hsi	Fix up implicit <module.h> users that will break later.	2015-07-02 10:25:22 -07:00
hv	…
hwmon	hwmon: (w83627ehf) Use swap() in w82627ehf_swap_tempreg()	2015-07-03 14:39:06 +02:00
hwspinlock	hwspinlock: qcom: Correct msb in regmap_field	2015-07-01 16:15:05 +03:00
hwtracing/coresight	…
i2c	i2c: Mark instantiated device nodes with OF_POPULATE	2015-07-09 22:25:54 +02:00
ide	Minor merge needed, due to function move.	2015-07-01 10:49:25 -07:00
idle	…
iio	…
infiniband	Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs	2015-07-04 19:36:06 -07:00
input	Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/dtor/input	2015-07-11 11:16:04 -07:00
iommu	IOMMU Fixes for Linux v4.2-rc0	2015-07-01 14:44:22 -07:00
ipack	…
irqchip	Merge branch 'upstream' of git://git.linux-mips.org/pub/scm/ralf/upstream-linus	2015-07-12 13:55:24 -07:00
isdn	Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next	2015-06-24 16:49:49 -07:00
leds	Merge branch 'for-next' of git://git.kernel.org/pub/scm/linux/kernel/git/cooloney/linux-leds	2015-07-01 19:09:11 -07:00
lguest	Merge branch 'x86-core-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip	2015-06-22 17:59:09 -07:00
macintosh	macintosh/nvram: Remove as unused	2015-06-15 16:42:37 +10:00
mailbox	Replace module_init with appropriate alternate initcall in non modules.	2015-07-02 10:36:29 -07:00
mcb	…
md	Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs	2015-07-04 19:36:06 -07:00
media	Merge branch 'for-next' of git://git.kernel.org/pub/scm/linux/kernel/git/cooloney/linux-leds	2015-07-01 19:09:11 -07:00
memory	Merge branch 'fixes-rc1' into omap-for-v4.2/fixes	2015-07-06 05:33:17 -07:00
memstick	memstick: remove deprecated use of pci api	2015-06-30 19:44:57 -07:00
message	fusion: remove dead MTRR code	2015-06-13 08:44:14 -07:00
mfd	Merge branch 'irq-urgent-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip	2015-07-01 15:19:35 -07:00
misc	powerpc fixes for 4.2	2015-07-10 12:16:59 -07:00
mmc	ARM: SoC: late fixes and dependencies	2015-07-02 14:40:49 -07:00
mtd	Minor merge needed, due to function move.	2015-07-01 10:49:25 -07:00
net	A very significant modification to NTB in this series.	2015-07-04 14:07:47 -07:00
nfc	Char/Misc driver patches for 4.2-rc1	2015-06-26 14:51:15 -07:00
ntb	NTB: Add split BAR output for debugfs stats	2015-07-04 14:09:32 -04:00
nubus	…
nvdimm	nvdimm: Fix return value of nvdimm_bus_init() if class_create() fails	2015-06-30 14:30:34 -04:00
of	Devicetree changes for v4.2	2015-07-01 19:40:18 -07:00
oprofile	…
parisc	…
parport	…
pci	Merge branch 'irq-urgent-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip	2015-07-01 15:19:35 -07:00
pcmcia	Fix up implicit <module.h> users that will break later.	2015-07-02 10:25:22 -07:00
phy	Merge branch 'upstream' of git://git.linux-mips.org/pub/scm/ralf/upstream-linus	2015-06-27 12:44:34 -07:00
pinctrl	pinctrl: at91: fix null pointer dereference	2015-08-30 21:58:53 +02:00
platform	platform-drivers-x86 for 4.2-2	2015-07-05 10:54:09 -07:00
pnp	ACPI / PNP: Reserve ACPI resources at the fs_initcall_sync stage	2015-07-06 23:52:21 +02:00
power	Replace module_platform_driver with builtin_platform driver in non modules.	2015-07-02 10:42:13 -07:00
powercap	…
pps	…
ps3	…
ptp	…
pwm	pwm: Changes for v4.2-rc1	2015-06-23 13:32:38 -07:00
rapidio	Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/jikos/trivial	2015-06-23 14:08:54 -07:00
ras	…
regulator	Fix up implicit <module.h> users that will break later.	2015-07-02 10:25:22 -07:00
remoteproc	remoteproc: fix !CONFIG_OF build breakage	2015-06-18 11:44:41 +03:00
reset	…
rpmsg	…
rtc	Merge branch 'upstream' of git://git.linux-mips.org/pub/scm/ralf/upstream-linus	2015-06-27 12:44:34 -07:00
s390	KVM: s390: virtio-ccw: don't overwrite config space values	2015-07-03 18:55:18 +02:00
sbus	…
scsi	Merge branch 'for-next' of git://git.kernel.org/pub/scm/linux/kernel/git/nab/target-pending	2015-07-04 14:13:43 -07:00
sfi	…
sh	Merge branch 'irq-urgent-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip	2015-07-01 15:19:35 -07:00
sn	…
soc	ARM: SoC: late fixes and dependencies	2015-07-02 14:40:49 -07:00
spi	Merge remote-tracking branches 'spi/topic/sirf', 'spi/topic/spidev' and 'spi/topic/zynq' into spi-next	2015-06-18 00:19:56 +01:00
spmi	…
ssb	…
staging	Staging driver patches for 4.2-rc1	2015-06-26 15:46:08 -07:00
target	Merge branch 'for-next' of git://git.kernel.org/pub/scm/linux/kernel/git/nab/target-pending	2015-07-04 14:13:43 -07:00
tc	…
thermal	Minor merge needed, due to function move.	2015-07-01 10:49:25 -07:00
thunderbolt	…
tty	ARM: SoC: late fixes and dependencies	2015-07-02 14:40:49 -07:00
uio	…
usb	Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs	2015-07-04 19:36:06 -07:00
uwb	…
vfio	VFIO updates for v4.2	2015-06-28 12:32:13 -07:00
vhost	Merge branch 'for-next' of git://git.kernel.org/pub/scm/linux/kernel/git/nab/target-pending	2015-07-04 14:13:43 -07:00
video	stifb: Implement hardware accelerated copyarea	2015-07-10 21:44:19 +02:00
virt	…
virtio	virtio/vhost: cross endian support	2015-07-03 16:02:25 -07:00
vlynq	…
vme	vme: tsi148: depend on HAS_DMA for Kconfig	2015-06-12 17:31:05 -07:00
w1	…
watchdog	Merge git://www.linux-watchdog.org/linux-watchdog	2015-07-01 19:33:16 -07:00
xen	Merge branch 'for-next' of git://git.kernel.org/pub/scm/linux/kernel/git/nab/target-pending	2015-07-04 14:13:43 -07:00
zorro	…
Kconfig	libnvdimm, nfit: initial libnvdimm infrastructure and NFIT support	2015-06-24 21:24:10 -04:00
Makefile	pinctrl: move CONFIG_PINCTRL to drivers/Makefile	2015-07-16 09:40:09 +02:00