Commit Graph

443516 Commits

Author SHA1 Message Date
Jes Sorensen cade4108a8 staging: rtl8723au: rtl8723a_cmd.c: Get rid of SetToDs()/SetFrDs() usage
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-23 16:27:49 +09:00
Jes Sorensen c26e95737b staging: rtl8723au: rtw_xmit.c: Get rid of SetToDs()/SetFrDs() usage
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-23 16:27:49 +09:00
Jes Sorensen 863b314f84 staging: rtl8723au: rtw_mlme_ext.c: Get rid of SetToDs()/SetFrDs() usage
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-23 16:27:49 +09:00
Jes Sorensen d181ee3726 staging: rtl8723au: Get rid of duplicate ieee80211 frame_control defines
This is all defined nicely in ieee80211.h, this was all duplication
serving no other purpose than to obfuscate the code.

Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-23 16:27:49 +09:00
Jes Sorensen 6ebd294804 staging: rtl8723au: Fix issue_assocrsp() to use IEEE80211_STYPE_* defines
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-23 16:27:49 +09:00
Jes Sorensen 5986a3f23a staging: rtl8723au: Declare issue_asocrsp() static
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-23 16:27:48 +09:00
Jes Sorensen c2bfb149b4 staging: rtl8723au: rtw_mlme_ext.c: Get rid of most WIFI_* frame type usage
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-23 16:27:48 +09:00
Jes Sorensen 036cdd9cb3 staging: rtl8723au: ioctl_cfg80211.c: Use ieee80211.h provided fctl bits
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-23 16:27:48 +09:00
Jes Sorensen 6023377b47 staging: rtl8723au: rtl8723a_cmd.c: Use ieee80211.h provided fctl bits
v2: Fix endian bug reported by Dan Carpenter <dan.carpenter@oracle.com>

Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-23 16:27:48 +09:00
Jes Sorensen b2f72caefe staging: rtl8723au: rtw_xmit.c: Use IEEE80211_[FS]TYPE_ defines
In addition pkt_attrib->type a u16 and get rid of pattrib->stype

Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-23 16:27:48 +09:00
Jes Sorensen 0d280584c0 staging: rtl8723au: Remove unused SetFrameType() macro
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-23 16:27:47 +09:00
Jes Sorensen cd70034159 staging: rtl8723au: Get rid of obsolete SetPriority()/SetEOSP()/SetAckpolicy()
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-23 16:27:47 +09:00
Jes Sorensen 24af77b4af staging: rtl8723au: _issue_qos_nulldata23a(): Use struct ieee80211_qos_hdr
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-23 16:27:47 +09:00
Jes Sorensen e5b2a429f0 staging: rl8723au: rtw_make_wlanhdr(): Use ieee80211_qos_hdr
Use the kernel provided struct and defines to fill in qos_ctrl

Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-23 16:27:47 +09:00
Jes Sorensen ec3f4e2ae1 staging: rtl8723au: rtl8723a_cmd.c: Use ieee80211.h defines to set qos_ctrl
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-23 16:27:47 +09:00
Jes Sorensen 316f6211b4 staging: rtl8723au: rtl8723a_update_ramask(): Get rid of annoying debug message
There really is no need to print this message for anyone not trying to
debug the driver:

  rtl8723a_update_ramask => mac_id:0, networkType:0x0b, mask:0x000fffff

Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-23 16:27:47 +09:00
Jes Sorensen c6716e1f84 staging: rtl8723au: Get rid of SetPrivacy()/SetPwrMgt()/SetMData() macros
Set these bits directly in the code instead of fiddling with wrapper
macros.

Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-23 16:27:46 +09:00
Jes Sorensen fd602993ba staging: rtl8723au: Get rid of ugly SetDuration() macro usage
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-23 16:27:46 +09:00
Jes Sorensen 2bdbf939e0 staging: rtl8723au: wifi.h: Remove unused SetFragNum() macro
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-23 16:27:46 +09:00
Jes Sorensen aeda82507d staging: rtl8723au: Get rid of SetSeqNum()
In every last use case, the header was just cleared with memset() so
there is no need to use the complex SetSeqNum() macro when
cpu_to_le16(IEEE80211_SN_TO_SEQ()) output will do just fine.

In addition, get rid of __le16 *fctrl usage when there is no need for
it.

Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-23 16:27:46 +09:00
Jes Sorensen 39ef89153c staging: rtl8723au: Declare rtw_make_wlanhdr() static
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-23 16:27:46 +09:00
Jes Sorensen 670ce6889c staging: rtl8723au: rtw_make_wlanhdr23a(): Use IEEE80211_SN_TO_SEQ() to set seq_ctrl
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-23 16:27:46 +09:00
Jes Sorensen 0b218f4c6b staging: rtl8723au: rtl8723a_cmd.c: Properly initialize seq_ctrl
Control frames will not be fragmented, so we should fully initialize
the seq_ctrl field to zero. This avoids leftover stack bits remaining
set in the generated frame's seq_ctrl field.

Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-23 16:27:45 +09:00
Jes Sorensen 1daffaeecb staging: rtl8723au: ioctl_cfg80211.c: Properly initialize seq_ctrl
Using SetSeqNum() on an uninitialized stack frame leaves us open to
leaving random fragment bits set in seq_ctrl in the frame header.

Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-23 16:27:45 +09:00
Jes Sorensen 9a7e35f1ea staging: rtl8723au: rtw_cfg80211_inform_bss(): Use get_unaligned_le16()
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-23 16:27:45 +09:00
Jes Sorensen 14423cd702 staging: rtl8723au: ioctl_cfg80211.c: Rip out < 3.14 kernel support
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-23 16:27:45 +09:00
Jes Sorensen aa69fa6571 staging: rtl8723au: cfg80211_rtw_mgmt_tx(): type is always -1
Rip out P2P defines since they are effectively never used.

Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-23 16:27:45 +09:00
Jes Sorensen c38992872d staging: rtl8723au: Get rid of last HT OP mode duplicate defines
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-23 16:27:45 +09:00
Jes Sorensen 95a4c8c25f staging: rtl8723au: wifi.h: Remove a pile of unused WDS_ defines
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-23 16:27:44 +09:00
Jes Sorensen 15b4ff5d8b staging: rtl8723au: Remove unused enum WIFI_REG_DOMAIN
Must be the 17th duplicate of this list in the kernel

Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-23 16:27:44 +09:00
Jes Sorensen 7e14ed5f8f staging: rtl8723au: Use kernel provided IEEE80211_HT_PARAM_* defines
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-23 16:27:44 +09:00
Jes Sorensen 2c50c7cbf0 staging: rtl8723au: Use kernel provided IEEE80211_HT_OP_MODE_* defines
In addition remove unused HT_INFO_STBC_PARAM_* defines

Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-23 16:27:44 +09:00
Jes Sorensen e1c04628f7 staging: rtl8723au: Use kernel provided WLAN_CAPABILITY_* definitions
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-23 16:27:44 +09:00
Jes Sorensen e80c2859b1 staging: rtl8723au: wifi.h: Remove unused SetRetry() + SetAMsdu() macros
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-23 16:27:44 +09:00
Jes Sorensen 8e3ddadf74 staging: rtl8723au: Get rid of ClearMFrag/SetMFrag
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-23 16:27:43 +09:00
Jes Sorensen 5acab75263 staging: rtl8723au: wlan_bssdef.h: Remove some more unused #defines
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-23 16:27:43 +09:00
Jes Sorensen b171da3c6e staging: rtl8723au: Get rid of struct ndis_802_11_var_ies
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-23 16:27:43 +09:00
Jes Sorensen c164bcff68 staging: rtli8723au: Get rid of struct ndis_802_11_fixed_ies
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-23 16:27:43 +09:00
Jes Sorensen 37cb982c26 staging: rtl8723au: Get rid of struct ndis_802_11_config
This exposed a nice endian bug in collect_bss_info23a() where two
bytes in little-endian order were copied into a u32 and afterwards
le32_to_cpu() was applied to it....

Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-23 16:27:43 +09:00
Jes Sorensen 9a3c056873 staging: rtl8723au: Get rid of unused struct ndis_802_11_configuration_fh
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-23 16:27:42 +09:00
Jes Sorensen deff11554f staging: rtl8723au: Make rtw_cfg80211_add_wep() take a struct rtw_wep_key
This allows the removal of the ugly struct ndis_8802_11_wep and simplify
rtw_cfg80211_add_wep(). In addition remove unused element ndiswep from
struct security_priv.

Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-23 16:27:42 +09:00
Jes Sorensen 6893c8ebba staging: rtl8723au: rtw_cfg80211_add_wep(): Get rid of unused keyindex flags
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-23 16:27:42 +09:00
Jes Sorensen 1e6e7f6030 staging: rtl8723au: Move rtw_set_802_11_add_wep23a() to ioctl_cfg80211.c
This is only called from ioctl_cfg80211.c so we can move it here and
declare it static.

Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-23 16:27:42 +09:00
Jes Sorensen e0827909a2 staging: rtl8723au: Introduce struct rtw_wep_key to store our wep keys
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-23 16:27:42 +09:00
Jes Sorensen 9e3d6df2df staging: rtl8723au: Use WLAN_CIPHER_SUITE_* to mark crypto type
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-23 16:27:42 +09:00
Jes Sorensen 07a4b1b1bc staging: rtl8723au: Remove unused enum odm_security
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-23 16:27:41 +09:00
Jes Sorensen 1de36ec316 staging: rtl8723au: We don't support SMS4 or WEP+WPA mixed encryption
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-23 16:27:41 +09:00
Jes Sorensen 7989bcf3e2 staging: rtl8723au: Store algorithm type in a u32
This will allow us to switch to using WLAN_CIPHER_SUITE_* later

Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-23 16:27:41 +09:00
Jes Sorensen af97d6cd7b staging: rtl8723au: Add -Wtype-limits to CFLAGS
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-23 16:27:41 +09:00
Jes Sorensen 9216c517fb staging: rtl8723au: Fix up some random bit-flag handling
Randomly mixing true/false/_FAIL/0/1 is a recipe for disaster

Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-23 16:27:41 +09:00