Commit Graph

982806 Commits

Author SHA1 Message Date
Mark Brown c7a83edf9d
Merge series "Add sanity checks for topology API calls" from Amadeusz Sławiński<amadeuszx.slawinski@linux.intel.com>:
Topology API exposes just 2 function calls, to load and unload topology.
This adds sanity checks to make sure that it behaves well when some of
parameters are set incoorectly or not needed.

This makes developer live easier by failing early instead of proceeding
on and then failing in unexpected ways.

As loading and unloading topology usually happens one the overhead of
additional checks should be negligible.

Amadeusz Sławiński (2):
  ASoC: topology: Ensure that needed parameters are set
  ASoC: topology: Check if ops is set before dereference

 sound/soc/soc-topology.c | 22 +++++++++++++++-------
 1 file changed, 15 insertions(+), 7 deletions(-)

--
2.25.1
2021-01-21 18:13:27 +00:00
Mark Brown ff385c1f4c
Merge series "ASoC: sync parameter naming : rate / sample_bits" from Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>:
Hi Mark

snd_pcm_runtime / snd_soc_dai / snd_soc_dai_driver / snd_soc_dai_link
have related parameter which is similar but not same naming.

	struct snd_pcm_runtime {
		...
(A)		unsigned int rate;
		...
(B)		unsigned int sample_bits;
		...
	};

	struct snd_soc_dai {
		...
(A)		unsigned int rate;
(B)		unsigned int sample_bits;
		...
	};

	struct snd_soc_dai_driver {
		...
(A)		unsigned int symmetric_rates:1;
(B)		unsigned int symmetric_samplebits:1;
		...
	};

	struct snd_soc_dai_link {
		...
(A)		unsigned int symmetric_rates:1;
(B)		unsigned int symmetric_samplebits:1;
		...
	};

Because it is similar but not same naming rule,
code can be verbose / can't share macro.

This patch-set sync naming rule
to struct snd_pcm_runtime base.

	- xxx_rates;
	+ xxx_rate;

	- xxx_samplebits;
	+ xxx_sample_bits;

Kuninori Morimoto (44):
  ASoC: soc-pcm: revert soc_pcm_apply_symmetry()
  ASoC: sync parameter naming : rate / sample_bits
  ASoC: adi: sync parameter naming (rate/sample_bits)
  ASoC: atmel: sync parameter naming (rate/sample_bits)
  ASoC: au1x: sync parameter naming (rate/sample_bits)
  ASoC: bcm: sync parameter naming (rate/sample_bits)
  ASoC: cirrus: sync parameter naming (rate/sample_bits)
  ASoC: tegra: sync parameter naming (rate/sample_bits)
  ASoC: rockchip: sync parameter naming (rate/sample_bits)
  ASoC: samsung: sync parameter naming (rate/sample_bits)
  ASoC: sh: sync parameter naming (rate/sample_bits)
  ASoC: ti: sync parameter naming (rate/sample_bits)
  ASoC: pxa: sync parameter naming (rate/sample_bits)
  ASoC: mediatek: sync parameter naming (rate/sample_bits)
  ASoC: fsl: sync parameter naming (rate/sample_bits)
  ASoC: wm*: sync parameter naming (rate/sample_bits)
  ASoC: tlv*: sync parameter naming (rate/sample_bits)
  ASoC: rt*: sync parameter naming (rate/sample_bits)
  ASoC: nau*: sync parameter naming (rate/sample_bits)
  ASoC: tas*: sync parameter naming (rate/sample_bits)
  ASoC: da*: sync parameter naming (rate/sample_bits)
  ASoC: es*: sync parameter naming (rate/sample_bits)
  ASoC: max*: sync parameter naming (rate/sample_bits)
  ASoC: cs*: sync parameter naming (rate/sample_bits)
  ASoC: tscs*: sync parameter naming (rate/sample_bits)
  ASoC: ak*: sync parameter naming (rate/sample_bits)
  ASoC: adau*: sync parameter naming (rate/sample_bits)
  ASoC: jz4740: sync parameter naming (rate/sample_bits)
  ASoC: sunxi: sync parameter naming (rate/sample_bits)
  ASoC: zl38060: sync parameter naming (rate/sample_bits)
  ASoC: ssm2602: sync parameter naming (rate/sample_bits)
  ASoC: sgtl5000: sync parameter naming (rate/sample_bits)
  ASoC: mc13783: sync parameter naming (rate/sample_bits)
  ASoC: mt6660: sync parameter naming (rate/sample_bits)
  ASoC: lochnagar-sc: sync parameter naming (rate/sample_bits)
  ASoC: ab8500: sync parameter naming (rate/sample_bits)
  ASoC: alc5632: sync parameter naming (rate/sample_bits)
  ASoC: cx2072x: sync parameter naming (rate/sample_bits)
  ASoC: inno_rk3036: sync parameter naming (rate/sample_bits)
  ASoC: lm49453: sync parameter naming (rate/sample_bits)
  ASoC: ml26124: sync parameter naming (rate/sample_bits)
  ASoC: soc-dai.h: remove symmetric_rates/samplebits
  ASoC: soc-pcm: cleanup soc_pcm_apply_symmetry()
  ASoC: soc-pcm: cleanup soc_pcm_params_symmetry()

 include/sound/soc-dai.h                    |  4 +-
 include/sound/soc.h                        |  4 +-
 sound/soc/adi/axi-i2s.c                    |  2 +-
 sound/soc/atmel/atmel-i2s.c                |  2 +-
 sound/soc/atmel/mchp-i2s-mcc.c             |  4 +-
 sound/soc/au1x/i2sc.c                      |  2 +-
 sound/soc/bcm/bcm2835-i2s.c                |  4 +-
 sound/soc/bcm/bcm63xx-i2s-whistler.c       |  2 +-
 sound/soc/cirrus/ep93xx-i2s.c              |  2 +-
 sound/soc/codecs/ab8500-codec.c            |  4 +-
 sound/soc/codecs/adau1372.c                |  2 +-
 sound/soc/codecs/adau1373.c                |  6 +-
 sound/soc/codecs/adau1701.c                |  2 +-
 sound/soc/codecs/ak4554.c                  |  2 +-
 sound/soc/codecs/ak4613.c                  |  2 +-
 sound/soc/codecs/ak4641.c                  |  4 +-
 sound/soc/codecs/ak4642.c                  |  2 +-
 sound/soc/codecs/alc5632.c                 |  2 +-
 sound/soc/codecs/cs35l32.c                 |  2 +-
 sound/soc/codecs/cs35l33.c                 |  2 +-
 sound/soc/codecs/cs35l34.c                 |  2 +-
 sound/soc/codecs/cs35l35.c                 |  2 +-
 sound/soc/codecs/cs35l36.c                 |  2 +-
 sound/soc/codecs/cs4234.c                  |  2 +-
 sound/soc/codecs/cs4271.c                  |  2 +-
 sound/soc/codecs/cs42l73.c                 |  6 +-
 sound/soc/codecs/cs43130.c                 |  6 +-
 sound/soc/codecs/cs4341.c                  |  2 +-
 sound/soc/codecs/cs4349.c                  |  2 +-
 sound/soc/codecs/cs47l15.c                 | 12 ++--
 sound/soc/codecs/cs47l24.c                 | 12 ++--
 sound/soc/codecs/cs47l35.c                 | 12 ++--
 sound/soc/codecs/cs47l85.c                 | 16 ++---
 sound/soc/codecs/cs47l90.c                 | 16 ++---
 sound/soc/codecs/cs47l92.c                 | 12 ++--
 sound/soc/codecs/cs53l30.c                 |  2 +-
 sound/soc/codecs/cx2072x.c                 |  2 +-
 sound/soc/codecs/da7210.c                  |  2 +-
 sound/soc/codecs/da7213.c                  |  2 +-
 sound/soc/codecs/da7218.c                  |  4 +-
 sound/soc/codecs/da7219.c                  |  4 +-
 sound/soc/codecs/da9055.c                  |  2 +-
 sound/soc/codecs/es8316.c                  |  2 +-
 sound/soc/codecs/es8328.c                  |  2 +-
 sound/soc/codecs/inno_rk3036.c             |  2 +-
 sound/soc/codecs/jz4740.c                  |  2 +-
 sound/soc/codecs/lm49453.c                 |  2 +-
 sound/soc/codecs/lochnagar-sc.c            | 12 ++--
 sound/soc/codecs/max9860.c                 |  2 +-
 sound/soc/codecs/max9867.c                 |  2 +-
 sound/soc/codecs/mc13783.c                 |  2 +-
 sound/soc/codecs/ml26124.c                 |  2 +-
 sound/soc/codecs/mt6660.c                  |  4 +-
 sound/soc/codecs/nau8810.c                 |  2 +-
 sound/soc/codecs/nau8822.c                 |  2 +-
 sound/soc/codecs/rt274.c                   |  2 +-
 sound/soc/codecs/rt286.c                   |  4 +-
 sound/soc/codecs/rt298.c                   |  4 +-
 sound/soc/codecs/rt5670.c                  |  4 +-
 sound/soc/codecs/sgtl5000.c                |  2 +-
 sound/soc/codecs/ssm2602.c                 |  4 +-
 sound/soc/codecs/tas2764.c                 |  2 +-
 sound/soc/codecs/tas2770.c                 |  2 +-
 sound/soc/codecs/tlv320adcx140.c           |  2 +-
 sound/soc/codecs/tlv320aic31xx.c           |  4 +-
 sound/soc/codecs/tlv320aic32x4.c           |  2 +-
 sound/soc/codecs/tlv320aic3x.c             |  2 +-
 sound/soc/codecs/tscs42xx.c                |  4 +-
 sound/soc/codecs/tscs454.c                 | 12 ++--
 sound/soc/codecs/wm5102.c                  | 12 ++--
 sound/soc/codecs/wm5110.c                  | 12 ++--
 sound/soc/codecs/wm8510.c                  |  2 +-
 sound/soc/codecs/wm8731.c                  |  2 +-
 sound/soc/codecs/wm8770.c                  |  2 +-
 sound/soc/codecs/wm8804.c                  |  2 +-
 sound/soc/codecs/wm8903.c                  |  2 +-
 sound/soc/codecs/wm8904.c                  |  2 +-
 sound/soc/codecs/wm8940.c                  |  2 +-
 sound/soc/codecs/wm8960.c                  |  2 +-
 sound/soc/codecs/wm8962.c                  |  2 +-
 sound/soc/codecs/wm8974.c                  |  2 +-
 sound/soc/codecs/wm8978.c                  |  2 +-
 sound/soc/codecs/wm8983.c                  |  2 +-
 sound/soc/codecs/wm8985.c                  |  2 +-
 sound/soc/codecs/wm8988.c                  |  2 +-
 sound/soc/codecs/wm8993.c                  |  2 +-
 sound/soc/codecs/wm8994.c                  |  4 +-
 sound/soc/codecs/wm8997.c                  |  8 +--
 sound/soc/codecs/wm8998.c                  | 12 ++--
 sound/soc/codecs/wm9713.c                  |  2 +-
 sound/soc/codecs/zl38060.c                 |  4 +-
 sound/soc/fsl/fsl_esai.c                   |  4 +-
 sound/soc/fsl/fsl_sai.c                    |  8 +--
 sound/soc/fsl/fsl_ssi.c                    |  4 +-
 sound/soc/jz4740/jz4740-i2s.c              |  2 +-
 sound/soc/mediatek/mt2701/mt2701-afe-pcm.c | 10 +--
 sound/soc/mediatek/mt6797/mt6797-dai-pcm.c |  8 +--
 sound/soc/mediatek/mt8173/mt8173-afe-pcm.c |  2 +-
 sound/soc/mediatek/mt8183/mt8183-dai-pcm.c |  8 +--
 sound/soc/mediatek/mt8192/mt8192-dai-pcm.c |  8 +--
 sound/soc/pxa/pxa2xx-i2s.c                 |  2 +-
 sound/soc/rockchip/rockchip_i2s.c          |  4 +-
 sound/soc/rockchip/rockchip_pdm.c          |  2 +-
 sound/soc/samsung/i2s.c                    |  2 +-
 sound/soc/samsung/pcm.c                    |  2 +-
 sound/soc/sh/rcar/core.c                   |  4 +-
 sound/soc/soc-pcm.c                        | 80 +++++++---------------
 sound/soc/soc-topology.c                   |  8 +--
 sound/soc/sunxi/sun4i-i2s.c                |  2 +-
 sound/soc/sunxi/sun8i-codec.c              | 12 ++--
 sound/soc/tegra/tegra186_dspk.c            |  2 +-
 sound/soc/tegra/tegra20_i2s.c              |  2 +-
 sound/soc/tegra/tegra210_dmic.c            |  2 +-
 sound/soc/tegra/tegra210_i2s.c             |  2 +-
 sound/soc/tegra/tegra30_i2s.c              |  2 +-
 sound/soc/ti/davinci-mcasp.c               |  2 +-
 116 files changed, 253 insertions(+), 283 deletions(-)

--
2.25.1
2021-01-21 18:13:25 +00:00
Mark Brown 1e924131e9
Merge series "Add KUNIT tests for ASoC topology" from Amadeusz Sławiński<amadeuszx.slawinski@linux.intel.com>:
This series adds unit tests for ASoC topology.

First fix problems found when developing and running test cases and
then add tests implementation.

Tests themselves are quite simple and just call
snd_soc_tplg_component_load() with various parameters and check the
result. Tests themselves are described in more detail in commits
adding them.

Goal is to expand the amount of test cases in following patches.

Prerequisity for this patchset are 2 patches which have already been
sent:
https://lore.kernel.org/alsa-devel/20210114163602.911205-1-amadeuszx.slawinski@linux.intel.com/T/#t

Description on how typical test case itself works:

In order to load topology we need to have 3 things:
card, codec component & platform component.

In typical test case we register card and platform component and bind
to dummy codec. There are of course execeptions, when we want to
test behaviour of topology API when component or card is missing.
Note that this is bit different from typical scenario (in SOF and skylake
drivers) where card is registered by machine driver and component by
platform driver, as we register both when setting up test.

If you check the test case most of them have similar architecture of:
1.
	/* run test */
	ret = snd_soc_register_card(&kunit_comp->card);
	if (ret != 0 && ret != -EPROBE_DEFER)
		KUNIT_FAIL(test, "Failed to register card");

2.
	ret = snd_soc_component_initialize(&kunit_comp->comp, &test_component, test_dev);
	KUNIT_EXPECT_EQ(test, 0, ret);

3.
	ret = snd_soc_add_component(&kunit_comp->comp, NULL, 0);
	KUNIT_EXPECT_EQ(test, 0, ret);

Ad. 1.
First we register card, which in most tests returns -EPROBE_DEFER
(from snd_soc_bind_card()), as platform component is not yet created.
I test for both 0 and -EPROBE_DEFER, as it makes it easier to reshuffle
this code around if needed and there is one test case which does it in
different order.

Ad. 2.
Then we initialize platform component with structure pointing at proper
probe function, which calls snd_soc_tplg_component_load() with test
parameters and checks expected result.

Ad. 3.
And then in follow up we call snd_soc_add_component() which creates
platform component for us and calls snd_soc_try_rebind_card() which
if everything is bound properly calls previously set probe function.

Amadeusz Sławiński (5):
  ASoC: topology: Properly unregister DAI on removal
  Revert "ASoC: soc-devres: add devm_snd_soc_register_dai()"
  ASoC: topology: KUnit: Add KUnit tests passing various arguments to
    snd_soc_tplg_component_load
  ASoC: topology: KUnit: Add KUnit tests passing empty topology with
    variants to snd_soc_tplg_component_load
  ASoC: topology: KUnit: Add KUnit tests passing topology with PCM to
    snd_soc_tplg_component_load

 include/sound/soc.h           |   4 -
 sound/soc/Kconfig             |  17 +
 sound/soc/Makefile            |   5 +
 sound/soc/soc-devres.c        |  37 --
 sound/soc/soc-topology-test.c | 843 ++++++++++++++++++++++++++++++++++
 sound/soc/soc-topology.c      |   9 +-
 6 files changed, 870 insertions(+), 45 deletions(-)
 create mode 100644 sound/soc/soc-topology-test.c

--
2.25.1
2021-01-21 18:13:24 +00:00
Shuming Fan 06c8456753
ASoC: rt5682: remove connection with LDO2 in DAPM graph
The application circuit shall provide MICVDD power.
In default, the codec driver doesn't need to enable LDO2.
In case, a board wants to use VBAT for micbias,
it should add a DAPM route which IN1P connects with LDO2 in the machine driver.
e.g. { "IN1P", NULL, "LDO2" },

Signed-off-by: Shuming Fan <shumingf@realtek.com>
Link: https://lore.kernel.org/r/20210121100353.6402-1-shumingf@realtek.com
Signed-off-by: Mark Brown <broonie@kernel.org>
2021-01-21 12:40:24 +00:00
Kuninori Morimoto 3a90672111
ASoC: soc-pcm: cleanup soc_pcm_params_symmetry()
soc_pcm_params_symmetry() checks rate/channel/sample_bits state.
These are very similar but different, thus, it needs to have very
verbose code.
This patch use macro for it and make code more simple.

Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Link: https://lore.kernel.org/r/878s8un6si.wl-kuninori.morimoto.gx@renesas.com
Signed-off-by: Mark Brown <broonie@kernel.org>
2021-01-21 12:38:22 +00:00
Kuninori Morimoto fac110cbcd
ASoC: soc-pcm: cleanup soc_pcm_apply_symmetry()
soc_pcm_apply_symmetry() want to call snd_pcm_hw_constraint_single()
for rate/channel/sample_bits, but, it needs many condition checks.
These are very similar but different, thus, it needs to have very
verbose code.
This patch use macro for it and make code more simple.

Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Link: https://lore.kernel.org/r/87a6tan6sm.wl-kuninori.morimoto.gx@renesas.com
Signed-off-by: Mark Brown <broonie@kernel.org>
2021-01-21 12:38:21 +00:00
Kuninori Morimoto fa31a2c787
ASoC: soc-dai.h: remove symmetric_rates/samplebits
All drivers are using new name.
Let's remove old one.

Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Link: https://lore.kernel.org/r/87bldqn6sr.wl-kuninori.morimoto.gx@renesas.com
Signed-off-by: Mark Brown <broonie@kernel.org>
2021-01-21 12:38:20 +00:00
Kuninori Morimoto 6944db0ab8
ASoC: ml26124: sync parameter naming (rate/sample_bits)
This patch syncs naming rule.

 - xxx_rates;
 + xxx_rate;

 - xxx_samplebits;
 + xxx_sample_bits;

Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Link: https://lore.kernel.org/r/87czy6n6t0.wl-kuninori.morimoto.gx@renesas.com
Signed-off-by: Mark Brown <broonie@kernel.org>
2021-01-21 12:38:19 +00:00
Kuninori Morimoto 3b940ecd2e
ASoC: lm49453: sync parameter naming (rate/sample_bits)
This patch syncs naming rule.

 - xxx_rates;
 + xxx_rate;

 - xxx_samplebits;
 + xxx_sample_bits;

Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Link: https://lore.kernel.org/r/87eeimn6t4.wl-kuninori.morimoto.gx@renesas.com
Signed-off-by: Mark Brown <broonie@kernel.org>
2021-01-21 12:38:19 +00:00
Kuninori Morimoto d5d396c8b0
ASoC: inno_rk3036: sync parameter naming (rate/sample_bits)
This patch syncs naming rule.

 - xxx_rates;
 + xxx_rate;

 - xxx_samplebits;
 + xxx_sample_bits;

Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Link: https://lore.kernel.org/r/87ft32n6t8.wl-kuninori.morimoto.gx@renesas.com
Signed-off-by: Mark Brown <broonie@kernel.org>
2021-01-21 12:38:18 +00:00
Kuninori Morimoto 15d27c2b12
ASoC: cx2072x: sync parameter naming (rate/sample_bits)
This patch syncs naming rule.

 - xxx_rates;
 + xxx_rate;

 - xxx_samplebits;
 + xxx_sample_bits;

Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Link: https://lore.kernel.org/r/87h7nin6tc.wl-kuninori.morimoto.gx@renesas.com
Signed-off-by: Mark Brown <broonie@kernel.org>
2021-01-21 12:38:17 +00:00
Kuninori Morimoto 278eacf3dc
ASoC: alc5632: sync parameter naming (rate/sample_bits)
This patch syncs naming rule.

 - xxx_rates;
 + xxx_rate;

 - xxx_samplebits;
 + xxx_sample_bits;

Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Link: https://lore.kernel.org/r/87im7yn6th.wl-kuninori.morimoto.gx@renesas.com
Signed-off-by: Mark Brown <broonie@kernel.org>
2021-01-21 12:38:16 +00:00
Kuninori Morimoto 6058bcb497
ASoC: ab8500: sync parameter naming (rate/sample_bits)
This patch syncs naming rule.

 - xxx_rates;
 + xxx_rate;

 - xxx_samplebits;
 + xxx_sample_bits;

Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Link: https://lore.kernel.org/r/87k0sen6tl.wl-kuninori.morimoto.gx@renesas.com
Signed-off-by: Mark Brown <broonie@kernel.org>
2021-01-21 12:38:15 +00:00
Kuninori Morimoto 65ba325625
ASoC: lochnagar-sc: sync parameter naming (rate/sample_bits)
This patch syncs naming rule.

 - xxx_rates;
 + xxx_rate;

 - xxx_samplebits;
 + xxx_sample_bits;

Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Link: https://lore.kernel.org/r/87lfcun6tp.wl-kuninori.morimoto.gx@renesas.com
Signed-off-by: Mark Brown <broonie@kernel.org>
2021-01-21 12:38:14 +00:00
Kuninori Morimoto 852d4daa96
ASoC: mt6660: sync parameter naming (rate/sample_bits)
This patch syncs naming rule.

 - xxx_rates;
 + xxx_rate;

 - xxx_samplebits;
 + xxx_sample_bits;

Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Link: https://lore.kernel.org/r/87mtxan6tt.wl-kuninori.morimoto.gx@renesas.com
Signed-off-by: Mark Brown <broonie@kernel.org>
2021-01-21 12:38:13 +00:00
Kuninori Morimoto 23df7f69ff
ASoC: mc13783: sync parameter naming (rate/sample_bits)
This patch syncs naming rule.

 - xxx_rates;
 + xxx_rate;

 - xxx_samplebits;
 + xxx_sample_bits;

Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Link: https://lore.kernel.org/r/87o8hqn6ty.wl-kuninori.morimoto.gx@renesas.com
Signed-off-by: Mark Brown <broonie@kernel.org>
2021-01-21 12:38:12 +00:00
Kuninori Morimoto bea17630c4
ASoC: sgtl5000: sync parameter naming (rate/sample_bits)
This patch syncs naming rule.

 - xxx_rates;
 + xxx_rate;

 - xxx_samplebits;
 + xxx_sample_bits;

Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Link: https://lore.kernel.org/r/87pn26n6u4.wl-kuninori.morimoto.gx@renesas.com
Signed-off-by: Mark Brown <broonie@kernel.org>
2021-01-21 12:38:11 +00:00
Kuninori Morimoto 4735c8cadd
ASoC: ssm2602: sync parameter naming (rate/sample_bits)
This patch syncs naming rule.

 - xxx_rates;
 + xxx_rate;

 - xxx_samplebits;
 + xxx_sample_bits;

Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Link: https://lore.kernel.org/r/87r1mmn6ub.wl-kuninori.morimoto.gx@renesas.com
Signed-off-by: Mark Brown <broonie@kernel.org>
2021-01-21 12:38:10 +00:00
Kuninori Morimoto b33c088a9b
ASoC: zl38060: sync parameter naming (rate/sample_bits)
This patch syncs naming rule.

 - xxx_rates;
 + xxx_rate;

 - xxx_samplebits;
 + xxx_sample_bits;

Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Link: https://lore.kernel.org/r/87sg72n6ug.wl-kuninori.morimoto.gx@renesas.com
Signed-off-by: Mark Brown <broonie@kernel.org>
2021-01-21 12:38:09 +00:00
Kuninori Morimoto 8138570861
ASoC: sunxi: sync parameter naming (rate/sample_bits)
This patch syncs naming rule.

 - xxx_rates;
 + xxx_rate;

 - xxx_samplebits;
 + xxx_sample_bits;

Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Link: https://lore.kernel.org/r/87turin6uk.wl-kuninori.morimoto.gx@renesas.com
Signed-off-by: Mark Brown <broonie@kernel.org>
2021-01-21 12:38:09 +00:00
Kuninori Morimoto 0547dece8d
ASoC: jz4740: sync parameter naming (rate/sample_bits)
This patch syncs naming rule.

 - xxx_rates;
 + xxx_rate;

 - xxx_samplebits;
 + xxx_sample_bits;

Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Link: https://lore.kernel.org/r/87v9byn6uo.wl-kuninori.morimoto.gx@renesas.com
Signed-off-by: Mark Brown <broonie@kernel.org>
2021-01-21 12:38:08 +00:00
Kuninori Morimoto f88f45861b
ASoC: adau*: sync parameter naming (rate/sample_bits)
This patch syncs naming rule.

 - xxx_rates;
 + xxx_rate;

 - xxx_samplebits;
 + xxx_sample_bits;

Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Link: https://lore.kernel.org/r/87wnwen6v8.wl-kuninori.morimoto.gx@renesas.com
Signed-off-by: Mark Brown <broonie@kernel.org>
2021-01-21 12:38:07 +00:00
Kuninori Morimoto 870b76ea7d
ASoC: ak*: sync parameter naming (rate/sample_bits)
This patch syncs naming rule.

 - xxx_rates;
 + xxx_rate;

 - xxx_samplebits;
 + xxx_sample_bits;

Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Link: https://lore.kernel.org/r/87y2gun6vc.wl-kuninori.morimoto.gx@renesas.com
Signed-off-by: Mark Brown <broonie@kernel.org>
2021-01-21 12:38:06 +00:00
Kuninori Morimoto 9b4488efde
ASoC: tscs*: sync parameter naming (rate/sample_bits)
This patch syncs naming rule.

 - xxx_rates;
 + xxx_rate;

 - xxx_samplebits;
 + xxx_sample_bits;

Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Link: https://lore.kernel.org/r/87zh1an6vh.wl-kuninori.morimoto.gx@renesas.com
Signed-off-by: Mark Brown <broonie@kernel.org>
2021-01-21 12:38:05 +00:00
Kuninori Morimoto 260b668cf3
ASoC: cs*: sync parameter naming (rate/sample_bits)
This patch syncs naming rule.

 - xxx_rates;
 + xxx_rate;

 - xxx_samplebits;
 + xxx_sample_bits;

Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Link: https://lore.kernel.org/r/871remolg1.wl-kuninori.morimoto.gx@renesas.com
Signed-off-by: Mark Brown <broonie@kernel.org>
2021-01-21 12:38:04 +00:00
Kuninori Morimoto cb40d1b458
ASoC: max*: sync parameter naming (rate/sample_bits)
This patch syncs naming rule.

 - xxx_rates;
 + xxx_rate;

 - xxx_samplebits;
 + xxx_sample_bits;

Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Link: https://lore.kernel.org/r/8735z2olg5.wl-kuninori.morimoto.gx@renesas.com
Signed-off-by: Mark Brown <broonie@kernel.org>
2021-01-21 12:38:03 +00:00
Kuninori Morimoto 4060064e8b
ASoC: es*: sync parameter naming (rate/sample_bits)
This patch syncs naming rule.

 - xxx_rates;
 + xxx_rate;

 - xxx_samplebits;
 + xxx_sample_bits;

Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Link: https://lore.kernel.org/r/874kjiolga.wl-kuninori.morimoto.gx@renesas.com
Signed-off-by: Mark Brown <broonie@kernel.org>
2021-01-21 12:38:02 +00:00
Kuninori Morimoto 1c6d1c4f68
ASoC: da*: sync parameter naming (rate/sample_bits)
This patch syncs naming rule.

 - xxx_rates;
 + xxx_rate;

 - xxx_samplebits;
 + xxx_sample_bits;

Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Link: https://lore.kernel.org/r/875z3yolgf.wl-kuninori.morimoto.gx@renesas.com
Signed-off-by: Mark Brown <broonie@kernel.org>
2021-01-21 12:38:01 +00:00
Kuninori Morimoto fa056c0736
ASoC: tas*: sync parameter naming (rate/sample_bits)
This patch syncs naming rule.

 - xxx_rates;
 + xxx_rate;

 - xxx_samplebits;
 + xxx_sample_bits;

Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Link: https://lore.kernel.org/r/877doeolgk.wl-kuninori.morimoto.gx@renesas.com
Signed-off-by: Mark Brown <broonie@kernel.org>
2021-01-21 12:38:00 +00:00
Kuninori Morimoto 42c9b5bec1
ASoC: nau*: sync parameter naming (rate/sample_bits)
This patch syncs naming rule.

 - xxx_rates;
 + xxx_rate;

 - xxx_samplebits;
 + xxx_sample_bits;

Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Link: https://lore.kernel.org/r/878s8uolgo.wl-kuninori.morimoto.gx@renesas.com
Signed-off-by: Mark Brown <broonie@kernel.org>
2021-01-21 12:37:59 +00:00
Kuninori Morimoto bc03b3910e
ASoC: rt*: sync parameter naming (rate/sample_bits)
This patch syncs naming rule.

 - xxx_rates;
 + xxx_rate;

 - xxx_samplebits;
 + xxx_sample_bits;

Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Link: https://lore.kernel.org/r/87a6taolgs.wl-kuninori.morimoto.gx@renesas.com
Signed-off-by: Mark Brown <broonie@kernel.org>
2021-01-21 12:37:59 +00:00
Kuninori Morimoto a9aef184f7
ASoC: tlv*: sync parameter naming (rate/sample_bits)
This patch syncs naming rule.

 - xxx_rates;
 + xxx_rate;

 - xxx_samplebits;
 + xxx_sample_bits;

Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Link: https://lore.kernel.org/r/87bldqolgw.wl-kuninori.morimoto.gx@renesas.com
Signed-off-by: Mark Brown <broonie@kernel.org>
2021-01-21 12:37:58 +00:00
Kuninori Morimoto 0769575294
ASoC: wm*: sync parameter naming (rate/sample_bits)
This patch syncs naming rule.

 - xxx_rates;
 + xxx_rate;

 - xxx_samplebits;
 + xxx_sample_bits;

Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Link: https://lore.kernel.org/r/87czy6olh0.wl-kuninori.morimoto.gx@renesas.com
Signed-off-by: Mark Brown <broonie@kernel.org>
2021-01-21 12:37:57 +00:00
Kuninori Morimoto cb2f6927fa
ASoC: fsl: sync parameter naming (rate/sample_bits)
This patch syncs naming rule.

 - xxx_rates;
 + xxx_rate;

 - xxx_samplebits;
 + xxx_sample_bits;

Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Link: https://lore.kernel.org/r/87eeimolh5.wl-kuninori.morimoto.gx@renesas.com
Signed-off-by: Mark Brown <broonie@kernel.org>
2021-01-21 12:37:56 +00:00
Kuninori Morimoto 4b7ead032e
ASoC: mediatek: sync parameter naming (rate/sample_bits)
This patch syncs naming rule.

 - xxx_rates;
 + xxx_rate;

 - xxx_samplebits;
 + xxx_sample_bits;

Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Link: https://lore.kernel.org/r/87ft32olha.wl-kuninori.morimoto.gx@renesas.com
Signed-off-by: Mark Brown <broonie@kernel.org>
2021-01-21 12:37:55 +00:00
Kuninori Morimoto c658b21858
ASoC: pxa: sync parameter naming (rate/sample_bits)
This patch syncs naming rule.

 - xxx_rates;
 + xxx_rate;

 - xxx_samplebits;
 + xxx_sample_bits;

Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Link: https://lore.kernel.org/r/87h7niolhf.wl-kuninori.morimoto.gx@renesas.com
Signed-off-by: Mark Brown <broonie@kernel.org>
2021-01-21 12:37:54 +00:00
Kuninori Morimoto c756316f00
ASoC: ti: sync parameter naming (rate/sample_bits)
This patch syncs naming rule.

 - xxx_rates;
 + xxx_rate;

 - xxx_samplebits;
 + xxx_sample_bits;

Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Link: https://lore.kernel.org/r/87im7yolhk.wl-kuninori.morimoto.gx@renesas.com
Signed-off-by: Mark Brown <broonie@kernel.org>
2021-01-21 12:37:53 +00:00
Kuninori Morimoto f1cd5f3bbc
ASoC: sh: sync parameter naming (rate/sample_bits)
This patch syncs naming rule.

 - xxx_rates;
 + xxx_rate;

 - xxx_samplebits;
 + xxx_sample_bits;

Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Link: https://lore.kernel.org/r/87k0seolho.wl-kuninori.morimoto.gx@renesas.com
Signed-off-by: Mark Brown <broonie@kernel.org>
2021-01-21 12:37:52 +00:00
Kuninori Morimoto d11ff0bf6a
ASoC: samsung: sync parameter naming (rate/sample_bits)
This patch syncs naming rule.

 - xxx_rates;
 + xxx_rate;

 - xxx_samplebits;
 + xxx_sample_bits;

Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Link: https://lore.kernel.org/r/87lfcuolhu.wl-kuninori.morimoto.gx@renesas.com
Signed-off-by: Mark Brown <broonie@kernel.org>
2021-01-21 12:37:51 +00:00
Kuninori Morimoto fadaed3023
ASoC: rockchip: sync parameter naming (rate/sample_bits)
This patch syncs naming rule.

 - xxx_rates;
 + xxx_rate;

 - xxx_samplebits;
 + xxx_sample_bits;

Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Link: https://lore.kernel.org/r/87mtxaolhz.wl-kuninori.morimoto.gx@renesas.com
Signed-off-by: Mark Brown <broonie@kernel.org>
2021-01-21 12:37:50 +00:00
Kuninori Morimoto c6d152a8de
ASoC: tegra: sync parameter naming (rate/sample_bits)
This patch syncs naming rule.

 - xxx_rates;
 + xxx_rate;

 - xxx_samplebits;
 + xxx_sample_bits;

Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Link: https://lore.kernel.org/r/87o8hqoli4.wl-kuninori.morimoto.gx@renesas.com
Signed-off-by: Mark Brown <broonie@kernel.org>
2021-01-21 12:37:49 +00:00
Kuninori Morimoto f1e6b04bab
ASoC: cirrus: sync parameter naming (rate/sample_bits)
This patch syncs naming rule.

 - xxx_rates;
 + xxx_rate;

 - xxx_samplebits;
 + xxx_sample_bits;

Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Link: https://lore.kernel.org/r/87pn26oli8.wl-kuninori.morimoto.gx@renesas.com
Signed-off-by: Mark Brown <broonie@kernel.org>
2021-01-21 12:37:48 +00:00
Kuninori Morimoto a8e940222b
ASoC: bcm: sync parameter naming (rate/sample_bits)
This patch syncs naming rule.

 - xxx_rates;
 + xxx_rate;

 - xxx_samplebits;
 + xxx_sample_bits;

Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Link: https://lore.kernel.org/r/87r1mmolie.wl-kuninori.morimoto.gx@renesas.com
Signed-off-by: Mark Brown <broonie@kernel.org>
2021-01-21 12:37:47 +00:00
Kuninori Morimoto 3470c2398c
ASoC: au1x: sync parameter naming (rate/sample_bits)
This patch syncs naming rule.

 - xxx_rates;
 + xxx_rate;

 - xxx_samplebits;
 + xxx_sample_bits;

Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Link: https://lore.kernel.org/r/87sg72olij.wl-kuninori.morimoto.gx@renesas.com
Signed-off-by: Mark Brown <broonie@kernel.org>
2021-01-21 12:37:46 +00:00
Kuninori Morimoto ba471f8d16
ASoC: atmel: sync parameter naming (rate/sample_bits)
This patch syncs naming rule.

 - xxx_rates;
 + xxx_rate;

 - xxx_samplebits;
 + xxx_sample_bits;

Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Link: https://lore.kernel.org/r/87turiolio.wl-kuninori.morimoto.gx@renesas.com
Signed-off-by: Mark Brown <broonie@kernel.org>
2021-01-21 12:37:45 +00:00
Kuninori Morimoto 55d0056ba6
ASoC: adi: sync parameter naming (rate/sample_bits)
This patch syncs naming rule.

 - xxx_rates;
 + xxx_rate;

 - xxx_samplebits;
 + xxx_sample_bits;

Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Link: https://lore.kernel.org/r/87v9byolj1.wl-kuninori.morimoto.gx@renesas.com
Signed-off-by: Mark Brown <broonie@kernel.org>
2021-01-21 12:37:44 +00:00
Kuninori Morimoto f14654ddf2
ASoC: sync parameter naming : rate / sample_bits
snd_pcm_runtime / snd_soc_dai / snd_soc_dai_driver / snd_soc_dai_link
have related parameter which is similar but not same naming.

	struct snd_pcm_runtime {
		...
(A)		unsigned int rate;
		...
(B)		unsigned int sample_bits;
		...
	};

	struct snd_soc_dai {
		...
(A)		unsigned int rate;
(B)		unsigned int sample_bits;
		...
	};

	struct snd_soc_dai_driver {
		...
(A)		unsigned int symmetric_rates:1;
(B)		unsigned int symmetric_samplebits:1;
		...
	};

	struct snd_soc_dai_link {
		...
(A)		unsigned int symmetric_rates:1;
(B)		unsigned int symmetric_samplebits:1;
		...
	};

Because it is similar but not same naming rule,
code can be verbose / can't share macro.

This patch sync naming rule for framework.
	- xxx_rates;
	+ xxx_rate;

	- xxx_samplebits;
	+ xxx_sample_bits;

old name will be removed if all drivers were switched
to new naming rule.

Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Link: https://lore.kernel.org/r/87wnweolj6.wl-kuninori.morimoto.gx@renesas.com
Signed-off-by: Mark Brown <broonie@kernel.org>
2021-01-21 12:37:43 +00:00
Kuninori Morimoto 80f454e283
ASoC: soc-pcm: revert soc_pcm_apply_symmetry()
commit a39748d03c ("ASoC: soc-pcm: cleanup soc_pcm_apply_symmetry()")
was applied by miscommunication.
To more cleanup code, and to be easy review, this patch reverts it.

Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Link: https://lore.kernel.org/r/87y2guoljm.wl-kuninori.morimoto.gx@renesas.com
Signed-off-by: Mark Brown <broonie@kernel.org>
2021-01-21 12:37:43 +00:00
Amadeusz Sławiński 9c88a98383
ASoC: topology: Check if ops is set before dereference
Topology can be created without ops overrides, in that case trying to
assign any value would lead to dereferencing NULL pointer.

Other places in code have either checks for tplg->ops or loop using
*_count variables, hence they can't dereference NULL pointer and there
is no need to add more checks.

Signed-off-by: Amadeusz Sławiński <amadeuszx.slawinski@linux.intel.com>
Link: https://lore.kernel.org/r/20210114163602.911205-3-amadeuszx.slawinski@linux.intel.com
Signed-off-by: Mark Brown <broonie@kernel.org>
2021-01-21 12:37:05 +00:00
Amadeusz Sławiński d40ab86f7d
ASoC: topology: Ensure that needed parameters are set
As snd_soc_tplg_component_load is exported function, which means it is
part of API, there should be checks if it is called with proper
parameters.

Signed-off-by: Amadeusz Sławiński <amadeuszx.slawinski@linux.intel.com>
Link: https://lore.kernel.org/r/20210114163602.911205-2-amadeuszx.slawinski@linux.intel.com
Signed-off-by: Mark Brown <broonie@kernel.org>
2021-01-21 12:37:04 +00:00