Commit Graph

810 Commits

Author SHA1 Message Date
Miguel Oliveira 1a4493c555 staging: rtl8723au: Fix static symbol sparse warning
Fix sparse warning:
drivers/staging/rtl8723au/core/rtw_efuse.c:579:5: warning: symbol 'efuse_GetCurrentSize23a' was not declared. Should it be static?
by removing efuse_GetCurrentSize23a since its never used

Signed-off-by: Miguel Oliveira <cmroliv@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-08-01 14:44:01 -07:00
Jes Sorensen bd2dec915e staging: rtl8723au: usb_dvobj_init(): Remove unused variable 'pdev_desc'
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-08-01 14:43:37 -07:00
Jes Sorensen c8875b2f1f staging: rtl8723au: Do not duplicate kernel provided USB macros
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-08-01 14:43:37 -07:00
Jes Sorensen 06736c2914 staging: rtl8723au: Remove never set struct pwrctrl_priv.bHWPowerdown
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-08-01 14:43:37 -07:00
Jes Sorensen a48dd468ef staging: rtl8723au: Remove two never set variables
struct registry_priv.usbss_enable and
struct pwrctrl_priv.bHWPwrPindetect are never set.

Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-08-01 14:43:37 -07:00
Jes Sorensen 1a8dcde8d3 staging: rtl8723au: RSSI_test is never set
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-08-01 14:43:37 -07:00
Masanari Iida 808bcb4e78 staging: rtl8723au: Fix typo in rtl8723au/core
This patch fix spelling typo in comments within
rtl8723au/core.

Signed-off-by: Masanari Iida <standby24x7@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-07-22 16:09:08 -07:00
Masanari Iida 96b0a5baa9 staging: rtl8723au: Fix typo in rtw_ap.c
This patch fix spelling typo in comments within rtw_ap.c

Signed-off-by: Masanari Iida <standby24x7@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-07-22 16:09:08 -07:00
Masanari Iida c582db4cb8 staging: rtl8723au: Fix typo in rtw_xmit.c
This patch fix spelling typo in comments within rtw_xmit.c

Signed-off-by: Masanari Iida <standby24x7@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-07-22 16:09:08 -07:00
Masanari Iida 7c17d2d9b4 staging: rtl8723au: Fix typo in rtw_mlme.c
This patch fix spelling typo in comments within rtw_mlme.c

Signed-off-by: Masanari Iida <standby24x7@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-07-22 16:08:13 -07:00
Masanari Iida fae062ad57 staging: rtl8723au: Fix typo in rtw_mlme_ext.c
This patch fix spelling typo in comments within rtw_mlme_ext.c

Signed-off-by: Masanari Iida <standby24x7@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-07-22 15:47:19 -07:00
Jes Sorensen d71c77b116 staging: rtl8723au: rtw_resume(): release semaphore before exit on error
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-07-21 12:09:28 -07:00
Jes Sorensen 30c588e04c staging: rtl8723au: Fold rtw_resume_process23a() into rtw_resume()
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-07-21 12:09:28 -07:00
Jes Sorensen dc20d1da78 staging: rtl8723au: Reduce wrapper layers around hal_{de, }init() calls
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-07-21 12:09:28 -07:00
Jes Sorensen d0b39f8742 staging: rtl8723au: Fold rtl8723a_set_nav_upper() into rtl8723au_hal_init()
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-07-21 12:09:27 -07:00
Jes Sorensen 62900ebf47 staging: rtl8723au: Remove a pile of fluff for calling into a bunch of no-op functions
The whole antenna diversity selection was completely pointless as all
the end functions called were no-ops.

Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-07-21 12:09:27 -07:00
Jes Sorensen 36cf7c75af staging: rtl8723au: odm_CommonInfoSelfInit23a(): Use proper register defines
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-07-21 12:09:27 -07:00
Jes Sorensen 62b0d72b3c staging: rtl8723au: Merge Init_ODM_ComInfo_8723a() into rtl8723a_init_dm_priv()
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-07-21 12:09:27 -07:00
Jes Sorensen bd9bda22d8 staging: rtl8723au: Remove obsolete ODM23a_CmnInfoHook()
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-07-21 12:09:27 -07:00
Jes Sorensen 555f1ca7bc staging: rtl8723au: Eliminate obsolete odm_CmnInfoHook_Debug23a()
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-07-21 12:09:27 -07:00
Jes Sorensen 638847c94b staging: rtl8723au: Eliminate ODM_CMNINFO_POWER_SAVING usage
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-07-21 12:09:27 -07:00
Jes Sorensen 1a573d2bbe staging: rtl8723au: Eliminate ODM_CMNINFO_SCAN related code
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-07-21 12:09:27 -07:00
Jes Sorensen ac6c69d311 staging: rtl8723au: Eliminate ODM_CMNINFO_CHNL usage
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-07-21 12:09:27 -07:00
Jes Sorensen 301fc630ef staging: rtl8723au: Eliminate ODM_CMNINFO_BW usage
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-07-21 12:09:27 -07:00
Jes Sorensen 91a2916a82 staging: rtl8723au: Eliminate ugly ODM_CMNINFO_SEC_CHNL_OFFSET usage
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-07-21 12:09:27 -07:00
Jes Sorensen ec8884fb20 staging: rtl8723au: ODM_DMWatchdog23a(): Take a struct hal_data_8723a *
This will allow us to access variables in the hal_data struct
directly, and get rid of the horrendous ODM_CMNINFO spaghetti API.

Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-07-21 12:09:27 -07:00
Jes Sorensen 09b052a909 staging: rtl8723au: We don't need two APIs to set pHalData->odmpriv.SupportAbility
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-07-21 12:09:27 -07:00
Jes Sorensen 42f9f19ef5 staging: rtl8723au: Remove another pile of awful unused ODM variables
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-07-21 12:09:26 -07:00
Jes Sorensen c5f3dc2fef staging: rtl8723au: Remove another pile of useless ODM variables
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-07-21 12:09:26 -07:00
Jes Sorensen c17a426556 staging: rtl8723au: Remove useless ODM_CMNINFO_{WM_MODE, BAND} related code
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-07-21 12:09:26 -07:00
Jes Sorensen 65064399c2 staging: rtl8723au: Remove ODM_CMNINFO_[RT]X_UNI and related code
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-07-21 12:09:26 -07:00
Jes Sorensen 353cb50dc7 staging: rtl8723au: Remove write-only variables struct dm_priv->{Init,}DMFlag
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-07-21 12:09:26 -07:00
Jes Sorensen a0a88236a3 staging: rtl8723au: Remove write-only struct dm_priv->DM_Type variable
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-07-21 12:09:26 -07:00
Jes Sorensen 45555706d2 staging: rtl8723au: Remove no-op function dm_CheckStatistics()
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-07-21 12:09:26 -07:00
Jes Sorensen 71cd6f54dc staging: rtl8723au: Remove no-op rtl8723a_deinit_dm_priv()
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-07-21 12:09:26 -07:00
Jes Sorensen c7abd87493 staging: rtl8723au: Remove some redundant check for hw_init_completed
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-07-21 12:09:26 -07:00
Jes Sorensen 22965e3937 staging: rtl8723au: Remove unused DefaultInitialGain array
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-07-21 12:09:26 -07:00
Jes Sorensen 3f22aed843 staging: rtl8723au: bDMInitialGainEnable is always true
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-07-21 12:09:26 -07:00
Jes Sorensen 4d1def6b5c staging: rtl8723au: Declare odm_EdcaTurbo*() functions static
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-07-21 12:09:26 -07:00
Jes Sorensen 9ea3b82630 staging: rtl8723au: Fold odm_EdcaTurboCheck23aCE23a() into odm_EdcaTurboCheck23a()
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-07-21 12:09:25 -07:00
Jes Sorensen 2e8d47e039 staging: rtl8723au: Remove pointless IS_STA_VALID() macro
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-07-17 17:54:08 -07:00
Jes Sorensen bc919b0e59 staging: rtl8723au: Remove unused odm_RegDefine11AC.h
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-07-17 17:54:08 -07:00
Jes Sorensen 344af82c94 staging: rtl8723au: ODM_IC_11N_SERIES is always true for SupportICType
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-07-17 17:54:08 -07:00
Jes Sorensen b3ee999e0b staging: rtl8723au: rtl8723a_InitBeaconParameters(): Remove unused variable
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-07-17 17:54:08 -07:00
Jes Sorensen 2a3bc8aa4f staging: rtl8723au: Use proper name REG_CAMCMD and remove wrapper invalidate_cam_all23a()
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-07-17 17:54:08 -07:00
Jes Sorensen e4d480b012 staging: rtl8723au: Remove RegBcnCtrlVal
The value saved in RegBcnCtrlVal was never used. In addition the code
was highly endian broken, declaring it as a u32, then accessing it via
a u8 * later.

Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-07-17 17:54:08 -07:00
Jes Sorensen a2c379ce26 staging: rtl8723au: Remove no-op _InitOperation_mode() function
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-07-17 17:54:08 -07:00
Jes Sorensen 120036acec staging: rtl8723au: Remove no-op usb_AggSetting*()
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-07-17 17:54:08 -07:00
Jes Sorensen ef03600cae staging: rtl8723au: Remove write-only variable UsbRxHighSpeedMode
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-07-17 17:54:08 -07:00
Raphael Silva 1d69fe84f3 staging: rtl8723au: Corrections in the coding style
Some corrections were made to the code in order to conform to the
Kernel Coding Style.

Jes: Fix build problem

Signed-off-by: Raphael Silva <rapphil@gmail.com>
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-07-17 17:54:08 -07:00