Commit Graph

633424 Commits

Author SHA1 Message Date
Harman Kalra 5e5a1138ff Staging: i4l: icn: Fixed open brace should be on previous line error
This patch resolves the following error caught by checkpatch.pl:
ERROR: that open brace { should be on the previous line

Signed-off-by: Harman Kalra <harman4linux@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-10-16 10:26:00 +02:00
Harman Kalra bdb2a2ff2c Staging: i4l: icn: prefer pr_* instead of printk
This patch replaces call to  printk with  appropriate pr_*
function thus addressing the following warning generated by the
checkpatch script:
Prefer [subsystem eg: netdev]_dbg([subsystem]dev, ... then
        dev_dbg(dev, ... then pr_debug(...  to printk(KERN_DEBUG ...

Signed-off-by: Harman Kalra <harman4linux@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-10-16 10:25:59 +02:00
Harman Kalra db0e8e5732 Staging: i4l: icn: Fixed open brace should be on previous line error
This patch resolves the following error caught by checkpatch.pl:
ERROR: that open brace { should be on the previous line

Signed-off-by: Harman Kalra <harman4linux@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-10-16 10:25:58 +02:00
Philippe Reynes f7417a5510 staging: net: netlogic: use new api ethtool_{get|set}_link_ksettings
The ethtool api {get|set}_settings is deprecated.
We move this driver to new api {get|set}_link_ksettings.

Signed-off-by: Philippe Reynes <tremyfr@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-10-16 10:25:57 +02:00
Sergio Paracuellos d2337a50eb staging: wlan-ng: fix block comments style in prism2mgmt.h
This patch fixes the following checkpatch.pl warning in prism2mgmt.h
Block comments should align the * on each line

Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-10-16 10:25:56 +02:00
Sergio Paracuellos 1d715f7ec4 staging: wlan-ng: fix block comments style in p80211req.h
This patch fixes the following checkpatch.pl warning in p80211req.h
Block comments should align the * on each line

Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-10-16 10:25:55 +02:00
Sergio Paracuellos 406c39141a staging: wlan-ng: fix block comments style in p80211netdev.h
This patch fixes the following checkpatch.pl warning in p80211netdev.h
Block comments should align the * on each line

Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-10-16 10:25:54 +02:00
Sergio Paracuellos ea0ebda761 staging: wlan-ng: fix block comments style in p80211msg.h
This patch fixes the following checkpatch.pl warning in p80211msg.h
Block comments should align the * on each line

Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-10-16 10:25:53 +02:00
Sergio Paracuellos 6b168f0b5d staging: wlan-ng: fix block comments style in p80211mgmt.h
This patch fixes the following checkpatch.pl warning in p80211mgmt.h:
 Block comments should align the * on each line

Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-10-16 10:25:52 +02:00
Sergio Paracuellos f09fd9bcf6 staging: wlan-ng: fix block comments style in p80211metadef.h
This patch fixes the following checkpatch.pl warning in p80211metadef.h
Block comments should align the * on each line

Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-10-16 10:25:52 +02:00
Sergio Paracuellos 813ea669c3 staging: wlan-ng: fix block comments style in p80211ioctl.h
This patch fixes the following checkpatch.pl warning in p80211ioctl.h
Block comments should align the * on each line

Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-10-16 10:25:50 +02:00
Sergio Paracuellos ed2e0f8394 staging: wlan-ng: fix block comments style in p80211hdr.h
This patch fixes the following checkpatch.pl warning in p80211hdr.h:
Block comments should align the * on each line

Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-10-16 10:25:50 +02:00
Sergio Paracuellos 3ae3a74736 staging: wlan-ng: fix block comments style in p80211conv.h
This patch fixes the following checkpatch.pl warning in p80211conv.h:
Block comments should align the * on each line

Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-10-16 10:25:49 +02:00
Sabitha George 4ba165e76b staging: ks7010: use netdev_* instead of printk()
1. Fixes checkpatch warning on printk usage in ks_hostif.c
2. Dropped "ks_wlan" prefix from the messages
3. Removed the "Memory squeeze,dropping packet" messages

Signed-off-by: Sabitha George <sabitha.george@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-10-16 10:25:48 +02:00
Akshay Mariyanna 71a476e48d staging: ks7010: fix space related style issues in ks7010_sdio.c
This fixes the following checkpatch warnings:
WARNING: Unnecessary space before function pointer arguments
WARNING: unnecessary whitespace before a quoted newline

Signed-off-by: Akshay Mariyanna <akmlkcc@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-10-16 10:25:47 +02:00
Akshay Mariyanna 4fdaa0d700 staging: ks7010: fix indent style in ks7010_sdio.c
This patch fixes the following checkpatch error:
ERROR: code indent should use tabs where possible

Signed-off-by: Akshay Mariyanna <akmlkcc@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-10-16 10:25:46 +02:00
Sergio Paracuellos cfea8abf67 staging: wlan-ng: get memory from kernel allocators instead of big static buffer
This patch fix the following sparse warnings in prism2fw.c:
warning: memset with byte count of 120000

Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-10-16 10:25:45 +02:00
Sergio Paracuellos 173bf7e37f staging: wlan-ng: avoid new typedef CTLX_STATE
This patch fixes the following checkpatch.pl warning in hfa384x.h:
WARNING: do not add new typedefs

It applies for typedef CTLX_STATE

Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-10-16 10:25:44 +02:00
Sergio Paracuellos 33630b0018 staging: wlan-ng: fix block comment warnings in prism2fw.c
This patch fix the following checkpatch.pl warnings in prism2fw.c

WARNING: Block comments should align the * on each line
WARNING: Block comments use a trailing */ on a separate line
Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-10-16 10:25:43 +02:00
Sergio Paracuellos 258ffd7bf1 staging: wlan-ng: fix block comment warnings in prism2sta.c
This patch fix the following checkpatch.pl warnings in prism2sta.c:
WARNING: Block comments should align the * on each line

Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-10-16 10:25:42 +02:00
Sergio Paracuellos 96da9e6436 staging: wlan-ng: fix block comment warnings in prism2mib.c
This patch fix the following checkpatch.pl warnings in prism2mib.c:
WARNING: Block comments should align the * on each line

Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-10-16 10:25:41 +02:00
Sergio Paracuellos 01fe9c92df staging: wlan-ng: fix block comment warnings in prism2mgmt.c
This patch fix the following checkpatch.pl warnings in prism2mgmt.c:
WARNING: Block comments should align the * on each line
WARNING: Block comments use a trailing */ on a separate line

Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-10-16 10:25:40 +02:00
Sergio Paracuellos 87f26d08cf staging: wlan-ng: fix line style warnings in p80211wep.c
This patch fix the following checkpatch.pl warnings in p80211wep.c:
WARNING: line over 80 characters

Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-10-16 10:25:39 +02:00
Sergio Paracuellos 17d954823d staging: wlan-ng: fix block comment warnings in p80211wep.c
This patch fix the following checkpatch.pl warnings in p80211wep.c:
WARNING: Block comments should align the * on each line

Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-10-16 10:25:38 +02:00
Sergio Paracuellos c97efa34f4 staging: wlan-ng: fix line style warnings in p80211req.c
This patch fix the following checkpatch.pl warnings in p80211req.c:
WARNING: line over 80 characters

Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-10-16 10:25:37 +02:00
Sergio Paracuellos 3aa4ecf785 staging: wlan-ng: fix block comment warnings in p80211req.c
This patch fix the following checkpatch.pl warnings in p80211req.c:
WARNING: Block comments should align the * on each line
WARNING: Block comments use a trailing */ on a separate line

Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-10-16 10:25:36 +02:00
Sergio Paracuellos 4d43b7916b staging: wlan-ng: do not return -ENOSYS
Fixed coding style issue by replacing ENOSYS with EINVAL.

This patch fix the following checkpatch.pl warnings in p80211netdev.c:
WARNING: ENOSYS means 'invalid syscall nr' and nothing else

Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-10-16 10:25:36 +02:00
Sergio Paracuellos 84ad1efa7d staging: wlan-ng: fix block comment warnings in p80211netdev.c
This patch fix the following checkpatch.pl warnings in p80211netdev.c:
WARNING: Block comments should align the * on each line
WARNING: Block comments use a trailing */ on a separate line

Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-10-16 10:25:35 +02:00
Sergio Paracuellos 0a6b83e553 staging: wlan-ng: fix line style warnings in p80211netdev.c
This patch fix the following checkpatch.pl warnings in p80211netdev.c:
WARNING: line over 80 characters

Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-10-16 10:25:35 +02:00
Sergio Paracuellos b1a57426d0 staging: wlan-ng: fix block comment warnings in p80211conv.c
This patch fix the following checkpatch.pl warnings in p80211conv.c:
WARNING: Block comments should align the * on each line

Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-10-16 10:25:34 +02:00
Sergio Paracuellos d3fcb8a276 staging: wlan-ng: fix block comment warnings in hfa384x_usb.c
This patch fix the following checkpatch.pl warnings in hfa384x_usb.c:
 WARNING: Block comments should align the * on each line
 WARNING: Block comments use a trailing */ on a separate line

Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-10-16 10:25:33 +02:00
Sergio Paracuellos 5a919c7887 staging: wlan-ng: fix line style warnings in hfa384x_usb.c
This patch fix the following checkpatch.pl warnings in hfa384x_usb.c:
WARNING: line over 80 characters

Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-10-16 10:25:32 +02:00
Ivan Safonov f346d62f33 staging:r8188eu: remove unnecessary type cast for update_recvframe_phyinfo_88e argument
pphy_status alreay is (struct phy_stat *).

Signed-off-by: Ivan Safonov <insafonov@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-10-16 10:25:32 +02:00
Ivan Safonov cd30a39249 staging:r8188eu: refactor recvbuf2recvframe function
Reduce number of nesting levels.

Signed-off-by: Ivan Safonov <insafonov@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-10-16 10:25:31 +02:00
Ivan Safonov 165601c98f staging:r8188eu: change poiter type from u8 to void for pallocated_frame_buf member of recv_priv structure
pallocated_frame_buf used only to preserve pointer for vfree function.

Signed-off-by: Ivan Safonov <insafonov@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-10-16 10:25:30 +02:00
Ivan Safonov d70c509152 staging:r8188eu: remove precv_frame_buf member of recv_priv structure
precv_frame_buf is used as local variable only in one function.

Signed-off-by: Ivan Safonov <insafonov@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-10-16 10:25:30 +02:00
Ivan Safonov d7689c821d staging:r8188eu: remove rx_pending_cnt member of recv_priv structure
Value of this variable does not used.

Signed-off-by: Ivan Safonov <insafonov@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-10-16 10:25:29 +02:00
Ivan Safonov 437a7b6e11 staging:r8188eu: remove free_recvframe_cnt member of recv_priv structure
Value of free_recvframe_cnt does not used.

Signed-off-by: Ivan Safonov <insafonov@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-10-16 10:25:29 +02:00
Ivan Safonov fd5d86d2f3 staging:r8188eu: remove intf_stop member of adapter structure
call usb_intf_stop directly.

Signed-off-by: Ivan Safonov <insafonov@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-10-16 10:25:28 +02:00
Ivan Safonov 94b6a662c3 staging:r8188eu: remove pallocated_recv_buf member of the recv_priv structure
recv_priv used instead.
recv_priv does not changed after assigning
and it can be used as kfree argument

Signed-off-by: Ivan Safonov <insafonov@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-10-16 10:25:28 +02:00
Ivan Safonov 63764c7fb6 staging:r8188eu: change type of the precv_buf member of recv_priv structure
To avoid unnecessary typecast.
To use compiler type checking.

Signed-off-by: Ivan Safonov <insafonov@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-10-16 10:25:27 +02:00
Ivan Safonov aaa27e8c4a staging:r8188eu: remove prhdr local variable from rtw_free_stainfo function
This variable is unnecessary.

Signed-off-by: Ivan Safonov <insafonov@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-10-16 10:25:27 +02:00
Ivan Safonov 175fa9a7a8 staging:r8188eu: remove unused function declerations
rtl8188eu_recv_hdl and rtl8188e_query_rx_phy_status doesn't used.

Signed-off-by: Ivan Safonov <insafonov@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-10-16 10:25:26 +02:00
Ivan Safonov 5cd3879757 staging:r8188eu: remove padapter and free_sz arguments of rtw_os_xmit_resource_free function
These argumets does not used by rtw_os_xmit_resource_free function.

Signed-off-by: Ivan Safonov <insafonov@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-10-16 10:25:26 +02:00
Ivan Safonov 9c05491190 staging:r8188eu: remove rtw_endofpktfile function
rtw_endofpktfile is one-line function.

Signed-off-by: Ivan Safonov <insafonov@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-10-16 10:25:25 +02:00
Ivan Safonov 5e88cae5dc staging:r8188eu: remove ANTTEST(ALL|A|B) definitions
These defintions does not used.

Signed-off-by: Ivan Safonov <insafonov@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-10-16 10:25:25 +02:00
Ivan Safonov 660d7afff7 staging:r8188eu: remove bTXPowerTrackingInit member of odm_rf_cal structure
bTXPowerTrackingInit assigned, but not used.

Signed-off-by: Ivan Safonov <insafonov@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-10-16 10:25:24 +02:00
Ivan Safonov 85a7dc225d staging:r8188eu: refactor rtl88eu_dm_txpower_tracking_callback_thermalmeter function
Remove is2t and rf local variables from this function.

Signed-off-by: Ivan Safonov <insafonov@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-10-16 10:25:24 +02:00
Ivan Safonov b39db0b160 staging:r8188eu: remove NumTotalRFPath member of hal_data_8188e structure
NumTotalRFPath is 1 for r8188eu chip.

Signed-off-by: Ivan Safonov <insafonov@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-10-16 10:25:23 +02:00
Ivan Safonov 76fe8b32b4 staging:r8188eu: remove RF_TYPE_8190P enumeration
This enumeration does not used.

Signed-off-by: Ivan Safonov <insafonov@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-10-16 10:25:23 +02:00