crypto: algapi - make crypto_drop_spawn() a no-op on uninitialized spawns
Make crypto_drop_spawn() do nothing when the spawn hasn't been initialized with an algorithm yet. This will allow simplifying error handling in all the template ->create() functions, since on error they will be able to just call their usual "free instance" function, rather than having to handle dropping just the spawns that have been initialized so far. This does assume the spawn starts out zero-filled, but that's always the case since instances are allocated with kzalloc(). And some other code already assumes this anyway. Signed-off-by: Eric Biggers <ebiggers@google.com> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
This commit is contained in:
parent
e91e785e18
commit
ff67062796
|
@ -734,6 +734,9 @@ EXPORT_SYMBOL_GPL(crypto_grab_spawn);
|
|||
|
||||
void crypto_drop_spawn(struct crypto_spawn *spawn)
|
||||
{
|
||||
if (!spawn->alg) /* not yet initialized? */
|
||||
return;
|
||||
|
||||
down_write(&crypto_alg_sem);
|
||||
if (!spawn->dead)
|
||||
list_del(&spawn->list);
|
||||
|
|
Loading…
Reference in New Issue