hollalinux
/
linux-sg2042
mirror of https://github.com/sophgo/linux-riscv.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

clk: Re-use DEFINE_SHOW_ATTRIBUTE() macro 

...instead of open coding file operations followed by custom ->open()
callbacks per each attribute.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: Stephen Boyd <sboyd@kernel.org>
This commit is contained in:
Andy Shevchenko 2018-02-14 17:48:00 +02:00 committed by Stephen Boyd
parent 7928b2cbe5
commit fec0ef3f52
1 changed files with 7 additions and 53 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

60
drivers/clk/clk.c
View File

@ -2486,19 +2486,7 @@ static int clk_summary_show(struct seq_file *s, void *data)
return 0; return 0;
} }
DEFINE_SHOW_ATTRIBUTE(clk_summary);
static int clk_summary_open(struct inode *inode, struct file *file)
{
return single_open(file, clk_summary_show, inode->i_private);
}
static const struct file_operations clk_summary_fops = {
.open = clk_summary_open,
.read = seq_read,
.llseek = seq_lseek,
.release = single_release,
};
static void clk_dump_one(struct seq_file *s, struct clk_core *c, int level) static void clk_dump_one(struct seq_file *s, struct clk_core *c, int level)
{ {
@ -2532,7 +2520,7 @@ static void clk_dump_subtree(struct seq_file *s, struct clk_core *c, int level)
seq_putc(s, '}'); seq_putc(s, '}');
} }
static int clk_dump(struct seq_file *s, void *data) static int clk_dump_show(struct seq_file *s, void *data)
{ {
struct clk_core *c; struct clk_core *c;
bool first_node = true; bool first_node = true;
@ -2555,19 +2543,7 @@ static int clk_dump(struct seq_file *s, void *data)
seq_puts(s, "}\n"); seq_puts(s, "}\n");
return 0; return 0;
} }
DEFINE_SHOW_ATTRIBUTE(clk_dump);
static int clk_dump_open(struct inode *inode, struct file *file)
{
return single_open(file, clk_dump, inode->i_private);
}
static const struct file_operations clk_dump_fops = {
.open = clk_dump_open,
.read = seq_read,
.llseek = seq_lseek,
.release = single_release,
};
static const struct { static const struct {
unsigned long flag; unsigned long flag;
@ -2589,7 +2565,7 @@ static const struct {
#undef ENTRY #undef ENTRY
}; };
static int clk_flags_dump(struct seq_file *s, void *data) static int clk_flags_show(struct seq_file *s, void *data)
{ {
struct clk_core *core = s->private; struct clk_core *core = s->private;
unsigned long flags = core->flags; unsigned long flags = core->flags;
@ -2608,20 +2584,9 @@ static int clk_flags_dump(struct seq_file *s, void *data)
return 0; return 0;
} }
DEFINE_SHOW_ATTRIBUTE(clk_flags);
static int clk_flags_open(struct inode *inode, struct file *file) static int possible_parents_show(struct seq_file *s, void *data)
{
return single_open(file, clk_flags_dump, inode->i_private);
}
static const struct file_operations clk_flags_fops = {
.open = clk_flags_open,
.read = seq_read,
.llseek = seq_lseek,
.release = single_release,
};
static int possible_parents_dump(struct seq_file *s, void *data)
{ {
struct clk_core *core = s->private; struct clk_core *core = s->private;
int i; int i;
@ -2633,18 +2598,7 @@ static int possible_parents_dump(struct seq_file *s, void *data)
return 0; return 0;
} }
DEFINE_SHOW_ATTRIBUTE(possible_parents);
static int possible_parents_open(struct inode *inode, struct file *file)
{
return single_open(file, possible_parents_dump, inode->i_private);
}
static const struct file_operations possible_parents_fops = {
.open = possible_parents_open,
.read = seq_read,
.llseek = seq_lseek,
.release = single_release,
};
static int clk_debug_create_one(struct clk_core *core, struct dentry *pdentry) static int clk_debug_create_one(struct clk_core *core, struct dentry *pdentry)
{ {