irqchip/versatile: Consolidate chained IRQ handler install/remove
Chained irq handlers usually set up handler data as well. We now have a function to set both under irq_desc->lock. Replace the two calls with one. Search and conversion was done with coccinelle: @@ expression E1, E2, E3; @@ ( -if (irq_set_handler_data(E1, E2) != 0) - BUG(); | -irq_set_handler_data(E1, E2); ) -irq_set_chained_handler(E1, E3); +irq_set_chained_handler_and_data(E1, E3, E2); @@ expression E1, E2, E3; @@ ( -if (irq_set_handler_data(E1, E2) != 0) - BUG(); ... | -irq_set_handler_data(E1, E2); ... ) -irq_set_chained_handler(E1, E3); +irq_set_chained_handler_and_data(E1, E3, E2); Reported-by: Russell King <rmk+kernel@arm.linux.org.uk> Signed-off-by: Thomas Gleixner <tglx@linutronix.de> Cc: Julia Lawall <Julia.Lawall@lip6.fr> Cc: Thomas Gleixner <tglx@linutronix.de> Cc: Jason Cooper <jason@lakedaemon.net>
This commit is contained in:
parent
22890b0dbe
commit
fcd3c5bee1
|
@ -155,8 +155,8 @@ void __init fpga_irq_init(void __iomem *base, const char *name, int irq_start,
|
||||||
f->valid = valid;
|
f->valid = valid;
|
||||||
|
|
||||||
if (parent_irq != -1) {
|
if (parent_irq != -1) {
|
||||||
irq_set_handler_data(parent_irq, f);
|
irq_set_chained_handler_and_data(parent_irq, fpga_irq_handle,
|
||||||
irq_set_chained_handler(parent_irq, fpga_irq_handle);
|
f);
|
||||||
}
|
}
|
||||||
|
|
||||||
/* This will also allocate irq descriptors */
|
/* This will also allocate irq descriptors */
|
||||||
|
|
Loading…
Reference in New Issue