scsi: ufs: remove unnecessary goto label
When buff_ascii kmalloc failed, there is no need to call kfree, it should return -ENOMEM directly, this patch fixes it. Signed-off-by: Tiezhu Yang <kernelpatch@126.com> Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
This commit is contained in:
parent
3fb134cb4c
commit
fcbefc3b2b
|
@ -2137,7 +2137,7 @@ int ufshcd_read_string_desc(struct ufs_hba *hba, int desc_index, u8 *buf,
|
||||||
buff_ascii = kmalloc(ascii_len, GFP_KERNEL);
|
buff_ascii = kmalloc(ascii_len, GFP_KERNEL);
|
||||||
if (!buff_ascii) {
|
if (!buff_ascii) {
|
||||||
err = -ENOMEM;
|
err = -ENOMEM;
|
||||||
goto out_free_buff;
|
goto out;
|
||||||
}
|
}
|
||||||
|
|
||||||
/*
|
/*
|
||||||
|
@ -2156,7 +2156,6 @@ int ufshcd_read_string_desc(struct ufs_hba *hba, int desc_index, u8 *buf,
|
||||||
size - QUERY_DESC_HDR_SIZE);
|
size - QUERY_DESC_HDR_SIZE);
|
||||||
memcpy(buf + QUERY_DESC_HDR_SIZE, buff_ascii, ascii_len);
|
memcpy(buf + QUERY_DESC_HDR_SIZE, buff_ascii, ascii_len);
|
||||||
buf[QUERY_DESC_LENGTH_OFFSET] = ascii_len + QUERY_DESC_HDR_SIZE;
|
buf[QUERY_DESC_LENGTH_OFFSET] = ascii_len + QUERY_DESC_HDR_SIZE;
|
||||||
out_free_buff:
|
|
||||||
kfree(buff_ascii);
|
kfree(buff_ascii);
|
||||||
}
|
}
|
||||||
out:
|
out:
|
||||||
|
|
Loading…
Reference in New Issue