hollalinux
/
linux-sg2042
mirror of https://github.com/sophgo/linux-riscv.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

vmxnet3: locking problems in xmit 

There were several paths that didn't release their locks.

Signed-off-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: Bhavesh Davda <bhavesh@vmware.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Dan Carpenter 2010-12-20 03:03:15 +00:00 committed by David S. Miller
parent 6561a3b12d
commit f955e1415f
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/net/vmxnet3/vmxnet3_drv.c
View File

@ -980,7 +980,7 @@ vmxnet3_tq_xmit(struct sk_buff *skb, struct vmxnet3_tx_queue *tq,
} }
} else { } else {
tq->stats.drop_hdr_inspect_err++; tq->stats.drop_hdr_inspect_err++;
goto drop_pkt; goto unlock_drop_pkt;
} }
/* fill tx descs related to addr & len */ /* fill tx descs related to addr & len */
@ -1052,6 +1052,8 @@ vmxnet3_tq_xmit(struct sk_buff *skb, struct vmxnet3_tx_queue *tq,
hdr_too_big: hdr_too_big:
tq->stats.drop_oversized_hdr++; tq->stats.drop_oversized_hdr++;
unlock_drop_pkt:
spin_unlock_irqrestore(&tq->tx_lock, flags);
drop_pkt: drop_pkt:
tq->stats.drop_total++; tq->stats.drop_total++;
dev_kfree_skb(skb); dev_kfree_skb(skb);