net: bridge: check the length of skb after nf_bridge_maybe_copy_header()

Since nf_bridge_maybe_copy_header() may change the length of skb,
we should check the length of skb after it to handle the ppoe skbs.

Signed-off-by: Changli Gao <xiaosuo@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Changli Gao 2010-12-25 03:41:30 +00:00 committed by David S. Miller
parent 38cfb907a5
commit f88de8de5a
1 changed files with 6 additions and 10 deletions

View File

@ -41,17 +41,13 @@ static inline unsigned packet_length(const struct sk_buff *skb)
int br_dev_queue_push_xmit(struct sk_buff *skb) int br_dev_queue_push_xmit(struct sk_buff *skb)
{ {
/* drop mtu oversized packets except gso */ /* ip_fragment doesn't copy the MAC header */
if (packet_length(skb) > skb->dev->mtu && !skb_is_gso(skb)) if (nf_bridge_maybe_copy_header(skb) ||
(packet_length(skb) > skb->dev->mtu && !skb_is_gso(skb))) {
kfree_skb(skb); kfree_skb(skb);
else { } else {
/* ip_fragment doesn't copy the MAC header */ skb_push(skb, ETH_HLEN);
if (nf_bridge_maybe_copy_header(skb)) dev_queue_xmit(skb);
kfree_skb(skb);
else {
skb_push(skb, ETH_HLEN);
dev_queue_xmit(skb);
}
} }
return 0; return 0;