staging: ft1000: remove assigments of ret and initialise it in beginning
as ret is every time assigned to EINVAL in fail cases, initialise it at the beginning. Signed-off-by: Devendra Naga <devendra.aaru@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
parent
64bce09563
commit
f884c19224
|
@ -205,7 +205,7 @@ int ft1000_init_proc(struct net_device *dev)
|
||||||
{
|
{
|
||||||
struct ft1000_info *info;
|
struct ft1000_info *info;
|
||||||
struct proc_dir_entry *ft1000_proc_file;
|
struct proc_dir_entry *ft1000_proc_file;
|
||||||
int ret = 0;
|
int ret = -EINVAL;
|
||||||
|
|
||||||
info = netdev_priv(dev);
|
info = netdev_priv(dev);
|
||||||
|
|
||||||
|
@ -213,7 +213,6 @@ int ft1000_init_proc(struct net_device *dev)
|
||||||
if (info->ft1000_proc_dir == NULL) {
|
if (info->ft1000_proc_dir == NULL) {
|
||||||
printk(KERN_WARNING "Unable to create %s dir.\n",
|
printk(KERN_WARNING "Unable to create %s dir.\n",
|
||||||
FT1000_PROC_DIR);
|
FT1000_PROC_DIR);
|
||||||
ret = -EINVAL;
|
|
||||||
goto fail;
|
goto fail;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
@ -223,7 +222,6 @@ int ft1000_init_proc(struct net_device *dev)
|
||||||
|
|
||||||
if (ft1000_proc_file == NULL) {
|
if (ft1000_proc_file == NULL) {
|
||||||
printk(KERN_WARNING "Unable to create /proc entry.\n");
|
printk(KERN_WARNING "Unable to create /proc entry.\n");
|
||||||
ret = -EINVAL;
|
|
||||||
goto fail_entry;
|
goto fail_entry;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|
Loading…
Reference in New Issue