hollalinux
/
linux-sg2042
mirror of https://github.com/sophgo/linux-riscv.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

fpga: stratix10-soc: fix use-after-free on s10_init() 

The refcount of fw_np has already been decreased by of_find_matching_node()
so it shouldn't be used anymore.
This patch adds an of_node_get() before of_find_matching_node() to avoid
the use-after-free problem.

Fixes: e7eef1d763 ("fpga: add intel stratix10 soc fpga manager driver")
Signed-off-by: Wen Yang <wen.yang99@zte.com.cn>
Cc: Alan Tull <atull@kernel.org>
Cc: Moritz Fischer <mdf@kernel.org>
Cc: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
Cc: linux-fpga@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Reviewed-by: Moritz Fischer <mdf@kernel.org>
Reviewed-by: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
Acked-by: Alan Tull <atull@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Wen Yang 2019-05-09 16:08:26 -05:00 committed by Greg Kroah-Hartman
parent 02bd610e85
commit f5dd87326f
1 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
drivers/fpga/stratix10-soc.c
View File

@ -507,12 +507,16 @@ static int __init s10_init(void)
if (!fw_np) if (!fw_np)
return -ENODEV; return -ENODEV;
of_node_get(fw_np);
np = of_find_matching_node(fw_np, s10_of_match); np = of_find_matching_node(fw_np, s10_of_match);
if (!np) if (!np) {
of_node_put(fw_np);
return -ENODEV; return -ENODEV;
}
of_node_put(np); of_node_put(np);
ret = of_platform_populate(fw_np, s10_of_match, NULL, NULL); ret = of_platform_populate(fw_np, s10_of_match, NULL, NULL);
of_node_put(fw_np);
if (ret) if (ret)
return ret; return ret;