hollalinux
/
linux-sg2042
mirror of https://github.com/sophgo/linux-riscv.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

ASoC: rsnd: don't use schedule_work() when rsnd_dma_start() 

rsnd_dma_start() is the function to start DMAEngine.
Current code is using schedule_work() for it,
but it breaks DMAC/SSI register setting timing.
Don't use schedule_work() on it.

Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Signed-off-by: Mark Brown <broonie@linaro.org>
This commit is contained in:
Kuninori Morimoto 2014-01-23 18:40:27 -08:00 committed by Mark Brown
parent 64de62b386
commit f5cab3b897
1 changed files with 10 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
sound/soc/sh/rcar/core.c
View File

@ -132,6 +132,7 @@ void rsnd_mod_init(struct rsnd_priv *priv,
/* /*
* rsnd_dma functions * rsnd_dma functions
*/ */
static void __rsnd_dma_start(struct rsnd_dma *dma);
static void rsnd_dma_continue(struct rsnd_dma *dma) static void rsnd_dma_continue(struct rsnd_dma *dma)
{ {
/* push next A or B plane */ /* push next A or B plane */
@ -143,7 +144,7 @@ void rsnd_dma_start(struct rsnd_dma *dma)
{ {
/* push both A and B plane*/ /* push both A and B plane*/
dma->submit_loop = 2; dma->submit_loop = 2;
schedule_work(&dma->work); __rsnd_dma_start(dma);
} }
void rsnd_dma_stop(struct rsnd_dma *dma) void rsnd_dma_stop(struct rsnd_dma *dma)
@ -169,9 +170,8 @@ static void rsnd_dma_complete(void *data)
rsnd_unlock(priv, flags); rsnd_unlock(priv, flags);
} }
static void rsnd_dma_do_work(struct work_struct *work) static void __rsnd_dma_start(struct rsnd_dma *dma)
{ {
struct rsnd_dma *dma = container_of(work, struct rsnd_dma, work);
struct rsnd_priv *priv = rsnd_mod_to_priv(rsnd_dma_to_mod(dma)); struct rsnd_priv *priv = rsnd_mod_to_priv(rsnd_dma_to_mod(dma));
struct device *dev = rsnd_priv_to_dev(priv); struct device *dev = rsnd_priv_to_dev(priv);
struct dma_async_tx_descriptor *desc; struct dma_async_tx_descriptor *desc;
@ -204,6 +204,13 @@ static void rsnd_dma_do_work(struct work_struct *work)
} }
} }
static void rsnd_dma_do_work(struct work_struct *work)
{
struct rsnd_dma *dma = container_of(work, struct rsnd_dma, work);
__rsnd_dma_start(dma);
}
int rsnd_dma_available(struct rsnd_dma *dma) int rsnd_dma_available(struct rsnd_dma *dma)
{ {
return !!dma->chan; return !!dma->chan;