ethtool: Use noinline_for_stack
Use self documenting noinline_for_stack instead of duplicated comments. Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com> Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
parent
81160e66cc
commit
f5c445ed41
|
@ -200,10 +200,7 @@ static int ethtool_set_settings(struct net_device *dev, void __user *useraddr)
|
|||
return dev->ethtool_ops->set_settings(dev, &cmd);
|
||||
}
|
||||
|
||||
/*
|
||||
* noinline attribute so that gcc doesnt use too much stack in dev_ethtool()
|
||||
*/
|
||||
static noinline int ethtool_get_drvinfo(struct net_device *dev, void __user *useraddr)
|
||||
static noinline_for_stack int ethtool_get_drvinfo(struct net_device *dev, void __user *useraddr)
|
||||
{
|
||||
struct ethtool_drvinfo info;
|
||||
const struct ethtool_ops *ops = dev->ethtool_ops;
|
||||
|
@ -242,10 +239,7 @@ static noinline int ethtool_get_drvinfo(struct net_device *dev, void __user *use
|
|||
return 0;
|
||||
}
|
||||
|
||||
/*
|
||||
* noinline attribute so that gcc doesnt use too much stack in dev_ethtool()
|
||||
*/
|
||||
static noinline int ethtool_get_sset_info(struct net_device *dev,
|
||||
static noinline_for_stack int ethtool_get_sset_info(struct net_device *dev,
|
||||
void __user *useraddr)
|
||||
{
|
||||
struct ethtool_sset_info info;
|
||||
|
@ -305,10 +299,7 @@ out:
|
|||
return ret;
|
||||
}
|
||||
|
||||
/*
|
||||
* noinline attribute so that gcc doesnt use too much stack in dev_ethtool()
|
||||
*/
|
||||
static noinline int ethtool_set_rxnfc(struct net_device *dev, void __user *useraddr)
|
||||
static noinline_for_stack int ethtool_set_rxnfc(struct net_device *dev, void __user *useraddr)
|
||||
{
|
||||
struct ethtool_rxnfc cmd;
|
||||
|
||||
|
@ -321,10 +312,7 @@ static noinline int ethtool_set_rxnfc(struct net_device *dev, void __user *usera
|
|||
return dev->ethtool_ops->set_rxnfc(dev, &cmd);
|
||||
}
|
||||
|
||||
/*
|
||||
* noinline attribute so that gcc doesnt use too much stack in dev_ethtool()
|
||||
*/
|
||||
static noinline int ethtool_get_rxnfc(struct net_device *dev, void __user *useraddr)
|
||||
static noinline_for_stack int ethtool_get_rxnfc(struct net_device *dev, void __user *useraddr)
|
||||
{
|
||||
struct ethtool_rxnfc info;
|
||||
const struct ethtool_ops *ops = dev->ethtool_ops;
|
||||
|
@ -396,10 +384,7 @@ static void __rx_ntuple_filter_add(struct ethtool_rx_ntuple_list *list,
|
|||
list->count++;
|
||||
}
|
||||
|
||||
/*
|
||||
* noinline attribute so that gcc doesnt use too much stack in dev_ethtool()
|
||||
*/
|
||||
static noinline int ethtool_set_rx_ntuple(struct net_device *dev, void __user *useraddr)
|
||||
static noinline_for_stack int ethtool_set_rx_ntuple(struct net_device *dev, void __user *useraddr)
|
||||
{
|
||||
struct ethtool_rx_ntuple cmd;
|
||||
const struct ethtool_ops *ops = dev->ethtool_ops;
|
||||
|
@ -867,10 +852,7 @@ static int ethtool_set_eeprom(struct net_device *dev, void __user *useraddr)
|
|||
return ret;
|
||||
}
|
||||
|
||||
/*
|
||||
* noinline attribute so that gcc doesnt use too much stack in dev_ethtool()
|
||||
*/
|
||||
static noinline int ethtool_get_coalesce(struct net_device *dev, void __user *useraddr)
|
||||
static noinline_for_stack int ethtool_get_coalesce(struct net_device *dev, void __user *useraddr)
|
||||
{
|
||||
struct ethtool_coalesce coalesce = { .cmd = ETHTOOL_GCOALESCE };
|
||||
|
||||
|
@ -884,10 +866,7 @@ static noinline int ethtool_get_coalesce(struct net_device *dev, void __user *us
|
|||
return 0;
|
||||
}
|
||||
|
||||
/*
|
||||
* noinline attribute so that gcc doesnt use too much stack in dev_ethtool()
|
||||
*/
|
||||
static noinline int ethtool_set_coalesce(struct net_device *dev, void __user *useraddr)
|
||||
static noinline_for_stack int ethtool_set_coalesce(struct net_device *dev, void __user *useraddr)
|
||||
{
|
||||
struct ethtool_coalesce coalesce;
|
||||
|
||||
|
@ -1297,10 +1276,7 @@ static int ethtool_set_value(struct net_device *dev, char __user *useraddr,
|
|||
return actor(dev, edata.data);
|
||||
}
|
||||
|
||||
/*
|
||||
* noinline attribute so that gcc doesnt use too much stack in dev_ethtool()
|
||||
*/
|
||||
static noinline int ethtool_flash_device(struct net_device *dev, char __user *useraddr)
|
||||
static noinline_for_stack int ethtool_flash_device(struct net_device *dev, char __user *useraddr)
|
||||
{
|
||||
struct ethtool_flash efl;
|
||||
|
||||
|
|
Loading…
Reference in New Issue