dm snapshot: avoid else clause in persistent_read_metadata
Minor code touch-up. We don't need the 'else'. Signed-off-by: Jonathan Brassow <jbrassow@redhat.com> Reviewed-by: Mikulas Patocka <mpatocka@redhat.com> Reviewed-by: Mike Snitzer <snitzer@redhat.com> Signed-off-by: Alasdair G Kergon <agk@redhat.com>
This commit is contained in:
parent
a518b86d0b
commit
f5acc83428
|
@ -552,35 +552,31 @@ static int persistent_read_metadata(struct dm_exception_store *store,
|
||||||
ps->current_area = 0;
|
ps->current_area = 0;
|
||||||
zero_memory_area(ps);
|
zero_memory_area(ps);
|
||||||
r = zero_disk_area(ps, 0);
|
r = zero_disk_area(ps, 0);
|
||||||
if (r) {
|
|
||||||
DMWARN("zero_disk_area(0) failed");
|
|
||||||
return r;
|
|
||||||
}
|
|
||||||
} else {
|
|
||||||
/*
|
|
||||||
* Sanity checks.
|
|
||||||
*/
|
|
||||||
if (ps->version != SNAPSHOT_DISK_VERSION) {
|
|
||||||
DMWARN("unable to handle snapshot disk version %d",
|
|
||||||
ps->version);
|
|
||||||
return -EINVAL;
|
|
||||||
}
|
|
||||||
|
|
||||||
/*
|
|
||||||
* Metadata are valid, but snapshot is invalidated
|
|
||||||
*/
|
|
||||||
if (!ps->valid)
|
|
||||||
return 1;
|
|
||||||
|
|
||||||
/*
|
|
||||||
* Read the metadata.
|
|
||||||
*/
|
|
||||||
r = read_exceptions(ps, callback, callback_context);
|
|
||||||
if (r)
|
if (r)
|
||||||
return r;
|
DMWARN("zero_disk_area(0) failed");
|
||||||
|
return r;
|
||||||
|
}
|
||||||
|
/*
|
||||||
|
* Sanity checks.
|
||||||
|
*/
|
||||||
|
if (ps->version != SNAPSHOT_DISK_VERSION) {
|
||||||
|
DMWARN("unable to handle snapshot disk version %d",
|
||||||
|
ps->version);
|
||||||
|
return -EINVAL;
|
||||||
}
|
}
|
||||||
|
|
||||||
return 0;
|
/*
|
||||||
|
* Metadata are valid, but snapshot is invalidated
|
||||||
|
*/
|
||||||
|
if (!ps->valid)
|
||||||
|
return 1;
|
||||||
|
|
||||||
|
/*
|
||||||
|
* Read the metadata.
|
||||||
|
*/
|
||||||
|
r = read_exceptions(ps, callback, callback_context);
|
||||||
|
|
||||||
|
return r;
|
||||||
}
|
}
|
||||||
|
|
||||||
static int persistent_prepare_exception(struct dm_exception_store *store,
|
static int persistent_prepare_exception(struct dm_exception_store *store,
|
||||||
|
|
Loading…
Reference in New Issue