Btrfs: optimize to remove unnecessary removal with ulist reallocation
Here we are not going to free memory, no need to remove every node one by one, just init root node here is ok. Cc: Liu Bo <bo.li.liu@oracle.com> Signed-off-by: Wang Shilong <wangsl.fnst@cn.fujitsu.com> Signed-off-by: Josef Bacik <jbacik@fb.com> Signed-off-by: Chris Mason <clm@fb.com>
This commit is contained in:
parent
de6e820066
commit
f499e40fd9
|
@ -207,9 +207,6 @@ int ulist_add_merge(struct ulist *ulist, u64 val, u64 aux,
|
||||||
void *old = NULL;
|
void *old = NULL;
|
||||||
int i;
|
int i;
|
||||||
|
|
||||||
for (i = 0; i < ulist->nnodes; i++)
|
|
||||||
rb_erase(&ulist->nodes[i].rb_node, &ulist->root);
|
|
||||||
|
|
||||||
/*
|
/*
|
||||||
* if nodes_alloced == ULIST_SIZE no memory has been allocated
|
* if nodes_alloced == ULIST_SIZE no memory has been allocated
|
||||||
* yet, so pass NULL to krealloc
|
* yet, so pass NULL to krealloc
|
||||||
|
@ -234,6 +231,7 @@ int ulist_add_merge(struct ulist *ulist, u64 val, u64 aux,
|
||||||
* pointers, so we have to do it ourselves. Otherwise we may
|
* pointers, so we have to do it ourselves. Otherwise we may
|
||||||
* be bitten by crashes.
|
* be bitten by crashes.
|
||||||
*/
|
*/
|
||||||
|
ulist->root = RB_ROOT;
|
||||||
for (i = 0; i < ulist->nnodes; i++) {
|
for (i = 0; i < ulist->nnodes; i++) {
|
||||||
ret = ulist_rbtree_insert(ulist, &ulist->nodes[i]);
|
ret = ulist_rbtree_insert(ulist, &ulist->nodes[i]);
|
||||||
if (ret < 0)
|
if (ret < 0)
|
||||||
|
|
Loading…
Reference in New Issue