hollalinux
/
linux-sg2042
mirror of https://github.com/sophgo/linux-riscv.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

fbdev: sh_mobile_hdmi: modify noisy comment out 

This patch solve below report from Guennadi

1)

> -	hdmi_write(hdmi, 0x00, HDMI_AUDIO_SETTING_1);
> +	switch (pdata->flags & HDMI_SRC_MASK) {
> +	default:
> +		/* FALL THROUGH */

I'm not sure I like the capitalisation here - no reason to shout;)

2)

> +/************************************************************************
> +
> +
> +			HDMI sound
> +
> +
> +************************************************************************/

I don't think this comment deserves 7 lines of text, besides breaking the
multiline comment style. If you think, one line like

/*			HDMI sound			*/

is not enough how about just

/*
 *			HDMI sound
 */

3)

> +/************************************************************************
> +
> +
> +			HDMI video
> +
> +
> +************************************************************************/

See above - 7 lines seem to be an overkill to me.

Reported-by: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Reviewed-by: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
Acked-by: Liam Girdwood <lrg@slimlogic.co.uk>
Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
This commit is contained in:
Kuninori Morimoto 2010-09-09 11:47:49 +09:00 committed by Mark Brown
parent 5fbdedf072
commit f4363b7d88
1 changed files with 7 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
drivers/video/sh_mobile_hdmi.c
View File

@ -224,13 +224,9 @@ static u8 hdmi_read(struct sh_hdmi *hdmi, u8 reg)
return ioread8(hdmi->base + reg); return ioread8(hdmi->base + reg);
} }
/************************************************************************ /*
* HDMI sound
*/
HDMI sound
************************************************************************/
static unsigned int sh_hdmi_snd_read(struct snd_soc_codec *codec, static unsigned int sh_hdmi_snd_read(struct snd_soc_codec *codec,
unsigned int reg) unsigned int reg)
{ {
@ -273,13 +269,10 @@ static struct snd_soc_codec_driver soc_codec_dev_sh_hdmi = {
.write = sh_hdmi_snd_write, .write = sh_hdmi_snd_write,
}; };
/************************************************************************ /*
* HDMI video
*/
HDMI video
************************************************************************/
/* External video parameter settings */ /* External video parameter settings */
static void hdmi_external_video_param(struct sh_hdmi *hdmi) static void hdmi_external_video_param(struct sh_hdmi *hdmi)
{ {
@ -398,7 +391,7 @@ static void sh_hdmi_audio_config(struct sh_hdmi *hdmi)
*/ */
switch (pdata->flags & HDMI_SRC_MASK) { switch (pdata->flags & HDMI_SRC_MASK) {
default: default:
/* FALL THROUGH */ /* fall through */
case HDMI_SRC_I2S: case HDMI_SRC_I2S:
data = (0x0 << 3); data = (0x0 << 3);
break; break;