hollalinux
/
linux-sg2042
mirror of https://github.com/sophgo/linux-riscv.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

MIPS: tools: Fix resource leak in elf-entry.c 

There is a file descriptor resource leak in elf-entry.c, fix this
by adding fclose() before return and die.

Signed-off-by: Kaige Li <likaige@loongson.cn>
Signed-off-by: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
This commit is contained in:
Kaige Li 2020-05-14 20:59:41 +08:00 committed by Thomas Bogendoerfer
parent b34a1a7120
commit f33a0b9410
1 changed files with 8 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
arch/mips/tools/elf-entry.c
View File

@ -51,11 +51,14 @@ int main(int argc, const char *argv[])
nread = fread(&hdr, 1, sizeof(hdr), file); nread = fread(&hdr, 1, sizeof(hdr), file);
if (nread != sizeof(hdr)) { if (nread != sizeof(hdr)) {
perror("Unable to read input file"); perror("Unable to read input file");
fclose(file);
return EXIT_FAILURE; return EXIT_FAILURE;
} }
if (memcmp(hdr.ehdr32.e_ident, ELFMAG, SELFMAG)) if (memcmp(hdr.ehdr32.e_ident, ELFMAG, SELFMAG)) {
fclose(file);
die("Input is not an ELF\n"); die("Input is not an ELF\n");
}
switch (hdr.ehdr32.e_ident[EI_CLASS]) { switch (hdr.ehdr32.e_ident[EI_CLASS]) {
case ELFCLASS32: case ELFCLASS32:
@ -67,6 +70,7 @@ int main(int argc, const char *argv[])
entry = be32toh(hdr.ehdr32.e_entry); entry = be32toh(hdr.ehdr32.e_entry);
break; break;
default: default:
fclose(file);
die("Invalid ELF encoding\n"); die("Invalid ELF encoding\n");
} }
@ -83,14 +87,17 @@ int main(int argc, const char *argv[])
entry = be64toh(hdr.ehdr64.e_entry); entry = be64toh(hdr.ehdr64.e_entry);
break; break;
default: default:
fclose(file);
die("Invalid ELF encoding\n"); die("Invalid ELF encoding\n");
} }
break; break;
default: default:
fclose(file);
die("Invalid ELF class\n"); die("Invalid ELF class\n");
} }
printf("0x%016" PRIx64 "\n", entry); printf("0x%016" PRIx64 "\n", entry);
fclose(file);
return EXIT_SUCCESS; return EXIT_SUCCESS;
} }