drm/i915/guc: Remove last submission result from debugfs
Debugfs does not seems to be a right place to display transient data. If we want to capture errors, we should log them. Signed-off-by: Michal Wajdeczko <michal.wajdeczko@intel.com> Cc: Chris Wilson <chris@chris-wilson.co.uk> Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com> Link: http://patchwork.freedesktop.org/patch/msgid/20170518113104.54400-3-michal.wajdeczko@intel.com Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
This commit is contained in:
parent
c1adab9703
commit
f1448a62a1
|
@ -2482,7 +2482,6 @@ static void i915_guc_client_info(struct seq_file *m,
|
|||
client->wq_size, client->wq_offset, client->wq_tail);
|
||||
|
||||
seq_printf(m, "\tWork queue full: %u\n", client->no_wq_space);
|
||||
seq_printf(m, "\tLast submission result: %d\n", client->retcode);
|
||||
|
||||
for_each_engine(engine, dev_priv, id) {
|
||||
u64 submissions = client->submissions[id];
|
||||
|
|
|
@ -614,7 +614,6 @@ static void __i915_guc_submit(struct drm_i915_gem_request *rq)
|
|||
b_ret = guc_ring_doorbell(client);
|
||||
|
||||
client->submissions[engine_id] += 1;
|
||||
client->retcode = b_ret;
|
||||
|
||||
guc->submissions[engine_id] += 1;
|
||||
guc->last_seqno[engine_id] = rq->global_seqno;
|
||||
|
|
|
@ -59,7 +59,6 @@ struct drm_i915_gem_request;
|
|||
* available in the work queue (note, the queue is shared,
|
||||
* not per-engine). It is OK for this to be nonzero, but
|
||||
* it should not be huge!
|
||||
* retcode: errno from last guc_submit()
|
||||
*/
|
||||
struct i915_guc_client {
|
||||
struct i915_vma *vma;
|
||||
|
@ -82,7 +81,6 @@ struct i915_guc_client {
|
|||
uint32_t wq_tail;
|
||||
uint32_t wq_rsvd;
|
||||
uint32_t no_wq_space;
|
||||
int retcode;
|
||||
|
||||
/* Per-engine counts of GuC submissions */
|
||||
uint64_t submissions[I915_NUM_ENGINES];
|
||||
|
|
Loading…
Reference in New Issue