hollalinux
/
linux-sg2042
mirror of https://github.com/sophgo/linux-riscv.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Staging: rtl8188eu: Fix warning of unchecked sscanf return value. 

This patch fixes the warning "unchecked sscanf return value" in file
rtw_mp.c. Zero is returned in case sscanf fails or if less than expected
items are read and assigned successfully. I have decided to return zero,
because in previous conditional statements zero was returned in case of
failure.

While at it, I have also fixed the warning of line over 80
characters.

Signed-off-by: Elena Oat <oat.elena@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Elena Oat 2014-03-18 19:16:49 +02:00 committed by Greg Kroah-Hartman
parent 94b9c616e6
commit f12919d5c9
1 changed files with 5 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
drivers/staging/rtl8188eu/core/rtw_mp.c
View File

@ -883,7 +883,7 @@ u32 mp_query_psd(struct adapter *pAdapter, u8 *data)
{ {
u32 i, psd_pts = 0, psd_start = 0, psd_stop = 0; u32 i, psd_pts = 0, psd_start = 0, psd_stop = 0;
u32 psd_data = 0; u32 psd_data = 0;
int ret;
if (!netif_running(pAdapter->pnetdev)) { if (!netif_running(pAdapter->pnetdev)) {
RT_TRACE(_module_mp_, _drv_warning_, ("mp_query_psd: Fail! interface not opened!\n")); RT_TRACE(_module_mp_, _drv_warning_, ("mp_query_psd: Fail! interface not opened!\n"));
@ -900,7 +900,10 @@ u32 mp_query_psd(struct adapter *pAdapter, u8 *data)
psd_start = 64; psd_start = 64;
psd_stop = 128; psd_stop = 128;
} else { } else {
sscanf(data, "pts =%d, start =%d, stop =%d", &psd_pts, &psd_start, &psd_stop); ret = sscanf(data, "pts =%d, start =%d, stop =%d",
&psd_pts, &psd_start, &psd_stop);
if (ret != 3)
return 0;
} }
_rtw_memset(data, '\0', sizeof(*data)); _rtw_memset(data, '\0', sizeof(*data));