nfp: use struct_size() in kzalloc()
One of the more common cases of allocation size calculations is finding the size of a structure that has a zero-sized array at the end, along with memory for some number of elements for that array. For example: struct foo { int stuff; struct boo entry[]; }; instance = kzalloc(sizeof(struct foo) + count * sizeof(struct boo), GFP_KERNEL); Instead of leaving these open-coded and prone to type mistakes, we can now use the new struct_size() helper: instance = kzalloc(struct_size(instance, entry, count), GFP_KERNEL); This code was detected with the help of Coccinelle. Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com> Acked-by: Jakub Kicinski <jakub.kicinski@netronome.com> Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
parent
6541d02590
commit
ee69804714
|
@ -269,8 +269,7 @@ __nfp_eth_read_ports(struct nfp_cpp *cpp, struct nfp_nsp *nsp)
|
|||
goto err;
|
||||
}
|
||||
|
||||
table = kzalloc(sizeof(*table) +
|
||||
sizeof(struct nfp_eth_table_port) * cnt, GFP_KERNEL);
|
||||
table = kzalloc(struct_size(table, ports, cnt), GFP_KERNEL);
|
||||
if (!table)
|
||||
goto err;
|
||||
|
||||
|
|
Loading…
Reference in New Issue