hollalinux
/
linux-sg2042
mirror of https://github.com/sophgo/linux-riscv.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

irqchip/mxs: Fix error check of of_io_request_and_map() 

The of_io_request_and_map() returns a valid pointer in iomem region or
ERR_PTR(), check for NULL always fails and may cause a NULL pointer
dereference on error path.

Fixes: 25e34b4431 ("irqchip/mxs: Prepare driver for hardware with different offsets")
Signed-off-by: Vladimir Zapolskiy <vz@mleia.com>
Cc: Jason Cooper <jason@lakedaemon.net>
Cc: Marc Zyngier <marc.zyngier@arm.com>
Cc: Oleksij Rempel <linux@rempel-privat.de>
Cc: Sascha Hauer <kernel@pengutronix.de>
Cc: Shawn Guo <shawnguo@kernel.org>
Cc: linux-arm-kernel@lists.infradead.org
Link: http://lkml.kernel.org/r/1457486500-10237-1-git-send-email-vz@mleia.com
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
This commit is contained in:
Vladimir Zapolskiy 2016-03-09 03:21:40 +02:00 committed by Thomas Gleixner
parent cfe199afef
commit edf8fcdc6b
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/irqchip/irq-mxs.c
View File

@ -183,7 +183,7 @@ static void __iomem * __init icoll_init_iobase(struct device_node *np)
void __iomem *icoll_base; void __iomem *icoll_base;
icoll_base = of_io_request_and_map(np, 0, np->name); icoll_base = of_io_request_and_map(np, 0, np->name);
if (!icoll_base) if (IS_ERR(icoll_base))
panic("%s: unable to map resource", np->full_name); panic("%s: unable to map resource", np->full_name);
return icoll_base; return icoll_base;
} }