hollalinux
/
linux-sg2042
mirror of https://github.com/sophgo/linux-riscv.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

kill lookup_create() 

folded into the only caller (kern_path_create())

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
This commit is contained in:
Al Viro 2011-06-27 16:53:43 -04:00
parent 5da4e68944
commit ed75e95de5
2 changed files with 18 additions and 37 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

54
fs/namei.c
View File

@ -2258,35 +2258,29 @@ struct file *do_file_open_root(struct dentry *dentry, struct vfsmount *mnt,
return file; return file;
} }
/** struct dentry *kern_path_create(int dfd, const char *pathname, struct path *path, int is_dir)
* lookup_create - lookup a dentry, creating it if it doesn't exist
* @nd: nameidata info
* @is_dir: directory flag
*
* Simple function to lookup and return a dentry and create it
* if it doesn't exist. Is SMP-safe.
*
* Returns with nd->path.dentry->d_inode->i_mutex locked.
*/
struct dentry *lookup_create(struct nameidata *nd, int is_dir)
{ {
struct dentry *dentry = ERR_PTR(-EEXIST); struct dentry *dentry = ERR_PTR(-EEXIST);
struct nameidata nd;
int error = do_path_lookup(dfd, pathname, LOOKUP_PARENT, &nd);
if (error)
return ERR_PTR(error);
mutex_lock_nested(&nd->path.dentry->d_inode->i_mutex, I_MUTEX_PARENT);
/* /*
* Yucky last component or no last component at all? * Yucky last component or no last component at all?
* (foo/., foo/.., /////) * (foo/., foo/.., /////)
*/ */
if (nd->last_type != LAST_NORM) if (nd.last_type != LAST_NORM)
goto fail; goto out;
nd->flags &= ~LOOKUP_PARENT; nd.flags &= ~LOOKUP_PARENT;
nd->flags |= LOOKUP_CREATE | LOOKUP_EXCL; nd.flags |= LOOKUP_CREATE | LOOKUP_EXCL;
nd->intent.open.flags = O_EXCL; nd.intent.open.flags = O_EXCL;
/* /*
* Do the final lookup. * Do the final lookup.
*/ */
dentry = lookup_hash(nd); mutex_lock_nested(&nd.path.dentry->d_inode->i_mutex, I_MUTEX_PARENT);
dentry = lookup_hash(&nd);
if (IS_ERR(dentry)) if (IS_ERR(dentry))
goto fail; goto fail;
@ -2298,34 +2292,22 @@ struct dentry *lookup_create(struct nameidata *nd, int is_dir)
* all is fine. Let's be bastards - you had / on the end, you've * all is fine. Let's be bastards - you had / on the end, you've
* been asking for (non-existent) directory. -ENOENT for you. * been asking for (non-existent) directory. -ENOENT for you.
*/ */
if (unlikely(!is_dir && nd->last.name[nd->last.len])) { if (unlikely(!is_dir && nd.last.name[nd.last.len])) {
dput(dentry); dput(dentry);
dentry = ERR_PTR(-ENOENT); dentry = ERR_PTR(-ENOENT);
goto fail;
} }
*path = nd.path;
return dentry; return dentry;
eexist: eexist:
dput(dentry); dput(dentry);
dentry = ERR_PTR(-EEXIST); dentry = ERR_PTR(-EEXIST);
fail: fail:
mutex_unlock(&nd.path.dentry->d_inode->i_mutex);
out:
path_put(&nd.path);
return dentry; return dentry;
} }
EXPORT_SYMBOL_GPL(lookup_create);
struct dentry *kern_path_create(int dfd, const char *pathname, struct path *path, int is_dir)
{
struct nameidata nd;
struct dentry *res;
int error = do_path_lookup(dfd, pathname, LOOKUP_PARENT, &nd);
if (error)
return ERR_PTR(error);
res = lookup_create(&nd, is_dir);
if (IS_ERR(res)) {
mutex_unlock(&nd.path.dentry->d_inode->i_mutex);
path_put(&nd.path);
}
*path = nd.path;
return res;
}
EXPORT_SYMBOL(kern_path_create); EXPORT_SYMBOL(kern_path_create);
struct dentry *user_path_create(int dfd, const char __user *pathname, struct path *path, int is_dir) struct dentry *user_path_create(int dfd, const char __user *pathname, struct path *path, int is_dir)

1
include/linux/dcache.h
View File

@ -423,7 +423,6 @@ static inline bool d_need_lookup(struct dentry *dentry)
} }
extern void d_clear_need_lookup(struct dentry *dentry); extern void d_clear_need_lookup(struct dentry *dentry);
extern struct dentry *lookup_create(struct nameidata *nd, int is_dir);
extern int sysctl_vfs_cache_pressure; extern int sysctl_vfs_cache_pressure;