dmaengine: dma-jz4780: Use struct_size() in devm_kzalloc()
One of the more common cases of allocation size calculations is finding the size of a structure that has a zero-sized array at the end, along with memory for some number of elements for that array. For example: struct foo { int stuff; void *entry[]; }; instance = devm_kzalloc(dev, sizeof(struct foo) + sizeof(void *) * count, GFP_KERNEL); Instead of leaving these open-coded and prone to type mistakes, we can now use the new struct_size() helper: instance = devm_kzalloc(dev, struct_size(instance, entry, count), GFP_KERNEL); This issue was detected with the help of Coccinelle. Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com> Signed-off-by: Vinod Koul <vkoul@kernel.org>
This commit is contained in:
parent
5fde600537
commit
ed414d5803
|
@ -838,9 +838,8 @@ static int jz4780_dma_probe(struct platform_device *pdev)
|
|||
if (!soc_data)
|
||||
return -EINVAL;
|
||||
|
||||
jzdma = devm_kzalloc(dev, sizeof(*jzdma)
|
||||
+ sizeof(*jzdma->chan) * soc_data->nb_channels,
|
||||
GFP_KERNEL);
|
||||
jzdma = devm_kzalloc(dev, struct_size(jzdma, chan,
|
||||
soc_data->nb_channels), GFP_KERNEL);
|
||||
if (!jzdma)
|
||||
return -ENOMEM;
|
||||
|
||||
|
|
Loading…
Reference in New Issue