hollalinux
/
linux-sg2042
mirror of https://github.com/sophgo/linux-riscv.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

USB: wusbcore: return negative error codes 

cbaf_cdid_get() is only used in cbaf_wusb_chid_store().

In the original code cbaf_cdid_get() returns either a negative error
code or a small positive value on error.  I have changed it to
return -ENOENT if there is not enough data available.

In the original code the caller changed the negative error codes to
positive return values.  I've changed it to just return the error
value directly.

Signed-off-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
This commit is contained in:
Dan Carpenter 2011-06-04 09:10:21 +03:00 committed by Greg Kroah-Hartman
parent 325fd182ca
commit e90ed12cc4
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/usb/wusbcore/cbaf.c
View File

@ -298,7 +298,7 @@ static int cbaf_cdid_get(struct cbaf *cbaf)
if (result < needed) { if (result < needed) {
dev_err(dev, "Not enough data in DEVICE_INFO reply (%zu vs " dev_err(dev, "Not enough data in DEVICE_INFO reply (%zu vs "
"%zu bytes needed)\n", (size_t)result, needed); "%zu bytes needed)\n", (size_t)result, needed);
return result; return -ENOENT;
} }
strlcpy(cbaf->device_name, di->DeviceFriendlyName, CBA_NAME_LEN); strlcpy(cbaf->device_name, di->DeviceFriendlyName, CBA_NAME_LEN);
@ -350,7 +350,7 @@ static ssize_t cbaf_wusb_chid_store(struct device *dev,
return result; return result;
result = cbaf_cdid_get(cbaf); result = cbaf_cdid_get(cbaf);
if (result < 0) if (result < 0)
return -result; return result;
return size; return size;
} }
static DEVICE_ATTR(wusb_chid, 0600, cbaf_wusb_chid_show, cbaf_wusb_chid_store); static DEVICE_ATTR(wusb_chid, 0600, cbaf_wusb_chid_show, cbaf_wusb_chid_store);