TTY: ipwireless, move prints to appropriate places
There are two functions which only print a status. Let us do that directly at places where they are called. Signed-off-by: Jiri Slaby <jslaby@suse.cz> Cc: Jiri Kosina <jkosina@suse.cz> Acked-by: David Sterba <dsterba@suse.cz> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
parent
de3a60a343
commit
e6df3cce07
|
@ -73,23 +73,6 @@ static char *tty_type_name(int tty_type)
|
||||||
return channel_names[tty_type];
|
return channel_names[tty_type];
|
||||||
}
|
}
|
||||||
|
|
||||||
static void report_registering(struct ipw_tty *tty)
|
|
||||||
{
|
|
||||||
char *iftype = tty_type_name(tty->tty_type);
|
|
||||||
|
|
||||||
printk(KERN_INFO IPWIRELESS_PCCARD_NAME
|
|
||||||
": registering %s device ttyIPWp%d\n", iftype, tty->index);
|
|
||||||
}
|
|
||||||
|
|
||||||
static void report_deregistering(struct ipw_tty *tty)
|
|
||||||
{
|
|
||||||
char *iftype = tty_type_name(tty->tty_type);
|
|
||||||
|
|
||||||
printk(KERN_INFO IPWIRELESS_PCCARD_NAME
|
|
||||||
": deregistering %s device ttyIPWp%d\n", iftype,
|
|
||||||
tty->index);
|
|
||||||
}
|
|
||||||
|
|
||||||
static struct ipw_tty *get_tty(int index)
|
static struct ipw_tty *get_tty(int index)
|
||||||
{
|
{
|
||||||
/*
|
/*
|
||||||
|
@ -500,8 +483,12 @@ static int add_tty(int j,
|
||||||
ipwireless_associate_network_tty(network,
|
ipwireless_associate_network_tty(network,
|
||||||
secondary_channel_idx,
|
secondary_channel_idx,
|
||||||
ttys[j]);
|
ttys[j]);
|
||||||
if (get_tty(j) == ttys[j])
|
/* check if we provide raw device (if loopback is enabled) */
|
||||||
report_registering(ttys[j]);
|
if (get_tty(j))
|
||||||
|
printk(KERN_INFO IPWIRELESS_PCCARD_NAME
|
||||||
|
": registering %s device ttyIPWp%d\n",
|
||||||
|
tty_type_name(tty_type), j);
|
||||||
|
|
||||||
return 0;
|
return 0;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
@ -560,8 +547,10 @@ void ipwireless_tty_free(struct ipw_tty *tty)
|
||||||
|
|
||||||
if (ttyj) {
|
if (ttyj) {
|
||||||
mutex_lock(&ttyj->ipw_tty_mutex);
|
mutex_lock(&ttyj->ipw_tty_mutex);
|
||||||
if (get_tty(j) == ttyj)
|
if (get_tty(j))
|
||||||
report_deregistering(ttyj);
|
printk(KERN_INFO IPWIRELESS_PCCARD_NAME
|
||||||
|
": deregistering %s device ttyIPWp%d\n",
|
||||||
|
tty_type_name(ttyj->tty_type), j);
|
||||||
ttyj->closing = 1;
|
ttyj->closing = 1;
|
||||||
if (ttyj->linux_tty != NULL) {
|
if (ttyj->linux_tty != NULL) {
|
||||||
mutex_unlock(&ttyj->ipw_tty_mutex);
|
mutex_unlock(&ttyj->ipw_tty_mutex);
|
||||||
|
|
Loading…
Reference in New Issue