V4L/DVB (11188): pvrusb2: Sub-device update must happen BEFORE state dirty bits are cleared

The sub-device update mechanism relies on various "dirty" bits in the
driver in order to know what pieces of state need to be propagated out
to the various sub-devices.  But that won't work if the dirty bits are
cleared before the update gets a chance to run.  This change ensures
that the update takes place before the dirty bits are cleared.

Signed-off-by: Mike Isely <isely@pobox.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
This commit is contained in:
Mike Isely 2009-03-07 01:45:10 -03:00 committed by Mauro Carvalho Chehab
parent 0db8556805
commit e68a619a1b
1 changed files with 3 additions and 3 deletions

View File

@ -3238,15 +3238,15 @@ static int pvr2_hdw_commit_execute(struct pvr2_hdw *hdw)
} }
} }
/* Check and update state for all sub-devices. */
pvr2_subdev_update(hdw);
for (idx = 0; idx < hdw->control_cnt; idx++) { for (idx = 0; idx < hdw->control_cnt; idx++) {
cptr = hdw->controls + idx; cptr = hdw->controls + idx;
if (!cptr->info->clear_dirty) continue; if (!cptr->info->clear_dirty) continue;
cptr->info->clear_dirty(cptr); cptr->info->clear_dirty(cptr);
} }
/* Check and update state for all sub-devices. */
pvr2_subdev_update(hdw);
/* Now execute i2c core update */ /* Now execute i2c core update */
pvr2_i2c_core_sync(hdw); pvr2_i2c_core_sync(hdw);