[SCSI] ipr: Fixup device type check
Fixup a check used by the ipr driver to determine if a given device is a SCSI disk. Due to the addition of support for attaching SATA devices, this check needs to be more robust. Signed-off-by: Brian King <brking@us.ibm.com> Signed-off-by: James Bottomley <James.Bottomley@SteelEye.com>
This commit is contained in:
parent
1121b794a3
commit
e4fbf44ed0
|
@ -3214,7 +3214,7 @@ static int ipr_slave_configure(struct scsi_device *sdev)
|
|||
sdev->timeout = IPR_VSET_RW_TIMEOUT;
|
||||
blk_queue_max_sectors(sdev->request_queue, IPR_VSET_MAX_SECTORS);
|
||||
}
|
||||
if (IPR_IS_DASD_DEVICE(res->cfgte.std_inq_data))
|
||||
if (ipr_is_vset_device(res) || ipr_is_scsi_disk(res))
|
||||
sdev->allow_restart = 1;
|
||||
scsi_adjust_queue_depth(sdev, 0, sdev->host->cmd_per_lun);
|
||||
}
|
||||
|
@ -4540,7 +4540,7 @@ static int ipr_set_supported_devs(struct ipr_cmnd *ipr_cmd)
|
|||
ipr_cmd->job_step = ipr_ioa_reset_done;
|
||||
|
||||
list_for_each_entry_continue(res, &ioa_cfg->used_res_q, queue) {
|
||||
if (!IPR_IS_DASD_DEVICE(res->cfgte.std_inq_data))
|
||||
if (!ipr_is_scsi_disk(res))
|
||||
continue;
|
||||
|
||||
ipr_cmd->u.res = res;
|
||||
|
|
|
@ -1304,6 +1304,22 @@ static inline int ipr_is_gscsi(struct ipr_resource_entry *res)
|
|||
return 0;
|
||||
}
|
||||
|
||||
/**
|
||||
* ipr_is_scsi_disk - Determine if a resource is a SCSI disk
|
||||
* @res: resource entry struct
|
||||
*
|
||||
* Return value:
|
||||
* 1 if SCSI disk / 0 if not SCSI disk
|
||||
**/
|
||||
static inline int ipr_is_scsi_disk(struct ipr_resource_entry *res)
|
||||
{
|
||||
if (ipr_is_af_dasd_device(res) ||
|
||||
(ipr_is_gscsi(res) && IPR_IS_DASD_DEVICE(res->cfgte.std_inq_data)))
|
||||
return 1;
|
||||
else
|
||||
return 0;
|
||||
}
|
||||
|
||||
/**
|
||||
* ipr_is_naca_model - Determine if a resource is using NACA queueing model
|
||||
* @res: resource entry struct
|
||||
|
|
Loading…
Reference in New Issue