hollalinux
/
linux-sg2042
mirror of https://github.com/sophgo/linux-riscv.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

ASoC: max98373: replace gpio_request with devm_gpio_request 

Use devm_gpio_request() to automatic unroll when fails and avoid
resource leaks at error paths.

Signed-off-by: Yong Zhi <yong.zhi@intel.com>
Link: https://lore.kernel.org/r/1572905399-22402-1-git-send-email-yong.zhi@intel.com
Signed-off-by: Mark Brown <broonie@kernel.org>
This commit is contained in:
Yong Zhi 2019-11-04 16:09:59 -06:00 committed by Mark Brown
parent eaf072e512
commit e44f3d49f9
No known key found for this signature in database
GPG Key ID: 24D68B725D5487D0
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
sound/soc/codecs/max98373.c
View File

@ -960,11 +960,11 @@ static int max98373_i2c_probe(struct i2c_client *i2c,
/* Power on device */ /* Power on device */
if (gpio_is_valid(max98373->reset_gpio)) { if (gpio_is_valid(max98373->reset_gpio)) {
ret = gpio_request(max98373->reset_gpio, "MAX98373_RESET"); ret = devm_gpio_request(&i2c->dev, max98373->reset_gpio,
"MAX98373_RESET");
if (ret) { if (ret) {
dev_err(&i2c->dev, "%s: Failed to request gpio %d\n", dev_err(&i2c->dev, "%s: Failed to request gpio %d\n",
__func__, max98373->reset_gpio); __func__, max98373->reset_gpio);
gpio_free(max98373->reset_gpio);
return -EINVAL; return -EINVAL;
} }
gpio_direction_output(max98373->reset_gpio, 0); gpio_direction_output(max98373->reset_gpio, 0);