flag parameters: check magic constants
This patch adds test that ensure the boundary conditions for the various constants introduced in the previous patches is met. No code is generated. [akpm@linux-foundation.org: fix alpha] Signed-off-by: Ulrich Drepper <drepper@redhat.com> Acked-by: Davide Libenzi <davidel@xmailserver.org> Cc: Michael Kerrisk <mtk.manpages@googlemail.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
This commit is contained in:
parent
510df2dd48
commit
e38b36f325
|
@ -203,6 +203,10 @@ asmlinkage long sys_eventfd2(unsigned int count, int flags)
|
|||
int fd;
|
||||
struct eventfd_ctx *ctx;
|
||||
|
||||
/* Check the EFD_* constants for consistency. */
|
||||
BUILD_BUG_ON(EFD_CLOEXEC != O_CLOEXEC);
|
||||
BUILD_BUG_ON(EFD_NONBLOCK != O_NONBLOCK);
|
||||
|
||||
if (flags & ~(EFD_CLOEXEC | EFD_NONBLOCK))
|
||||
return -EINVAL;
|
||||
|
||||
|
|
|
@ -1051,6 +1051,9 @@ asmlinkage long sys_epoll_create2(int size, int flags)
|
|||
int error, fd = -1;
|
||||
struct eventpoll *ep;
|
||||
|
||||
/* Check the EPOLL_* constant for consistency. */
|
||||
BUILD_BUG_ON(EPOLL_CLOEXEC != O_CLOEXEC);
|
||||
|
||||
if (flags & ~EPOLL_CLOEXEC)
|
||||
return -EINVAL;
|
||||
|
||||
|
|
|
@ -574,6 +574,10 @@ asmlinkage long sys_inotify_init1(int flags)
|
|||
struct file *filp;
|
||||
int fd, ret;
|
||||
|
||||
/* Check the IN_* constants for consistency. */
|
||||
BUILD_BUG_ON(IN_CLOEXEC != O_CLOEXEC);
|
||||
BUILD_BUG_ON(IN_NONBLOCK != O_NONBLOCK);
|
||||
|
||||
if (flags & ~(IN_CLOEXEC | IN_NONBLOCK))
|
||||
return -EINVAL;
|
||||
|
||||
|
|
|
@ -211,6 +211,10 @@ asmlinkage long sys_signalfd4(int ufd, sigset_t __user *user_mask,
|
|||
sigset_t sigmask;
|
||||
struct signalfd_ctx *ctx;
|
||||
|
||||
/* Check the SFD_* constants for consistency. */
|
||||
BUILD_BUG_ON(SFD_CLOEXEC != O_CLOEXEC);
|
||||
BUILD_BUG_ON(SFD_NONBLOCK != O_NONBLOCK);
|
||||
|
||||
if (flags & ~(SFD_CLOEXEC | SFD_NONBLOCK))
|
||||
return -EINVAL;
|
||||
|
||||
|
|
|
@ -184,6 +184,10 @@ asmlinkage long sys_timerfd_create(int clockid, int flags)
|
|||
int ufd;
|
||||
struct timerfd_ctx *ctx;
|
||||
|
||||
/* Check the TFD_* constants for consistency. */
|
||||
BUILD_BUG_ON(TFD_CLOEXEC != O_CLOEXEC);
|
||||
BUILD_BUG_ON(TFD_NONBLOCK != O_NONBLOCK);
|
||||
|
||||
if (flags & ~(TFD_CLOEXEC | TFD_NONBLOCK))
|
||||
return -EINVAL;
|
||||
if (clockid != CLOCK_MONOTONIC &&
|
||||
|
|
|
@ -1222,6 +1222,12 @@ asmlinkage long sys_socket(int family, int type, int protocol)
|
|||
struct socket *sock;
|
||||
int flags;
|
||||
|
||||
/* Check the SOCK_* constants for consistency. */
|
||||
BUILD_BUG_ON(SOCK_CLOEXEC != O_CLOEXEC);
|
||||
BUILD_BUG_ON((SOCK_MAX | SOCK_TYPE_MASK) != SOCK_TYPE_MASK);
|
||||
BUILD_BUG_ON(SOCK_CLOEXEC & SOCK_TYPE_MASK);
|
||||
BUILD_BUG_ON(SOCK_NONBLOCK & SOCK_TYPE_MASK);
|
||||
|
||||
flags = type & ~SOCK_TYPE_MASK;
|
||||
if (flags & ~(SOCK_CLOEXEC | SOCK_NONBLOCK))
|
||||
return -EINVAL;
|
||||
|
|
Loading…
Reference in New Issue