USB: misc: usbsevseg: fix up some sysfs attribute permissions
They should not be writable by any user. Reported-by: Linus Torvalds <torvalds@linux-foundation.org> Cc: Harrison Metzger <harrisonmetz@gmail.com> Cc: stable <stable@kernel.org> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
This commit is contained in:
parent
48f115470e
commit
e24d7ace4e
|
@ -192,7 +192,7 @@ static ssize_t set_attr_##name(struct device *dev, \
|
|||
\
|
||||
return count; \
|
||||
} \
|
||||
static DEVICE_ATTR(name, S_IWUGO | S_IRUGO, show_attr_##name, set_attr_##name);
|
||||
static DEVICE_ATTR(name, S_IRUGO | S_IWUSR, show_attr_##name, set_attr_##name);
|
||||
|
||||
static ssize_t show_attr_text(struct device *dev,
|
||||
struct device_attribute *attr, char *buf)
|
||||
|
@ -223,7 +223,7 @@ static ssize_t set_attr_text(struct device *dev,
|
|||
return count;
|
||||
}
|
||||
|
||||
static DEVICE_ATTR(text, S_IWUGO | S_IRUGO, show_attr_text, set_attr_text);
|
||||
static DEVICE_ATTR(text, S_IRUGO | S_IWUSR, show_attr_text, set_attr_text);
|
||||
|
||||
static ssize_t show_attr_decimals(struct device *dev,
|
||||
struct device_attribute *attr, char *buf)
|
||||
|
@ -272,8 +272,7 @@ static ssize_t set_attr_decimals(struct device *dev,
|
|||
return count;
|
||||
}
|
||||
|
||||
static DEVICE_ATTR(decimals, S_IWUGO | S_IRUGO,
|
||||
show_attr_decimals, set_attr_decimals);
|
||||
static DEVICE_ATTR(decimals, S_IRUGO | S_IWUSR, show_attr_decimals, set_attr_decimals);
|
||||
|
||||
static ssize_t show_attr_textmode(struct device *dev,
|
||||
struct device_attribute *attr, char *buf)
|
||||
|
@ -319,8 +318,7 @@ static ssize_t set_attr_textmode(struct device *dev,
|
|||
return -EINVAL;
|
||||
}
|
||||
|
||||
static DEVICE_ATTR(textmode, S_IWUGO | S_IRUGO,
|
||||
show_attr_textmode, set_attr_textmode);
|
||||
static DEVICE_ATTR(textmode, S_IRUGO | S_IWUSR, show_attr_textmode, set_attr_textmode);
|
||||
|
||||
|
||||
MYDEV_ATTR_SIMPLE_UNSIGNED(powered, update_display_powered);
|
||||
|
|
Loading…
Reference in New Issue