hollalinux
/
linux-sg2042
mirror of https://github.com/sophgo/linux-riscv.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

parport: avoid assignment in if 

It is not an usual practise to assign some value to a variable in the if
test condition.

Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Sudip Mukherjee 2015-10-28 14:41:40 +05:30 committed by Greg Kroah-Hartman
parent e732b93c32
commit e0a7f1f04c
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
drivers/parport/share.c
View File

@ -1120,7 +1120,8 @@ int parport_claim(struct pardevice *dev)
/* Preempt any current device */ /* Preempt any current device */
write_lock_irqsave(&port->cad_lock, flags); write_lock_irqsave(&port->cad_lock, flags);
if ((oldcad = port->cad) != NULL) { oldcad = port->cad;
if (oldcad) {
if (oldcad->preempt) { if (oldcad->preempt) {
if (oldcad->preempt(oldcad->private)) if (oldcad->preempt(oldcad->private))
goto blocked; goto blocked;