From ab275b132a79c7b08f10fa22fc3f204eb8e26d33 Mon Sep 17 00:00:00 2001 From: Linus Walleij Date: Tue, 3 Jun 2014 16:14:01 +0200 Subject: [PATCH 1/4] ARM: s5p: cut the custom ARCH_NR_GPIOS definition The number of GPIOs defined for the different S5P platforms using the tricky #define macros are actually as follows: S5P64x0: 180 GPIOs S5PC100: 115 GPIOs S5PV210: 252 GPIOs The include file will automatically bump us to 256 GPIOs which is a nice default value that happens to encompass all the S5P platform requirements under its roof. Cut ARCH_NR_GPIOS and the custom spacing macro for extra GPIOs that is not used anywhere in the kernel. Acked-by: Alexandre Courbot Signed-off-by: Linus Walleij --- arch/arm/mach-s5p64x0/include/mach/gpio.h | 4 ---- arch/arm/mach-s5pc100/include/mach/gpio.h | 3 --- arch/arm/mach-s5pv210/include/mach/gpio.h | 4 ---- arch/arm/plat-samsung/Kconfig | 16 ---------------- 4 files changed, 27 deletions(-) diff --git a/arch/arm/mach-s5p64x0/include/mach/gpio.h b/arch/arm/mach-s5p64x0/include/mach/gpio.h index 06cd3c9b16ac..cbd325e14477 100644 --- a/arch/arm/mach-s5p64x0/include/mach/gpio.h +++ b/arch/arm/mach-s5p64x0/include/mach/gpio.h @@ -125,8 +125,4 @@ enum s5p6450_gpio_number { #define S3C_GPIO_END S5P64X0_GPIO_END -/* define the number of gpios we need to the one after the last GPIO range */ - -#define ARCH_NR_GPIOS (S5P64X0_GPIO_END + CONFIG_SAMSUNG_GPIO_EXTRA) - #endif /* __ASM_ARCH_GPIO_H */ diff --git a/arch/arm/mach-s5pc100/include/mach/gpio.h b/arch/arm/mach-s5pc100/include/mach/gpio.h index 5e1a924b595f..291c57504bab 100644 --- a/arch/arm/mach-s5pc100/include/mach/gpio.h +++ b/arch/arm/mach-s5pc100/include/mach/gpio.h @@ -138,7 +138,4 @@ enum s5p_gpio_number { /* It used the end of the S5PC100 gpios */ #define S3C_GPIO_END S5PC100_GPIO_END -/* define the number of gpios we need to the one after the MP04() range */ -#define ARCH_NR_GPIOS (S5PC100_GPIO_END + 1) - #endif /* __ASM_ARCH_GPIO_H */ diff --git a/arch/arm/mach-s5pv210/include/mach/gpio.h b/arch/arm/mach-s5pv210/include/mach/gpio.h index 6c8b903c02e4..e6f80d57c38e 100644 --- a/arch/arm/mach-s5pv210/include/mach/gpio.h +++ b/arch/arm/mach-s5pv210/include/mach/gpio.h @@ -133,8 +133,4 @@ enum s5p_gpio_number { #define S5PV210_GPIO_END (S5PV210_MP05(S5PV210_GPIO_MP05_NR) + 1) #define S3C_GPIO_END S5PV210_GPIO_END -/* define the number of gpios we need to the one after the MP05() range */ -#define ARCH_NR_GPIOS (S5PV210_MP05(S5PV210_GPIO_MP05_NR) + \ - CONFIG_SAMSUNG_GPIO_EXTRA + 1) - #endif /* __ASM_ARCH_GPIO_H */ diff --git a/arch/arm/plat-samsung/Kconfig b/arch/arm/plat-samsung/Kconfig index 301b892d97d9..1e1811274e74 100644 --- a/arch/arm/plat-samsung/Kconfig +++ b/arch/arm/plat-samsung/Kconfig @@ -108,22 +108,6 @@ config S5P_GPIO_DRVSTR Internal configuration to get and set correct GPIO driver strength helper -config SAMSUNG_GPIO_EXTRA - int "Number of additional GPIO pins" - default 128 if SAMSUNG_GPIO_EXTRA128 - default 64 if SAMSUNG_GPIO_EXTRA64 - default 0 - help - Use additional GPIO space in addition to the GPIO's the SOC - provides. This allows expanding the GPIO space for use with - GPIO expanders. - -config SAMSUNG_GPIO_EXTRA64 - bool - -config SAMSUNG_GPIO_EXTRA128 - bool - config S3C_GPIO_SPACE int "Space between gpio banks" default 0 From 2fd48f94426d25e59732a54e2a983796714729fa Mon Sep 17 00:00:00 2001 From: Linus Walleij Date: Wed, 4 Jun 2014 15:10:45 +0200 Subject: [PATCH 2/4] ARM: mach-s5p: get rid of all headers This renames all the local headers in the S5P platforms to indicating a scope local to this platform, and cuts the implicit inclusion of from by removing the use of NEED_MACH_GPIO_H from all S5P variants. Acked-by: Alexandre Courbot Signed-off-by: Linus Walleij --- arch/arm/Kconfig | 3 --- arch/arm/mach-s5p64x0/common.c | 2 +- arch/arm/mach-s5p64x0/dev-audio.c | 3 ++- arch/arm/mach-s5p64x0/include/mach/{gpio.h => gpio-samsung.h} | 3 +-- arch/arm/mach-s5p64x0/mach-smdk6440.c | 1 + arch/arm/mach-s5p64x0/mach-smdk6450.c | 1 + arch/arm/mach-s5p64x0/setup-fb-24bpp.c | 2 +- arch/arm/mach-s5p64x0/setup-i2c0.c | 2 +- arch/arm/mach-s5p64x0/setup-i2c1.c | 2 +- arch/arm/mach-s5p64x0/setup-sdhci-gpio.c | 2 +- arch/arm/mach-s5p64x0/setup-spi.c | 2 +- arch/arm/mach-s5pc100/dev-audio.c | 2 +- arch/arm/mach-s5pc100/include/mach/{gpio.h => gpio-samsung.h} | 3 +-- arch/arm/mach-s5pc100/mach-smdkc100.c | 1 + arch/arm/mach-s5pc100/setup-fb-24bpp.c | 2 +- arch/arm/mach-s5pc100/setup-i2c0.c | 2 +- arch/arm/mach-s5pc100/setup-i2c1.c | 2 +- arch/arm/mach-s5pc100/setup-ide.c | 2 +- arch/arm/mach-s5pc100/setup-keypad.c | 2 +- arch/arm/mach-s5pc100/setup-sdhci-gpio.c | 2 +- arch/arm/mach-s5pc100/setup-spi.c | 2 +- arch/arm/mach-s5pv210/dev-audio.c | 2 +- arch/arm/mach-s5pv210/include/mach/{gpio.h => gpio-samsung.h} | 3 +-- arch/arm/mach-s5pv210/mach-aquila.c | 1 + arch/arm/mach-s5pv210/mach-goni.c | 1 + arch/arm/mach-s5pv210/mach-smdkv210.c | 1 + arch/arm/mach-s5pv210/setup-fb-24bpp.c | 2 +- arch/arm/mach-s5pv210/setup-fimc.c | 3 ++- arch/arm/mach-s5pv210/setup-i2c0.c | 2 +- arch/arm/mach-s5pv210/setup-i2c1.c | 2 +- arch/arm/mach-s5pv210/setup-i2c2.c | 2 +- arch/arm/mach-s5pv210/setup-ide.c | 2 +- arch/arm/mach-s5pv210/setup-keypad.c | 2 +- arch/arm/mach-s5pv210/setup-sdhci-gpio.c | 2 +- arch/arm/mach-s5pv210/setup-spi.c | 2 +- arch/arm/plat-samsung/include/plat/gpio-core.h | 3 +++ arch/arm/plat-samsung/pm-gpio.c | 2 -- arch/arm/plat-samsung/s5p-irq-eint.c | 2 +- drivers/gpio/gpio-samsung.c | 3 --- sound/soc/samsung/goni_wm8994.c | 2 +- 40 files changed, 41 insertions(+), 41 deletions(-) rename arch/arm/mach-s5p64x0/include/mach/{gpio.h => gpio-samsung.h} (98%) rename arch/arm/mach-s5pc100/include/mach/{gpio.h => gpio-samsung.h} (99%) rename arch/arm/mach-s5pv210/include/mach/{gpio.h => gpio-samsung.h} (99%) diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig index 245058b3b0ef..f5d9ef9c11b7 100644 --- a/arch/arm/Kconfig +++ b/arch/arm/Kconfig @@ -769,7 +769,6 @@ config ARCH_S5P64X0 select HAVE_S3C2410_I2C if I2C select HAVE_S3C2410_WATCHDOG if WATCHDOG select HAVE_S3C_RTC if RTC_CLASS - select NEED_MACH_GPIO_H select SAMSUNG_ATAGS select SAMSUNG_WDT_RESET help @@ -788,7 +787,6 @@ config ARCH_S5PC100 select HAVE_S3C2410_I2C if I2C select HAVE_S3C2410_WATCHDOG if WATCHDOG select HAVE_S3C_RTC if RTC_CLASS - select NEED_MACH_GPIO_H select SAMSUNG_ATAGS select SAMSUNG_WDT_RESET help @@ -807,7 +805,6 @@ config ARCH_S5PV210 select HAVE_S3C2410_I2C if I2C select HAVE_S3C2410_WATCHDOG if WATCHDOG select HAVE_S3C_RTC if RTC_CLASS - select NEED_MACH_GPIO_H select NEED_MACH_MEMORY_H select SAMSUNG_ATAGS help diff --git a/arch/arm/mach-s5p64x0/common.c b/arch/arm/mach-s5p64x0/common.c index 9a43be002d78..b56ffbd7cefe 100644 --- a/arch/arm/mach-s5p64x0/common.c +++ b/arch/arm/mach-s5p64x0/common.c @@ -24,7 +24,6 @@ #include #include #include -#include #include #include @@ -39,6 +38,7 @@ #include #include #include +#include #include #include diff --git a/arch/arm/mach-s5p64x0/dev-audio.c b/arch/arm/mach-s5p64x0/dev-audio.c index 723d4773c323..ea4a22822595 100644 --- a/arch/arm/mach-s5p64x0/dev-audio.c +++ b/arch/arm/mach-s5p64x0/dev-audio.c @@ -10,7 +10,6 @@ #include #include -#include #include #include @@ -18,6 +17,8 @@ #include #include #include +#include + static int s5p6440_cfg_i2s(struct platform_device *pdev) { diff --git a/arch/arm/mach-s5p64x0/include/mach/gpio.h b/arch/arm/mach-s5p64x0/include/mach/gpio-samsung.h similarity index 98% rename from arch/arm/mach-s5p64x0/include/mach/gpio.h rename to arch/arm/mach-s5p64x0/include/mach/gpio-samsung.h index cbd325e14477..fec01a4e6463 100644 --- a/arch/arm/mach-s5p64x0/include/mach/gpio.h +++ b/arch/arm/mach-s5p64x0/include/mach/gpio-samsung.h @@ -1,5 +1,4 @@ -/* linux/arch/arm/mach-s5p64x0/include/mach/gpio.h - * +/* * Copyright (c) 2009-2010 Samsung Electronics Co., Ltd. * http://www.samsung.com * diff --git a/arch/arm/mach-s5p64x0/mach-smdk6440.c b/arch/arm/mach-s5p64x0/mach-smdk6440.c index 6840e197cb2d..037318867459 100644 --- a/arch/arm/mach-s5p64x0/mach-smdk6440.c +++ b/arch/arm/mach-s5p64x0/mach-smdk6440.c @@ -39,6 +39,7 @@ #include #include #include +#include #include #include diff --git a/arch/arm/mach-s5p64x0/mach-smdk6450.c b/arch/arm/mach-s5p64x0/mach-smdk6450.c index fa1341c074ca..e191d9019beb 100644 --- a/arch/arm/mach-s5p64x0/mach-smdk6450.c +++ b/arch/arm/mach-s5p64x0/mach-smdk6450.c @@ -39,6 +39,7 @@ #include #include #include +#include #include #include diff --git a/arch/arm/mach-s5p64x0/setup-fb-24bpp.c b/arch/arm/mach-s5p64x0/setup-fb-24bpp.c index f346ee4af54d..37252bece7d4 100644 --- a/arch/arm/mach-s5p64x0/setup-fb-24bpp.c +++ b/arch/arm/mach-s5p64x0/setup-fb-24bpp.c @@ -11,11 +11,11 @@ */ #include -#include #include #include #include +#include void s5p64x0_fb_gpio_setup_24bpp(void) { diff --git a/arch/arm/mach-s5p64x0/setup-i2c0.c b/arch/arm/mach-s5p64x0/setup-i2c0.c index 569b76ac98cb..7589eb33624e 100644 --- a/arch/arm/mach-s5p64x0/setup-i2c0.c +++ b/arch/arm/mach-s5p64x0/setup-i2c0.c @@ -14,11 +14,11 @@ #include #include -#include struct platform_device; /* don't need the contents */ #include +#include #include #include "i2c.h" diff --git a/arch/arm/mach-s5p64x0/setup-i2c1.c b/arch/arm/mach-s5p64x0/setup-i2c1.c index 867374e6d0bc..f7a949b3bc55 100644 --- a/arch/arm/mach-s5p64x0/setup-i2c1.c +++ b/arch/arm/mach-s5p64x0/setup-i2c1.c @@ -14,11 +14,11 @@ #include #include -#include struct platform_device; /* don't need the contents */ #include +#include #include #include "i2c.h" diff --git a/arch/arm/mach-s5p64x0/setup-sdhci-gpio.c b/arch/arm/mach-s5p64x0/setup-sdhci-gpio.c index 8410af0d12bf..c09c5834e2fd 100644 --- a/arch/arm/mach-s5p64x0/setup-sdhci-gpio.c +++ b/arch/arm/mach-s5p64x0/setup-sdhci-gpio.c @@ -12,10 +12,10 @@ #include #include -#include #include #include +#include #include #include diff --git a/arch/arm/mach-s5p64x0/setup-spi.c b/arch/arm/mach-s5p64x0/setup-spi.c index 7664356720ca..d19d1102e28c 100644 --- a/arch/arm/mach-s5p64x0/setup-spi.c +++ b/arch/arm/mach-s5p64x0/setup-spi.c @@ -8,8 +8,8 @@ * published by the Free Software Foundation. */ -#include #include +#include #ifdef CONFIG_S3C64XX_DEV_SPI0 int s3c64xx_spi0_cfg_gpio(void) diff --git a/arch/arm/mach-s5pc100/dev-audio.c b/arch/arm/mach-s5pc100/dev-audio.c index 46f488b09391..d24f653cc0cf 100644 --- a/arch/arm/mach-s5pc100/dev-audio.c +++ b/arch/arm/mach-s5pc100/dev-audio.c @@ -10,7 +10,6 @@ #include #include -#include #include #include @@ -18,6 +17,7 @@ #include #include #include +#include static int s5pc100_cfg_i2s(struct platform_device *pdev) { diff --git a/arch/arm/mach-s5pc100/include/mach/gpio.h b/arch/arm/mach-s5pc100/include/mach/gpio-samsung.h similarity index 99% rename from arch/arm/mach-s5pc100/include/mach/gpio.h rename to arch/arm/mach-s5pc100/include/mach/gpio-samsung.h index 291c57504bab..fa239e9378f1 100644 --- a/arch/arm/mach-s5pc100/include/mach/gpio.h +++ b/arch/arm/mach-s5pc100/include/mach/gpio-samsung.h @@ -1,5 +1,4 @@ -/* arch/arm/mach-s5pc100/include/mach/gpio.h - * +/* * Copyright 2009 Samsung Electronics Co. * Byungho Min * diff --git a/arch/arm/mach-s5pc100/mach-smdkc100.c b/arch/arm/mach-s5pc100/mach-smdkc100.c index 668af3ac31f3..0710139b52eb 100644 --- a/arch/arm/mach-s5pc100/mach-smdkc100.c +++ b/arch/arm/mach-s5pc100/mach-smdkc100.c @@ -31,6 +31,7 @@ #include #include +#include #include