Merge branch 'upstream-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/jgarzik/libata-dev
* 'upstream-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/jgarzik/libata-dev: libata-sff: Reenable Port Multiplier after libata-sff remodeling. libata: skip EH autopsy and recovery during suspend ahci: AHCI and RAID mode SATA patch for Intel Patsburg DeviceIDs ata_piix: IDE Mode SATA patch for Intel Patsburg DeviceIDs libata,pata_via: revert ata_wait_idle() removal from ata_sff/via_tf_load() ahci: fix hang on failed softreset pata_artop: Fix device ID parity check
This commit is contained in:
commit
df423dc7f2
|
@ -253,6 +253,9 @@ static const struct pci_device_id ahci_pci_tbl[] = {
|
|||
{ PCI_VDEVICE(INTEL, 0x1c05), board_ahci }, /* CPT RAID */
|
||||
{ PCI_VDEVICE(INTEL, 0x1c06), board_ahci }, /* CPT RAID */
|
||||
{ PCI_VDEVICE(INTEL, 0x1c07), board_ahci }, /* CPT RAID */
|
||||
{ PCI_VDEVICE(INTEL, 0x1d02), board_ahci }, /* PBG AHCI */
|
||||
{ PCI_VDEVICE(INTEL, 0x1d04), board_ahci }, /* PBG RAID */
|
||||
{ PCI_VDEVICE(INTEL, 0x1d06), board_ahci }, /* PBG RAID */
|
||||
|
||||
/* JMicron 360/1/3/5/6, match class to avoid IDE function */
|
||||
{ PCI_VENDOR_ID_JMICRON, PCI_ANY_ID, PCI_ANY_ID, PCI_ANY_ID,
|
||||
|
|
|
@ -302,6 +302,10 @@ static const struct pci_device_id piix_pci_tbl[] = {
|
|||
{ 0x8086, 0x1c08, PCI_ANY_ID, PCI_ANY_ID, 0, 0, ich8_2port_sata },
|
||||
/* SATA Controller IDE (CPT) */
|
||||
{ 0x8086, 0x1c09, PCI_ANY_ID, PCI_ANY_ID, 0, 0, ich8_2port_sata },
|
||||
/* SATA Controller IDE (PBG) */
|
||||
{ 0x8086, 0x1d00, PCI_ANY_ID, PCI_ANY_ID, 0, 0, ich8_sata },
|
||||
/* SATA Controller IDE (PBG) */
|
||||
{ 0x8086, 0x1d08, PCI_ANY_ID, PCI_ANY_ID, 0, 0, ich8_2port_sata },
|
||||
{ } /* terminate list */
|
||||
};
|
||||
|
||||
|
|
|
@ -1326,7 +1326,7 @@ int ahci_do_softreset(struct ata_link *link, unsigned int *class,
|
|||
/* issue the first D2H Register FIS */
|
||||
msecs = 0;
|
||||
now = jiffies;
|
||||
if (time_after(now, deadline))
|
||||
if (time_after(deadline, now))
|
||||
msecs = jiffies_to_msecs(deadline - now);
|
||||
|
||||
tf.ctl |= ATA_SRST;
|
||||
|
|
|
@ -5418,6 +5418,7 @@ static int ata_host_request_pm(struct ata_host *host, pm_message_t mesg,
|
|||
*/
|
||||
int ata_host_suspend(struct ata_host *host, pm_message_t mesg)
|
||||
{
|
||||
unsigned int ehi_flags = ATA_EHI_QUIET;
|
||||
int rc;
|
||||
|
||||
/*
|
||||
|
@ -5426,7 +5427,18 @@ int ata_host_suspend(struct ata_host *host, pm_message_t mesg)
|
|||
*/
|
||||
ata_lpm_enable(host);
|
||||
|
||||
rc = ata_host_request_pm(host, mesg, 0, ATA_EHI_QUIET, 1);
|
||||
/*
|
||||
* On some hardware, device fails to respond after spun down
|
||||
* for suspend. As the device won't be used before being
|
||||
* resumed, we don't need to touch the device. Ask EH to skip
|
||||
* the usual stuff and proceed directly to suspend.
|
||||
*
|
||||
* http://thread.gmane.org/gmane.linux.ide/46764
|
||||
*/
|
||||
if (mesg.event == PM_EVENT_SUSPEND)
|
||||
ehi_flags |= ATA_EHI_NO_AUTOPSY | ATA_EHI_NO_RECOVERY;
|
||||
|
||||
rc = ata_host_request_pm(host, mesg, 0, ehi_flags, 1);
|
||||
if (rc == 0)
|
||||
host->dev->power.power_state = mesg;
|
||||
return rc;
|
||||
|
|
|
@ -3235,6 +3235,10 @@ static int ata_eh_skip_recovery(struct ata_link *link)
|
|||
if (link->flags & ATA_LFLAG_DISABLED)
|
||||
return 1;
|
||||
|
||||
/* skip if explicitly requested */
|
||||
if (ehc->i.flags & ATA_EHI_NO_RECOVERY)
|
||||
return 1;
|
||||
|
||||
/* thaw frozen port and recover failed devices */
|
||||
if ((ap->pflags & ATA_PFLAG_FROZEN) || ata_link_nr_enabled(link))
|
||||
return 0;
|
||||
|
|
|
@ -418,6 +418,7 @@ void ata_sff_tf_load(struct ata_port *ap, const struct ata_taskfile *tf)
|
|||
if (ioaddr->ctl_addr)
|
||||
iowrite8(tf->ctl, ioaddr->ctl_addr);
|
||||
ap->last_ctl = tf->ctl;
|
||||
ata_wait_idle(ap);
|
||||
}
|
||||
|
||||
if (is_addr && (tf->flags & ATA_TFLAG_LBA48)) {
|
||||
|
@ -453,6 +454,8 @@ void ata_sff_tf_load(struct ata_port *ap, const struct ata_taskfile *tf)
|
|||
iowrite8(tf->device, ioaddr->device_addr);
|
||||
VPRINTK("device 0x%X\n", tf->device);
|
||||
}
|
||||
|
||||
ata_wait_idle(ap);
|
||||
}
|
||||
EXPORT_SYMBOL_GPL(ata_sff_tf_load);
|
||||
|
||||
|
@ -1042,7 +1045,8 @@ static void ata_hsm_qc_complete(struct ata_queued_cmd *qc, int in_wq)
|
|||
int ata_sff_hsm_move(struct ata_port *ap, struct ata_queued_cmd *qc,
|
||||
u8 status, int in_wq)
|
||||
{
|
||||
struct ata_eh_info *ehi = &ap->link.eh_info;
|
||||
struct ata_link *link = qc->dev->link;
|
||||
struct ata_eh_info *ehi = &link->eh_info;
|
||||
unsigned long flags = 0;
|
||||
int poll_next;
|
||||
|
||||
|
@ -1298,8 +1302,14 @@ fsm_start:
|
|||
}
|
||||
EXPORT_SYMBOL_GPL(ata_sff_hsm_move);
|
||||
|
||||
void ata_sff_queue_pio_task(struct ata_port *ap, unsigned long delay)
|
||||
void ata_sff_queue_pio_task(struct ata_link *link, unsigned long delay)
|
||||
{
|
||||
struct ata_port *ap = link->ap;
|
||||
|
||||
WARN_ON((ap->sff_pio_task_link != NULL) &&
|
||||
(ap->sff_pio_task_link != link));
|
||||
ap->sff_pio_task_link = link;
|
||||
|
||||
/* may fail if ata_sff_flush_pio_task() in progress */
|
||||
queue_delayed_work(ata_sff_wq, &ap->sff_pio_task,
|
||||
msecs_to_jiffies(delay));
|
||||
|
@ -1321,14 +1331,18 @@ static void ata_sff_pio_task(struct work_struct *work)
|
|||
{
|
||||
struct ata_port *ap =
|
||||
container_of(work, struct ata_port, sff_pio_task.work);
|
||||
struct ata_link *link = ap->sff_pio_task_link;
|
||||
struct ata_queued_cmd *qc;
|
||||
u8 status;
|
||||
int poll_next;
|
||||
|
||||
BUG_ON(ap->sff_pio_task_link == NULL);
|
||||
/* qc can be NULL if timeout occurred */
|
||||
qc = ata_qc_from_tag(ap, ap->link.active_tag);
|
||||
if (!qc)
|
||||
qc = ata_qc_from_tag(ap, link->active_tag);
|
||||
if (!qc) {
|
||||
ap->sff_pio_task_link = NULL;
|
||||
return;
|
||||
}
|
||||
|
||||
fsm_start:
|
||||
WARN_ON_ONCE(ap->hsm_task_state == HSM_ST_IDLE);
|
||||
|
@ -1345,11 +1359,16 @@ fsm_start:
|
|||
msleep(2);
|
||||
status = ata_sff_busy_wait(ap, ATA_BUSY, 10);
|
||||
if (status & ATA_BUSY) {
|
||||
ata_sff_queue_pio_task(ap, ATA_SHORT_PAUSE);
|
||||
ata_sff_queue_pio_task(link, ATA_SHORT_PAUSE);
|
||||
return;
|
||||
}
|
||||
}
|
||||
|
||||
/*
|
||||
* hsm_move() may trigger another command to be processed.
|
||||
* clean the link beforehand.
|
||||
*/
|
||||
ap->sff_pio_task_link = NULL;
|
||||
/* move the HSM */
|
||||
poll_next = ata_sff_hsm_move(ap, qc, status, 1);
|
||||
|
||||
|
@ -1376,6 +1395,7 @@ fsm_start:
|
|||
unsigned int ata_sff_qc_issue(struct ata_queued_cmd *qc)
|
||||
{
|
||||
struct ata_port *ap = qc->ap;
|
||||
struct ata_link *link = qc->dev->link;
|
||||
|
||||
/* Use polling pio if the LLD doesn't handle
|
||||
* interrupt driven pio and atapi CDB interrupt.
|
||||
|
@ -1396,7 +1416,7 @@ unsigned int ata_sff_qc_issue(struct ata_queued_cmd *qc)
|
|||
ap->hsm_task_state = HSM_ST_LAST;
|
||||
|
||||
if (qc->tf.flags & ATA_TFLAG_POLLING)
|
||||
ata_sff_queue_pio_task(ap, 0);
|
||||
ata_sff_queue_pio_task(link, 0);
|
||||
|
||||
break;
|
||||
|
||||
|
@ -1409,7 +1429,7 @@ unsigned int ata_sff_qc_issue(struct ata_queued_cmd *qc)
|
|||
if (qc->tf.flags & ATA_TFLAG_WRITE) {
|
||||
/* PIO data out protocol */
|
||||
ap->hsm_task_state = HSM_ST_FIRST;
|
||||
ata_sff_queue_pio_task(ap, 0);
|
||||
ata_sff_queue_pio_task(link, 0);
|
||||
|
||||
/* always send first data block using the
|
||||
* ata_sff_pio_task() codepath.
|
||||
|
@ -1419,7 +1439,7 @@ unsigned int ata_sff_qc_issue(struct ata_queued_cmd *qc)
|
|||
ap->hsm_task_state = HSM_ST;
|
||||
|
||||
if (qc->tf.flags & ATA_TFLAG_POLLING)
|
||||
ata_sff_queue_pio_task(ap, 0);
|
||||
ata_sff_queue_pio_task(link, 0);
|
||||
|
||||
/* if polling, ata_sff_pio_task() handles the
|
||||
* rest. otherwise, interrupt handler takes
|
||||
|
@ -1441,7 +1461,7 @@ unsigned int ata_sff_qc_issue(struct ata_queued_cmd *qc)
|
|||
/* send cdb by polling if no cdb interrupt */
|
||||
if ((!(qc->dev->flags & ATA_DFLAG_CDB_INTR)) ||
|
||||
(qc->tf.flags & ATA_TFLAG_POLLING))
|
||||
ata_sff_queue_pio_task(ap, 0);
|
||||
ata_sff_queue_pio_task(link, 0);
|
||||
break;
|
||||
|
||||
default:
|
||||
|
@ -2734,6 +2754,7 @@ EXPORT_SYMBOL_GPL(ata_bmdma_dumb_qc_prep);
|
|||
unsigned int ata_bmdma_qc_issue(struct ata_queued_cmd *qc)
|
||||
{
|
||||
struct ata_port *ap = qc->ap;
|
||||
struct ata_link *link = qc->dev->link;
|
||||
|
||||
/* defer PIO handling to sff_qc_issue */
|
||||
if (!ata_is_dma(qc->tf.protocol))
|
||||
|
@ -2762,7 +2783,7 @@ unsigned int ata_bmdma_qc_issue(struct ata_queued_cmd *qc)
|
|||
|
||||
/* send cdb by polling if no cdb interrupt */
|
||||
if (!(qc->dev->flags & ATA_DFLAG_CDB_INTR))
|
||||
ata_sff_queue_pio_task(ap, 0);
|
||||
ata_sff_queue_pio_task(link, 0);
|
||||
break;
|
||||
|
||||
default:
|
||||
|
|
|
@ -74,7 +74,8 @@ static int artop6260_pre_reset(struct ata_link *link, unsigned long deadline)
|
|||
struct pci_dev *pdev = to_pci_dev(ap->host->dev);
|
||||
|
||||
/* Odd numbered device ids are the units with enable bits (the -R cards) */
|
||||
if (pdev->device % 1 && !pci_test_config_bits(pdev, &artop_enable_bits[ap->port_no]))
|
||||
if ((pdev->device & 1) &&
|
||||
!pci_test_config_bits(pdev, &artop_enable_bits[ap->port_no]))
|
||||
return -ENOENT;
|
||||
|
||||
return ata_sff_prereset(link, deadline);
|
||||
|
|
|
@ -417,6 +417,8 @@ static void via_tf_load(struct ata_port *ap, const struct ata_taskfile *tf)
|
|||
tf->lbam,
|
||||
tf->lbah);
|
||||
}
|
||||
|
||||
ata_wait_idle(ap);
|
||||
}
|
||||
|
||||
static int via_port_start(struct ata_port *ap)
|
||||
|
|
|
@ -2284,7 +2284,7 @@ static unsigned int mv_qc_issue_fis(struct ata_queued_cmd *qc)
|
|||
}
|
||||
|
||||
if (qc->tf.flags & ATA_TFLAG_POLLING)
|
||||
ata_sff_queue_pio_task(ap, 0);
|
||||
ata_sff_queue_pio_task(link, 0);
|
||||
return 0;
|
||||
}
|
||||
|
||||
|
|
|
@ -335,6 +335,7 @@ enum {
|
|||
ATA_EHI_HOTPLUGGED = (1 << 0), /* could have been hotplugged */
|
||||
ATA_EHI_NO_AUTOPSY = (1 << 2), /* no autopsy */
|
||||
ATA_EHI_QUIET = (1 << 3), /* be quiet */
|
||||
ATA_EHI_NO_RECOVERY = (1 << 4), /* no recovery */
|
||||
|
||||
ATA_EHI_DID_SOFTRESET = (1 << 16), /* already soft-reset this port */
|
||||
ATA_EHI_DID_HARDRESET = (1 << 17), /* already soft-reset this port */
|
||||
|
@ -723,6 +724,7 @@ struct ata_port {
|
|||
struct ata_ioports ioaddr; /* ATA cmd/ctl/dma register blocks */
|
||||
u8 ctl; /* cache of ATA control register */
|
||||
u8 last_ctl; /* Cache last written value */
|
||||
struct ata_link* sff_pio_task_link; /* link currently used */
|
||||
struct delayed_work sff_pio_task;
|
||||
#ifdef CONFIG_ATA_BMDMA
|
||||
struct ata_bmdma_prd *bmdma_prd; /* BMDMA SG list */
|
||||
|
@ -1594,7 +1596,7 @@ extern void ata_sff_irq_on(struct ata_port *ap);
|
|||
extern void ata_sff_irq_clear(struct ata_port *ap);
|
||||
extern int ata_sff_hsm_move(struct ata_port *ap, struct ata_queued_cmd *qc,
|
||||
u8 status, int in_wq);
|
||||
extern void ata_sff_queue_pio_task(struct ata_port *ap, unsigned long delay);
|
||||
extern void ata_sff_queue_pio_task(struct ata_link *link, unsigned long delay);
|
||||
extern unsigned int ata_sff_qc_issue(struct ata_queued_cmd *qc);
|
||||
extern bool ata_sff_qc_fill_rtf(struct ata_queued_cmd *qc);
|
||||
extern unsigned int ata_sff_port_intr(struct ata_port *ap,
|
||||
|
|
Loading…
Reference in New Issue