selftests/bpf: check return value of fopen in test_verifier.c
Commit0a67487403
("selftests/bpf: Only run tests if !bpf_disabled") forgot to check return value of fopen. This caused some confusion, when running test_verifier (from tools/testing/selftests/bpf/) on an older kernel (< v4.4) as it will simply seqfault. This fix avoids the segfault and prints an error, but allow program to continue. Given the sysctl was introduced in1be7f75d16
("bpf: enable non-root eBPF programs"), we know that the running kernel cannot support unpriv, thus continue with unpriv_disabled = true. Fixes:0a67487403
("selftests/bpf: Only run tests if !bpf_disabled") Signed-off-by: Jesper Dangaard Brouer <brouer@redhat.com> Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
This commit is contained in:
parent
02f99df187
commit
deea81228b
|
@ -11713,6 +11713,11 @@ static void get_unpriv_disabled()
|
|||
FILE *fd;
|
||||
|
||||
fd = fopen("/proc/sys/"UNPRIV_SYSCTL, "r");
|
||||
if (!fd) {
|
||||
perror("fopen /proc/sys/"UNPRIV_SYSCTL);
|
||||
unpriv_disabled = true;
|
||||
return;
|
||||
}
|
||||
if (fgets(buf, 2, fd) == buf && atoi(buf))
|
||||
unpriv_disabled = true;
|
||||
fclose(fd);
|
||||
|
|
Loading…
Reference in New Issue