hollalinux
/
linux-sg2042
mirror of https://github.com/sophgo/linux-riscv.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

mfd: ab8500-debugfs: Clean-up non-conforming commenting and print formatting 

WARNING: Block comments use a trailing */ on a separate line
+                        * not be accessed from here */

WARNING: Block comments use a trailing */ on a separate line
+                        * not be accessed from here */

WARNING: Block comments use a trailing */ on a separate line
+                                * the output is wanted in any case */

WARNING: Consecutive strings are generally better as a single string
+               "  addr=0x%08X, mask=0x%X, shift=%d" "value=0x%X\n",

total: 0 errors, 4 warnings, 3331 lines checked

Cc: Linus Walleij <linus.walleij@linaro.org>
Signed-off-by: Lee Jones <lee.jones@linaro.org>
This commit is contained in:
Lee Jones 2015-10-28 09:27:32 +00:00
parent 500e69a101
commit de6a769333
1 changed files with 15 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

25
drivers/mfd/ab8500-debugfs.c
View File

@ -242,8 +242,10 @@ static struct ab8500_prcmu_ranges ab8500_debug_ranges[AB8500_NUM_BANKS] = {
.first = 0x40, .first = 0x40,
.last = 0x44, .last = 0x44,
}, },
/* 0x80-0x8B is SIM registers and should /*
* not be accessed from here */ * 0x80-0x8B are SIM registers and should
* not be accessed from here
*/
}, },
}, },
[AB8500_USB] = { [AB8500_USB] = {
@ -587,8 +589,10 @@ static struct ab8500_prcmu_ranges ab8505_debug_ranges[AB8500_NUM_BANKS] = {
.first = 0x40, .first = 0x40,
.last = 0x48, .last = 0x48,
}, },
/* 0x80-0x8B is SIM registers and should /*
* not be accessed from here */ * 0x80-0x8B are SIM registers and should
* not be accessed from here
*/
}, },
}, },
[AB8500_USB] = { [AB8500_USB] = {
@ -1306,8 +1310,10 @@ static int ab8500_registers_print(struct device *dev, u32 bank,
if (s) { if (s) {
seq_printf(s, " [0x%02X/0x%02X]: 0x%02X\n", seq_printf(s, " [0x%02X/0x%02X]: 0x%02X\n",
bank, reg, value); bank, reg, value);
/* Error is not returned here since /*
* the output is wanted in any case */ * Error is not returned here since
* the output is wanted in any case
*/
if (seq_has_overflowed(s)) if (seq_has_overflowed(s))
return 0; return 0;
} else { } else {
@ -2740,10 +2746,9 @@ static ssize_t hwreg_common_write(char *b, struct hwreg_cfg *cfg,
*cfg = loc; *cfg = loc;
#ifdef ABB_HWREG_DEBUG #ifdef ABB_HWREG_DEBUG
pr_warn("HWREG request: %s, %s,\n" pr_warn("HWREG request: %s, %s,\n", (write) ? "write" : "read",
" addr=0x%08X, mask=0x%X, shift=%d" "value=0x%X\n", REG_FMT_DEC(cfg) ? "decimal" : "hexa");
(write) ? "write" : "read", pr_warn(" addr=0x%08X, mask=0x%X, shift=%d" "value=0x%X\n",
REG_FMT_DEC(cfg) ? "decimal" : "hexa",
cfg->addr, cfg->mask, cfg->shift, val); cfg->addr, cfg->mask, cfg->shift, val);
#endif #endif