hollalinux
/
linux-sg2042
mirror of https://github.com/sophgo/linux-riscv.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

TPM: tpm_nsc: Fix a double free of pdev in cleanup_nsc 

platform_device_unregister() will release all resources
and remove it from the subsystem, then drop reference count by
calling platform_device_put().

We should not call kfree(pdev) after platform_device_unregister(pdev).

Signed-off-by: Axel Lin <axel.lin@gmail.com>
Signed-off-by: Rajiv Andrade <srajiv@linux.vnet.ibm.com>
Signed-off-by: James Morris <jmorris@namei.org>
This commit is contained in:
Axel Lin 2011-08-04 07:58:07 +08:00 committed by James Morris
parent 5ce5ed3593
commit de69113ec1
1 changed files with 0 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/char/tpm/tpm_nsc.c
View File

@ -396,8 +396,6 @@ static void __exit cleanup_nsc(void)
if (pdev) { if (pdev) {
tpm_nsc_remove(&pdev->dev); tpm_nsc_remove(&pdev->dev);
platform_device_unregister(pdev); platform_device_unregister(pdev);
kfree(pdev);
pdev = NULL;
} }
platform_driver_unregister(&nsc_drv); platform_driver_unregister(&nsc_drv);