hollalinux
/
linux-sg2042
mirror of https://github.com/sophgo/linux-riscv.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

media: i2c: ov2685: simplify getting state container 

The pointer to 'struct v4l2_subdev' is stored in drvdata via
v4l2_i2c_subdev_init() so there is no point of a dance like:

    struct i2c_client *client = to_i2c_client(struct device *dev)
    struct v4l2_subdev *sd = i2c_get_clientdata(client);

This allows to remove local variable 'client' and few pointer
dereferences.

Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
This commit is contained in:
Krzysztof Kozlowski 2020-09-21 18:23:34 +02:00 committed by Mauro Carvalho Chehab
parent 7519296da4
commit dab24a220e
1 changed files with 2 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
drivers/media/i2c/ov2685.c
View File

@ -506,8 +506,7 @@ static int ov2685_open(struct v4l2_subdev *sd, struct v4l2_subdev_fh *fh)
static int __maybe_unused ov2685_runtime_resume(struct device *dev) static int __maybe_unused ov2685_runtime_resume(struct device *dev)
{ {
struct i2c_client *client = to_i2c_client(dev); struct v4l2_subdev *sd = dev_get_drvdata(dev);
struct v4l2_subdev *sd = i2c_get_clientdata(client);
struct ov2685 *ov2685 = to_ov2685(sd); struct ov2685 *ov2685 = to_ov2685(sd);
return __ov2685_power_on(ov2685); return __ov2685_power_on(ov2685);
@ -515,8 +514,7 @@ static int __maybe_unused ov2685_runtime_resume(struct device *dev)
static int __maybe_unused ov2685_runtime_suspend(struct device *dev) static int __maybe_unused ov2685_runtime_suspend(struct device *dev)
{ {
struct i2c_client *client = to_i2c_client(dev); struct v4l2_subdev *sd = dev_get_drvdata(dev);
struct v4l2_subdev *sd = i2c_get_clientdata(client);
struct ov2685 *ov2685 = to_ov2685(sd); struct ov2685 *ov2685 = to_ov2685(sd);
__ov2685_power_off(ov2685); __ov2685_power_off(ov2685);