USB: avoid needless address-taking of function parameters
There's no need to take the address of the function params or local variables when the direct value byteswapping routines are available. Signed-off-by: Harvey Harrison <harvey.harrison@gmail.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
This commit is contained in:
parent
aa459e6a2e
commit
da2bbdcc38
|
@ -283,9 +283,9 @@ static int kaweth_control(struct kaweth_device *kaweth,
|
||||||
|
|
||||||
dr->bRequestType= requesttype;
|
dr->bRequestType= requesttype;
|
||||||
dr->bRequest = request;
|
dr->bRequest = request;
|
||||||
dr->wValue = cpu_to_le16p(&value);
|
dr->wValue = cpu_to_le16(value);
|
||||||
dr->wIndex = cpu_to_le16p(&index);
|
dr->wIndex = cpu_to_le16(index);
|
||||||
dr->wLength = cpu_to_le16p(&size);
|
dr->wLength = cpu_to_le16(size);
|
||||||
|
|
||||||
return kaweth_internal_control_msg(kaweth->dev,
|
return kaweth_internal_control_msg(kaweth->dev,
|
||||||
pipe,
|
pipe,
|
||||||
|
|
|
@ -150,8 +150,8 @@ static int get_registers(pegasus_t * pegasus, __u16 indx, __u16 size,
|
||||||
pegasus->dr.bRequestType = PEGASUS_REQT_READ;
|
pegasus->dr.bRequestType = PEGASUS_REQT_READ;
|
||||||
pegasus->dr.bRequest = PEGASUS_REQ_GET_REGS;
|
pegasus->dr.bRequest = PEGASUS_REQ_GET_REGS;
|
||||||
pegasus->dr.wValue = cpu_to_le16(0);
|
pegasus->dr.wValue = cpu_to_le16(0);
|
||||||
pegasus->dr.wIndex = cpu_to_le16p(&indx);
|
pegasus->dr.wIndex = cpu_to_le16(indx);
|
||||||
pegasus->dr.wLength = cpu_to_le16p(&size);
|
pegasus->dr.wLength = cpu_to_le16(size);
|
||||||
pegasus->ctrl_urb->transfer_buffer_length = size;
|
pegasus->ctrl_urb->transfer_buffer_length = size;
|
||||||
|
|
||||||
usb_fill_control_urb(pegasus->ctrl_urb, pegasus->usb,
|
usb_fill_control_urb(pegasus->ctrl_urb, pegasus->usb,
|
||||||
|
@ -208,8 +208,8 @@ static int set_registers(pegasus_t * pegasus, __u16 indx, __u16 size,
|
||||||
pegasus->dr.bRequestType = PEGASUS_REQT_WRITE;
|
pegasus->dr.bRequestType = PEGASUS_REQT_WRITE;
|
||||||
pegasus->dr.bRequest = PEGASUS_REQ_SET_REGS;
|
pegasus->dr.bRequest = PEGASUS_REQ_SET_REGS;
|
||||||
pegasus->dr.wValue = cpu_to_le16(0);
|
pegasus->dr.wValue = cpu_to_le16(0);
|
||||||
pegasus->dr.wIndex = cpu_to_le16p(&indx);
|
pegasus->dr.wIndex = cpu_to_le16(indx);
|
||||||
pegasus->dr.wLength = cpu_to_le16p(&size);
|
pegasus->dr.wLength = cpu_to_le16(size);
|
||||||
pegasus->ctrl_urb->transfer_buffer_length = size;
|
pegasus->ctrl_urb->transfer_buffer_length = size;
|
||||||
|
|
||||||
usb_fill_control_urb(pegasus->ctrl_urb, pegasus->usb,
|
usb_fill_control_urb(pegasus->ctrl_urb, pegasus->usb,
|
||||||
|
@ -261,7 +261,7 @@ static int set_register(pegasus_t * pegasus, __u16 indx, __u8 data)
|
||||||
pegasus->dr.bRequestType = PEGASUS_REQT_WRITE;
|
pegasus->dr.bRequestType = PEGASUS_REQT_WRITE;
|
||||||
pegasus->dr.bRequest = PEGASUS_REQ_SET_REG;
|
pegasus->dr.bRequest = PEGASUS_REQ_SET_REG;
|
||||||
pegasus->dr.wValue = cpu_to_le16(data);
|
pegasus->dr.wValue = cpu_to_le16(data);
|
||||||
pegasus->dr.wIndex = cpu_to_le16p(&indx);
|
pegasus->dr.wIndex = cpu_to_le16(indx);
|
||||||
pegasus->dr.wLength = cpu_to_le16(1);
|
pegasus->dr.wLength = cpu_to_le16(1);
|
||||||
pegasus->ctrl_urb->transfer_buffer_length = 1;
|
pegasus->ctrl_urb->transfer_buffer_length = 1;
|
||||||
|
|
||||||
|
@ -476,7 +476,7 @@ static inline void get_node_id(pegasus_t * pegasus, __u8 * id)
|
||||||
|
|
||||||
for (i = 0; i < 3; i++) {
|
for (i = 0; i < 3; i++) {
|
||||||
read_eprom_word(pegasus, i, &w16);
|
read_eprom_word(pegasus, i, &w16);
|
||||||
((__le16 *) id)[i] = cpu_to_le16p(&w16);
|
((__le16 *) id)[i] = cpu_to_le16(w16);
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|
|
@ -139,9 +139,9 @@ int usb_control_msg(struct usb_device *dev, unsigned int pipe, __u8 request,
|
||||||
|
|
||||||
dr->bRequestType = requesttype;
|
dr->bRequestType = requesttype;
|
||||||
dr->bRequest = request;
|
dr->bRequest = request;
|
||||||
dr->wValue = cpu_to_le16p(&value);
|
dr->wValue = cpu_to_le16(value);
|
||||||
dr->wIndex = cpu_to_le16p(&index);
|
dr->wIndex = cpu_to_le16(index);
|
||||||
dr->wLength = cpu_to_le16p(&size);
|
dr->wLength = cpu_to_le16(size);
|
||||||
|
|
||||||
/* dbg("usb_control_msg"); */
|
/* dbg("usb_control_msg"); */
|
||||||
|
|
||||||
|
|
|
@ -669,7 +669,7 @@ fill_dma_desc (struct net2280_ep *ep, struct net2280_request *req, int valid)
|
||||||
|
|
||||||
/* 2280 may be polling VALID_BIT through ep->dma->dmadesc */
|
/* 2280 may be polling VALID_BIT through ep->dma->dmadesc */
|
||||||
wmb ();
|
wmb ();
|
||||||
td->dmacount = cpu_to_le32p (&dmacount);
|
td->dmacount = cpu_to_le32(dmacount);
|
||||||
}
|
}
|
||||||
|
|
||||||
static const u32 dmactl_default =
|
static const u32 dmactl_default =
|
||||||
|
|
Loading…
Reference in New Issue