firewire net: Fix leakage of kmap for broadcast receive buffer.

Signed-off-by: YOSHIFUJI Hideaki <yoshfuji@linux-ipv6.org>
Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>
This commit is contained in:
YOSHIFUJI Hideaki 2013-03-08 10:43:37 +09:00 committed by Stefan Richter
parent f2090594dd
commit d9d2b484e0
1 changed files with 7 additions and 0 deletions

View File

@ -1228,6 +1228,8 @@ static int fwnet_broadcast_start(struct fwnet_device *dev)
failed_rcv_queue: failed_rcv_queue:
kfree(dev->broadcast_rcv_buffer_ptrs); kfree(dev->broadcast_rcv_buffer_ptrs);
dev->broadcast_rcv_buffer_ptrs = NULL; dev->broadcast_rcv_buffer_ptrs = NULL;
for (u = 0; u < FWNET_ISO_PAGE_COUNT; u++)
kunmap(dev->broadcast_rcv_buffer.pages[u]);
failed_ptrs_alloc: failed_ptrs_alloc:
fw_iso_buffer_destroy(&dev->broadcast_rcv_buffer, dev->card); fw_iso_buffer_destroy(&dev->broadcast_rcv_buffer, dev->card);
failed_buffer_init: failed_buffer_init:
@ -1620,10 +1622,15 @@ static int fwnet_remove(struct device *_dev)
fwnet_fifo_stop(dev); fwnet_fifo_stop(dev);
if (dev->broadcast_rcv_context) { if (dev->broadcast_rcv_context) {
unsigned u;
fw_iso_context_stop(dev->broadcast_rcv_context); fw_iso_context_stop(dev->broadcast_rcv_context);
kfree(dev->broadcast_rcv_buffer_ptrs); kfree(dev->broadcast_rcv_buffer_ptrs);
dev->broadcast_rcv_buffer_ptrs = NULL; dev->broadcast_rcv_buffer_ptrs = NULL;
for (u = 0; u < FWNET_ISO_PAGE_COUNT; u++)
kunmap(dev->broadcast_rcv_buffer.pages[u]);
fw_iso_buffer_destroy(&dev->broadcast_rcv_buffer, fw_iso_buffer_destroy(&dev->broadcast_rcv_buffer,
dev->card); dev->card);
fw_iso_context_destroy(dev->broadcast_rcv_context); fw_iso_context_destroy(dev->broadcast_rcv_context);