[PATCH] i386: Clean up smp_tune_scheduling()
- remove the write-only local variable "bandwidth" - don't set "max_cache_size" in the (cachesize < 0) case: that's already handled in kernel/sched.c:measure_migration_cost() Signed-off-by: Adrian Bunk <bunk@stusta.de> Signed-off-by: Andi Kleen <ak@suse.de> Acked-by: Ingo Molnar <mingo@elte.hu> Signed-off-by: Andrew Morton <akpm@osdl.org>
This commit is contained in:
parent
b65780e123
commit
d9408cefe6
|
@ -1130,34 +1130,15 @@ exit:
|
||||||
}
|
}
|
||||||
#endif
|
#endif
|
||||||
|
|
||||||
static void smp_tune_scheduling (void)
|
static void smp_tune_scheduling(void)
|
||||||
{
|
{
|
||||||
unsigned long cachesize; /* kB */
|
unsigned long cachesize; /* kB */
|
||||||
unsigned long bandwidth = 350; /* MB/s */
|
|
||||||
/*
|
|
||||||
* Rough estimation for SMP scheduling, this is the number of
|
|
||||||
* cycles it takes for a fully memory-limited process to flush
|
|
||||||
* the SMP-local cache.
|
|
||||||
*
|
|
||||||
* (For a P5 this pretty much means we will choose another idle
|
|
||||||
* CPU almost always at wakeup time (this is due to the small
|
|
||||||
* L1 cache), on PIIs it's around 50-100 usecs, depending on
|
|
||||||
* the cache size)
|
|
||||||
*/
|
|
||||||
|
|
||||||
if (!cpu_khz) {
|
if (cpu_khz) {
|
||||||
/*
|
|
||||||
* this basically disables processor-affinity
|
|
||||||
* scheduling on SMP without a TSC.
|
|
||||||
*/
|
|
||||||
return;
|
|
||||||
} else {
|
|
||||||
cachesize = boot_cpu_data.x86_cache_size;
|
cachesize = boot_cpu_data.x86_cache_size;
|
||||||
if (cachesize == -1) {
|
|
||||||
cachesize = 16; /* Pentiums, 2x8kB cache */
|
if (cachesize > 0)
|
||||||
bandwidth = 100;
|
max_cache_size = cachesize * 1024;
|
||||||
}
|
|
||||||
max_cache_size = cachesize * 1024;
|
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|
Loading…
Reference in New Issue