panic, smp: provide smp_send_stop() wrapper on UP too

Impact: cleanup, no code changed

Remove an ugly #ifdef CONFIG_SMP from panic(), by providing
an smp_send_stop() wrapper on UP too.

LKML-Reference: <49B91A7E.76E4.0078.0@novell.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
This commit is contained in:
Ingo Molnar 2009-03-13 11:14:06 +01:00
parent ffd71da4e3
commit d1dedb52ac
2 changed files with 3 additions and 3 deletions

View File

@ -38,7 +38,7 @@ int smp_call_function_single(int cpuid, void (*func) (void *info), void *info,
/* /*
* main cross-CPU interfaces, handles INIT, TLB flush, STOP, etc. * main cross-CPU interfaces, handles INIT, TLB flush, STOP, etc.
* (defined in asm header): * (defined in asm header):
*/ */
/* /*
* stops all CPUs but the current one: * stops all CPUs but the current one:
@ -122,6 +122,8 @@ extern unsigned int setup_max_cpus;
#else /* !SMP */ #else /* !SMP */
static inline void smp_send_stop(void) { }
/* /*
* These macros fold the SMP functionality into a single CPU system * These macros fold the SMP functionality into a single CPU system
*/ */

View File

@ -85,14 +85,12 @@ NORET_TYPE void panic(const char * fmt, ...)
*/ */
crash_kexec(NULL); crash_kexec(NULL);
#ifdef CONFIG_SMP
/* /*
* Note smp_send_stop is the usual smp shutdown function, which * Note smp_send_stop is the usual smp shutdown function, which
* unfortunately means it may not be hardened to work in a panic * unfortunately means it may not be hardened to work in a panic
* situation. * situation.
*/ */
smp_send_stop(); smp_send_stop();
#endif
atomic_notifier_call_chain(&panic_notifier_list, 0, buf); atomic_notifier_call_chain(&panic_notifier_list, 0, buf);