hollalinux
/
linux-sg2042
mirror of https://github.com/sophgo/linux-riscv.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

staging: lustre: lov: fix dereference of ERR_PTR 

If lov_sub_get() fails then it returns the error code in ERR_PTR, but
here we were dereferencing sub without checking if lov_sub_get() has
actually succeeded or not. And on error we can directly return the error
code from lov_io_fault_start() as it return 0 on success and the error
code on error.

Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Sudip Mukherjee 2015-09-08 21:53:01 +05:30 committed by Greg Kroah-Hartman
parent 2ced12a7f8
commit d0f69b5a66
1 changed files with 2 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/staging/lustre/lustre/lov/lov_io.c
View File

@ -729,6 +729,8 @@ static int lov_io_fault_start(const struct lu_env *env,
fio = &ios->cis_io->u.ci_fault; fio = &ios->cis_io->u.ci_fault;
lio = cl2lov_io(env, ios); lio = cl2lov_io(env, ios);
sub = lov_sub_get(env, lio, lov_page_stripe(fio->ft_page)); sub = lov_sub_get(env, lio, lov_page_stripe(fio->ft_page));
if (IS_ERR(sub))
return PTR_ERR(sub);
sub->sub_io->u.ci_fault.ft_nob = fio->ft_nob; sub->sub_io->u.ci_fault.ft_nob = fio->ft_nob;
lov_sub_put(sub); lov_sub_put(sub);
return lov_io_start(env, ios); return lov_io_start(env, ios);